[GitHub] wu-sheng commented on issue #954: Support namespace in sw3 headers.

2018-03-17 Thread GitBox
wu-sheng commented on issue #954: Support namespace in sw3 headers. URL: https://github.com/apache/incubator-skywalking/pull/954#issuecomment-373962929 > I meant to say, lgtm! :) Thanks. This is an automated message fr

[GitHub] pragashj commented on issue #954: Support namespace in sw3 headers.

2018-03-17 Thread GitBox
pragashj commented on issue #954: Support namespace in sw3 headers. URL: https://github.com/apache/incubator-skywalking/pull/954#issuecomment-373961110 I meant to say, lgtm! This is an automated message from the Apache Git S

[GitHub] wu-sheng commented on issue #954: Support namespace in sw3 headers.

2018-03-17 Thread GitBox
wu-sheng commented on issue #954: Support namespace in sw3 headers. URL: https://github.com/apache/incubator-skywalking/pull/954#issuecomment-373960227 @pragashj in default, yes. only active the namespace after end user set it in config file, or system. env ---

[GitHub] pragashj commented on issue #954: Support namespace in sw3 headers.

2018-03-17 Thread GitBox
pragashj commented on issue #954: Support namespace in sw3 headers. URL: https://github.com/apache/incubator-skywalking/pull/954#issuecomment-373959627 blank (ing) on namespace... :) This is an automated message from the Apac

[GitHub] wu-sheng closed pull request #957: remove repotoken

2018-03-17 Thread GitBox
wu-sheng closed pull request #957: remove repotoken URL: https://github.com/apache/incubator-skywalking/pull/957 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (f

[GitHub] coveralls commented on issue #957: remove repotoken

2018-03-17 Thread GitBox
coveralls commented on issue #957: remove repotoken URL: https://github.com/apache/incubator-skywalking/pull/957#issuecomment-373925974 [![Coverage Status](https://coveralls.io/builds/16032024/badge)](https://coveralls.io/builds/16032024) Coverage remained the same at 19.186% wh

[GitHub] oflebbe opened a new pull request #957: remove repotoken

2018-03-17 Thread GitBox
oflebbe opened a new pull request #957: remove repotoken URL: https://github.com/apache/incubator-skywalking/pull/957 Please answer these questions before submitting pull request - Why submit this pull request? - [ X] Bug fix - [ ] New feature provided - [ ] Improve performan

Re: [VOTE] Release Apache SkyWalking (Incubating) 5.0.0-alpha

2018-03-17 Thread John D. Ament
On Sat, Mar 17, 2018 at 9:00 AM 吴晟 Sheng Wu wrote: > Thanks, John. > I am going to work on the missing stuff. I staged the dist in > https://repository.apache.org/ as > https://dist.apache.org/repos/dist/dev/incubator/skywalking > I think maybe I misunderstand something? > > I would recommend you

Re: [VOTE] Release Apache SkyWalking (Incubating) 5.0.0-alpha

2018-03-17 Thread ???? Sheng Wu
John, sorry, wrong URL. staged here https://repository.apache.org/content/repositories/orgapacheskywalking-1002/org/apache/skywalking/apm-dist/5.0.0-alpha/ ---Original--- From: " Sheng Wu" Date: Sat, Mar 17, 2018 21:00 PM To: "general"; Cc: "dev"; Subject: Re: [VOTE] Release Apache Sk

Re: [VOTE] Release Apache SkyWalking (Incubating) 5.0.0-alpha

2018-03-17 Thread ???? Sheng Wu
Thanks, John. I am going to work on the missing stuff. I staged the dist in https://repository.apache.org/ as https://dist.apache.org/repos/dist/dev/incubator/skywalking I think maybe I misunderstand something? And release vote has waited in skywalking dev mail list more than 72 hours, 14-17

Re: [VOTE] Release Apache SkyWalking (Incubating) 5.0.0-alpha

2018-03-17 Thread John D. Ament
Sheng, For the IPMC to consider the release vote, the release candidate must be staged on https://dist.apache.org/repos/dist/dev/incubator/skywalking . Please note that this URL does not exist yet, you should work with your mentors to get this created. You'll need both the dev area and the releas

[VOTE] Release Apache SkyWalking (Incubating) 5.0.0-alpha

2018-03-17 Thread ???? Sheng Wu
Hi IPMC, This is a call for vote to release Apache SkyWalking (Incubating) version 5.0.0-alpha. The Apache SkyWalking community has tested, voted and approved the proposed release of Apache SkyWalking (Incubating) 5.0.0-alpha We now kindly request the Incubator PMC members review and vote on th

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha

2018-03-17 Thread Sheng Wu
Thanks everyone. Vote result: 4 (+1 binding), all PPMCs voted. 3 (+1 no binding), 3 committers voted. So, I will start the vote in IPMC mail list. On 2018/03/14 06:37:35, "吴晟 Sheng Wu" wrote: > Hi All, > This is a call for vote to release Apache SkyWalking (Incubating) version > 5.0.0-alp