Re: [DISCUSS] About the environment of skywalking nginx lua

2020-02-25 Thread Sheng Wu
To APISIX team A PR(https://github.com/apache/skywalking-nginx-lua/pull/4) from SkyWalking committer has been starting about the e2e tests. This is an official and traditional test, in which the SkyWalking community is required and highly recommended. This one will set up a simulator backend, and

Re: [DISCUSS] About the environment of skywalking nginx lua

2020-02-25 Thread YuanSheng Wang
> Could you explain why we need native nginx LUA? What is the difference? Unlike Java, Golang, and other languages, Lua is an embedded language. It will have completely different API functions depending on the host program. In addition, Lua, like Python, has several different versions, such as

Re: [DISCUSS] About the environment of skywalking nginx lua

2020-02-25 Thread Ming Wen
I cerated a small PR[1] for that. for example, the nginx lua has `split`, `timestamp` APIs which not need to implement by lua again, and with better performance. I know what you mean. This library can not only be used by nginx Lua, but also be reused by programs written by pure Lua. I will try

Re: [DISCUSS] About the environment of skywalking nginx lua

2020-02-25 Thread Sheng Wu
Ming Wen 于2020年2月26日周三 上午11:37写道: > hello, skywalking dev team, > > I am adding CI and test cases for nginx lua to this project[1]. I found > that most of the code was implemented using Lua code instead of the native > nginx lua API. > > I am trying to refactor in the way of nginx lua, and now

[DISCUSS] About the environment of skywalking nginx lua

2020-02-25 Thread Ming Wen
hello, skywalking dev team, I am adding CI and test cases for nginx lua to this project[1]. I found that most of the code was implemented using Lua code instead of the native nginx lua API. I am trying to refactor in the way of nginx lua, and now there are two issues that need to be discussed