Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-07 Thread Justin Mclean
HI, > Is there any doc saying, there is only one kind of announcement? It's used for several things: - adding new committers, PMC members and chairs - for releases - conferences or other important events for release it has a singular meaning. I don't think it appropriate in this case and it

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-07 Thread Sheng Wu
Hi Wei Zhang Thanks for the feedback. Your case + the e2e tests, I think this release RC is good enough. I will initial the official vote soon. Sheng Wu 吴晟 Twitter, wusheng1108 Wei Zhang 于2020年3月7日周六 下午2:47写道: > > HI, > > I built a java -> nginx -> java test environment based on PR [1] and

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Sheng Wu
I don't want to argue about the word choice. This was from several years ago, I even couldn't remember what is the background. >From my understanding, this is a status sync announcement to the active dev team, telling thing this is a frozen code tag, which is going to be released, please check

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Justin Mclean
HI, Then why say "This is our Apache release." when it is not an release yet? You can only call something a release after you have voted on it, before that is it a release candidate. ANNOUNCEMENTS are for releases and occurs after a successful VOTE. What some projects do in this situation is

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Wei Zhang
HI, I built a java -> nginx -> java test environment based on PR [1] and nginx 0.1.0. No problem found. Attach a screenshot [2] . [1] https://github.com/apache/skywalking/pull/4454 [2] https://github.com/arugal/skywalking-nginx-lua-test

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Sheng Wu
Hi Justin This is a test announcement, to ask the dev team to do the test. The official release vote process hasn't begun. The mail title is `SkyWalking Nginx LUA 0.1.0 *test build available*`, not release. Sheng Wu 吴晟 Twitter, wusheng1108 Justin Mclean 于2020年3月7日周六 上午11:10写道: > HI, > >

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Justin Mclean
HI, Before announcing releases you need to VOTE on them [1], where was the vote for this release? Thanks, Justin 1. http://www.apache.org/dev/release-publishing.html#voted

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Sheng Wu
Based on the main repo e2e test, this commit id has passed the test[1]. [1] https://github.com/apache/skywalking/pull/4452 Sheng Wu 吴晟 Twitter, wusheng1108 Ming Wen 于2020年3月6日周五 下午9:51写道: > good job!look forward to it > > Sheng Wu 于2020年3月6日 周五下午9:49写道: > > > SkyWalking backend has supported

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Ming Wen
good job!look forward to it Sheng Wu 于2020年3月6日 周五下午9:49写道: > SkyWalking backend has supported the HTTP 1.1 + JSON for LUA agent in the > master branch. > > Notify the APISIX team, we are doing the SkyWalking Nginx LUA agent 0.1.0 > release now. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > Jian

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Sheng Wu
SkyWalking backend has supported the HTTP 1.1 + JSON for LUA agent in the master branch. Notify the APISIX team, we are doing the SkyWalking Nginx LUA agent 0.1.0 release now. Sheng Wu 吴晟 Twitter, wusheng1108 Jian Tan 于2020年3月6日周五 下午9:42写道: > Great works! Skywalking got a new feature, and

Re: [ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Jian Tan
Great works! Skywalking got a new feature, and so fast release. Sheng Wu 于2020年3月6日周五 下午9:24写道: > The test build of 0.1.0 is available. > > This is our Apache release. > We welcome any comments you may have, and will take all feedback into > account if a quality vote is called for this build.

[ANNOUNCE] SkyWalking Nginx LUA 0.1.0 test build available

2020-03-06 Thread Sheng Wu
The test build of 0.1.0 is available. This is our Apache release. We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build. Release notes: * https://github.com/apache/skywalking-nginx-lua/blob/v0.1.0/CHANGES.md Release Candidate: