[GitHub] ascrutae opened a new pull request #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
ascrutae opened a new pull request #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676 The skywalking plugin can't import any class in the framework jar. it cause some question about classloader.

[GitHub] ascrutae commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
ascrutae commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351725912 @wu-sheng yeah. you are right. I had changed the constructor matcher to `any`, maybe the `any` matcher will more

[GitHub] myoss commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351733368 it's ok This is an automated message from the

[GitHub] peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-14 Thread GitBox
peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351712699 Sorry, I misunderstand the word distinguish as distributed. I don't recommend every one to share

[GitHub] wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351712867 ```java @Override public ElementMatcher getConstructorMatcher() { return

[GitHub] wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351724187 > I am not sure that if this class would be changed in the next version since the newest version is 3.9.1

[GitHub] zone1511 opened a new issue #677: collector window script fail to start

2017-12-14 Thread GitBox
zone1511 opened a new issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677 ### What did you do? If possible, provide a way for reproducing the error. e.g. demo application, component version. the file

[GitHub] wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351718822 > The skywalking plugin can't import any class in the framework jar. it cause some question about classloader.

[GitHub] ascrutae commented on issue #677: collector window script fail to start

2017-12-14 Thread GitBox
ascrutae commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-351857052 which version are you used? This is an automated message from the

[GitHub] ascrutae commented on issue #677: collector window script fail to start

2017-12-14 Thread GitBox
ascrutae commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-351860313 This is an issue If you use the `5.0-2018-prevision` version. and I try to fix is in PR #678.

[GitHub] ascrutae commented on issue #677: collector window script fail to start

2017-12-14 Thread GitBox
ascrutae commented on issue #677: collector window script fail to start URL: https://github.com/apache/incubator-skywalking/issues/677#issuecomment-351860313 This is an issue If you use the `5.0-2018-prevision` version. and I try to fix it in PR #678.

[GitHub] wu-sheng opened a new pull request #86: Update readme.

2017-12-14 Thread GitBox
wu-sheng opened a new pull request #86: Update readme. URL: https://github.com/apache/incubator-skywalking-ui/pull/86 @hanahmily Add description about what you are doing, now, and put you as core team representative. This is

[GitHub] lytscu commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

2017-12-14 Thread GitBox
lytscu commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588 URL: https://github.com/apache/incubator-skywalking/pull/670#issuecomment-351890764 #588 This is an automated message

[GitHub] wu-sheng closed pull request #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
wu-sheng closed pull request #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] wu-sheng commented on issue #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
wu-sheng commented on issue #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681#issuecomment-351915740 @apache/skywalking-committers Please be adviced, everyone, I accept @hanahmily 's suggestion. I will adjust the version more common, and use

[GitHub] wu-sheng closed pull request #678: [Collector] Fix issue that collector start failed in the Windows environment

2017-12-14 Thread GitBox
wu-sheng closed pull request #678: [Collector] Fix issue that collector start failed in the Windows environment URL: https://github.com/apache/incubator-skywalking/pull/678 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] clevertension commented on issue #659: [Agent] Spring Bean Plugin

2017-12-14 Thread GitBox
clevertension commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-351890035 ok, i will work on it This is an automated message from the Apache Git

[GitHub] ascrutae commented on issue #680: oracle agant exception

2017-12-14 Thread GitBox
ascrutae commented on issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680#issuecomment-351891917 Could you show me the demo, and which version of agent are you used? This is an

[GitHub] wu-sheng closed pull request #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
wu-sheng closed pull request #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] coveralls commented on issue #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
coveralls commented on issue #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679#issuecomment-351892058 [![Coverage Status](https://coveralls.io/builds/14667767/badge)](https://coveralls.io/builds/14667767) Changes Unknown

[GitHub] coveralls commented on issue #681: Update version to 5.0.0-alpha

2017-12-14 Thread GitBox
coveralls commented on issue #681: Update version to 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/pull/681#issuecomment-351908461 [![Coverage Status](https://coveralls.io/builds/14668691/badge)](https://coveralls.io/builds/14668691) Coverage remained the same

[GitHub] flydish2017 commented on issue #680: oracle agant exception

2017-12-14 Thread GitBox
flydish2017 commented on issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680#issuecomment-351892988 oracle? 11.2.0.4.0 This is an automated message from the Apache Git Service.

[GitHub] wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351905741 @myoss Yes, it does. #676 has been merged. This issue will be solved in 5.0.0-alpha

[GitHub] myoss closed issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss closed issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 This is an automated message from the Apache Git Service. To respond to

[GitHub] hanahmily closed pull request #86: Update readme.

2017-12-14 Thread GitBox
hanahmily closed pull request #86: Update readme. URL: https://github.com/apache/incubator-skywalking-ui/pull/86 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0-2018-preview

[GitHub] myoss opened a new issue #682: [Agent] InstMethodsInter throw NullPointerException

2017-12-14 Thread GitBox
myoss opened a new issue #682: [Agent] InstMethodsInter throw NullPointerException URL: https://github.com/apache/incubator-skywalking/issues/682 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 3.2.6 # question

[GitHub] coveralls commented on issue #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
coveralls commented on issue #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679#issuecomment-351889205 [![Coverage Status](https://coveralls.io/builds/14667598/badge)](https://coveralls.io/builds/14667598) Changes Unknown

[GitHub] flydish2017 opened a new issue #680: oracle agant exception

2017-12-14 Thread GitBox
flydish2017 opened a new issue #680: oracle agant exception URL: https://github.com/apache/incubator-skywalking/issues/680 ### Cause: java.sql.SQLException: An SQLException was provoked by the following failure: java.lang.ClassCastException:

[GitHub] wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work

2017-12-14 Thread GitBox
wu-sheng commented on issue #676: [Agent] Fix issue that OkHttpClient plugin doesn't work URL: https://github.com/apache/incubator-skywalking/pull/676#issuecomment-351721575 > The matcher match the first argument is enough. I just check the RealCall class in version 3.x. This class have

[GitHub] coveralls commented on issue #679: Update readme and remove the annoucement

2017-12-14 Thread GitBox
coveralls commented on issue #679: Update readme and remove the annoucement URL: https://github.com/apache/incubator-skywalking/pull/679#issuecomment-351878476 [![Coverage Status](https://coveralls.io/builds/14666914/badge)](https://coveralls.io/builds/14666914) Changes Unknown