[GitHub] coveralls commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-08 Thread GitBox
coveralls commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356176479 [![Coverage

[GitHub] wu-sheng opened a new pull request #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-08 Thread GitBox
wu-sheng opened a new pull request #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732 This is an automated message from the Apache Git

[GitHub] wu-sheng commented on issue #437: [Agent] ServiceComb Plugin

2018-01-08 Thread GitBox
wu-sheng commented on issue #437: [Agent] ServiceComb Plugin URL: https://github.com/apache/incubator-skywalking/issues/437#issuecomment-355957987 @lytscu Since the AsyncHttpClient plugin almost finished, please focus on building the integration with ServiceComb (Huawei open source

[GitHub] wu-sheng commented on issue #731: ?????????????

2018-01-08 Thread GitBox
wu-sheng commented on issue #731: ? URL: https://github.com/apache/incubator-skywalking/issues/731#issuecomment-355957257 Hi @xjr100419 , You can see how we ignore the url by suffix, so there are too options: 1. Using the current mechanism, put the whole URLs(e.g. hear beat

[GitHub] coveralls commented on issue #730: Support collector service instrumentation

2018-01-08 Thread GitBox
coveralls commented on issue #730: Support collector service instrumentation URL: https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355922069 [![Coverage Status](https://coveralls.io/builds/14944621/badge)](https://coveralls.io/builds/14944621) Coverage

[GitHub] xjr100419 opened a new issue #731: ?????????????

2018-01-08 Thread GitBox
xjr100419 opened a new issue #731: ? URL: https://github.com/apache/incubator-skywalking/issues/731 ### What version of sky-walking are you using? v3.2.6 ### What version of your OS? window ### What version of your JRE? java8 ?? agent.config