[GitHub] 18474475 commented on issue #731: ?????????????

2018-01-09 Thread GitBox
18474475 commented on issue #731: ? URL: https://github.com/apache/incubator-skywalking/issues/731#issuecomment-356521876 many guys may need "pattern ignore" config to ignore /eureka/apps/delta /health /info ... just like me and xjr100419.

[GitHub] 18474475 commented on issue #731: ?????????????

2018-01-09 Thread GitBox
18474475 commented on issue #731: ? URL: https://github.com/apache/incubator-skywalking/issues/731#issuecomment-356521876 many guys may need "pattern ignore" config to ignore /eureka/apps/delta /health /info ...

[GitHub] wu-sheng commented on issue #730: Support collector service instrumentation

2018-01-09 Thread GitBox
wu-sheng commented on issue #730: Support collector service instrumentation URL: https://github.com/apache/incubator-skywalking/pull/730#issuecomment-356488197 * Output with metric ```

[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-09 Thread GitBox
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356307637 If we are using `[Node!]!` as you expected, a lot of parts in protocol need to be changed by

[GitHub] wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin

2018-01-09 Thread GitBox
wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin URL: https://github.com/apache/incubator-skywalking/issues/735#issuecomment-356291663 Wait for @YunaiV 's pull request. This is an automated message

[GitHub] wu-sheng opened a new issue #735: Concurrency conflicts in Spring plugin

2018-01-09 Thread GitBox
wu-sheng opened a new issue #735: Concurrency conflicts in Spring plugin URL: https://github.com/apache/incubator-skywalking/issues/735 Report by @YunaiV . `EnhanceRequireObjectCache` 's two fields face the conflict. These two should be declared as ThreadLocal, and clear(`set(null)`)

[GitHub] coveralls commented on issue #734: Pyramid aggregate.

2018-01-09 Thread GitBox
coveralls commented on issue #734: Pyramid aggregate. URL: https://github.com/apache/incubator-skywalking/pull/734#issuecomment-356268055 [![Coverage Status](https://coveralls.io/builds/14964820/badge)](https://coveralls.io/builds/14964820) Coverage decreased (-0.08%) to

[GitHub] peng-yongsheng opened a new pull request #734: Pyramid aggregate.

2018-01-09 Thread GitBox
peng-yongsheng opened a new pull request #734: Pyramid aggregate. URL: https://github.com/apache/incubator-skywalking/pull/734 1. Metric pyramid aggregate with time bucket: minute -> hour -> day -> month 2. JVM metric pyramid aggregate with time bucket: second -> minute -> hour -> day

[GitHub] peng-yongsheng opened a new pull request #733: Pyramid aggr

2018-01-09 Thread GitBox
peng-yongsheng opened a new pull request #733: Pyramid aggr URL: https://github.com/apache/incubator-skywalking/pull/733 This is an automated message from the Apache Git Service. To respond to the message, please log on