[GitHub] 18474475 commented on issue #731: ?????????????
18474475 commented on issue #731: ? URL: https://github.com/apache/incubator-skywalking/issues/731#issuecomment-356521876 many guys may need "pattern ignore" config to ignore /eureka/apps/delta /health /info ... just like me and xjr100419. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 18474475 commented on issue #731: ?????????????
18474475 commented on issue #731: ? URL: https://github.com/apache/incubator-skywalking/issues/731#issuecomment-356521876 many guys may need "pattern ignore" config to ignore /eureka/apps/delta /health /info ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #730: Support collector service instrumentation
wu-sheng commented on issue #730: Support collector service instrumentation URL: https://github.com/apache/incubator-skywalking/pull/730#issuecomment-356488197 * Output with metric ``` ## # Collector Service Report # ## /segment/parse Avg=10380668 (nano), Success Rate=100%, Calls=14 /segment/parse/preBuild Avg=5139819 (nano), Success Rate=100%, Calls=14 /segment/parse/buildSegment Avg=25482 (nano), Success Rate=100%, Calls=14 /worker/async/consume/ApplicationMapping/ApplicationMapping Avg=7036928 (nano), Success Rate=100%, Calls=1 Rows per call = 1 /worker/async/consume/Segment/Segment Avg=358379 (nano), Success Rate=100%, Calls=316 Rows per call = 2 /worker/async/consume/ServiceEntry/ServiceEntry Avg=2938083 (nano), Success Rate=100%, Calls=1 Rows per call = 1 /worker/async/consume/ServiceReferenceMetric/ServiceReferenceMetric Avg=5497347 (nano), Success Rate=100%, Calls=1 Rows per call = 3 /worker/async/consume/ApplicationComponent/ApplicationComponent Avg=5471366 (nano), Success Rate=100%, Calls=1 Rows per call = 3 /worker/async/consume/GlobalTrace/GlobalTrace Avg=72356 (nano), Success Rate=100%, Calls=1 Rows per call = 2 /worker/async/consume/InstanceMapping/InstanceMapping Avg=3810820 (nano), Success Rate=100%, Calls=1 Rows per call = 1 ``` * Output in waiting ``` ## # Collector Service Report # ## /segment/parse Avg=N/A /segment/parse/preBuild Avg=N/A /segment/parse/buildSegment Avg=N/A /worker/async/consume/ApplicationMapping/ApplicationMapping Avg=N/A /worker/async/consume/Segment/Segment Avg=N/A /worker/async/consume/ServiceEntry/ServiceEntry Avg=N/A /worker/async/consume/ServiceReferenceMetric/ServiceReferenceMetric Avg=N/A /worker/async/consume/ApplicationComponent/ApplicationComponent Avg=N/A /worker/async/consume/GlobalTrace/GlobalTrace Avg=N/A /worker/async/consume/InstanceMapping/InstanceMapping Avg=N/A ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356307637 If we are using `[Node!]!` as you expected, a lot of parts in protocol need to be changed by following the same style. I hope to catch up in next day. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin
wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin URL: https://github.com/apache/incubator-skywalking/issues/735#issuecomment-356291663 Wait for @YunaiV 's pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #735: Concurrency conflicts in Spring plugin
wu-sheng opened a new issue #735: Concurrency conflicts in Spring plugin
URL: https://github.com/apache/incubator-skywalking/issues/735
Report by @YunaiV . `EnhanceRequireObjectCache` 's two fields face the
conflict. These two should be declared as ThreadLocal, and clear(`set(null)`)
after `getHttpServletResponse`
Further more, this method should be removed.
```java
public HttpServletResponse getHttpResponse() {
return httpResponse;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #734: Pyramid aggregate.
coveralls commented on issue #734: Pyramid aggregate. URL: https://github.com/apache/incubator-skywalking/pull/734#issuecomment-356268055 [](https://coveralls.io/builds/14964820) Coverage decreased (-0.08%) to 22.266% when pulling **f461e1a991a2e1b48a2e412cefc4dea3ce8111f0 on peng-yongsheng:feature/data_refactor** into **af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #734: Pyramid aggregate.
peng-yongsheng opened a new pull request #734: Pyramid aggregate. URL: https://github.com/apache/incubator-skywalking/pull/734 1. Metric pyramid aggregate with time bucket: minute -> hour -> day -> month 2. JVM metric pyramid aggregate with time bucket: second -> minute -> hour -> day -> month This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] peng-yongsheng opened a new pull request #733: Pyramid aggr
peng-yongsheng opened a new pull request #733: Pyramid aggr URL: https://github.com/apache/incubator-skywalking/pull/733 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
