[GitHub] wu-sheng opened a new pull request #741: Protect the background processes.

2018-01-10 Thread GitBox
wu-sheng opened a new pull request #741: Protect the background processes. URL: https://github.com/apache/incubator-skywalking/pull/741 There is an important feature of `ScheduledExecutorService`. The timer could be suppressed with an exception in `run()`. ``` encounters an

[GitHub] ascrutae commented on issue #738: Concurrency conflicts in Spring plugin #735

2018-01-10 Thread GitBox
ascrutae commented on issue #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#issuecomment-356842920 I think the `NativeWebRequest` object should be remove too,

[GitHub] wu-sheng closed issue #740: maven error

2018-01-10 Thread GitBox
wu-sheng closed issue #740: maven error URL: https://github.com/apache/incubator-skywalking/issues/740 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] wu-sheng commented on issue #740: maven error

2018-01-10 Thread GitBox
wu-sheng commented on issue #740: maven error URL: https://github.com/apache/incubator-skywalking/issues/740#issuecomment-356841151 First of all, CI passed, means the compile status is health. Then we didn't expect you to compile a single module of the project. See

[GitHub] wolfelven opened a new issue #740: maven error

2018-01-10 Thread GitBox
wolfelven opened a new issue #740: maven error URL: https://github.com/apache/incubator-skywalking/issues/740 [ERROR] Failed to execute goal on project client-component: Could not resolve dependencies for project org.apache.skywalking:client-component:jar:5.0.0-alpha: Failure to find

[GitHub] lytscu commented on issue #437: [Agent] ServiceComb Plugin

2018-01-10 Thread GitBox
lytscu commented on issue #437: [Agent] ServiceComb Plugin URL: https://github.com/apache/incubator-skywalking/issues/437#issuecomment-356837774 Ok ,I will make contact with Teacher Jiang. This is an automated message from

[GitHub] wu-sheng closed issue #451: [Collector] Limit the amount of Elastic Search stored

2018-01-10 Thread GitBox
wu-sheng closed issue #451: [Collector] Limit the amount of Elastic Search stored URL: https://github.com/apache/incubator-skywalking/issues/451 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #450: [Collector] Provide event(including alarm) logs feature

2018-01-10 Thread GitBox
wu-sheng commented on issue #450: [Collector] Provide event(including alarm) logs feature URL: https://github.com/apache/incubator-skywalking/issues/450#issuecomment-356831047 Alerting based on response time and success rate will be provided in 5.0 . Almost codes are done.

[GitHub] wu-sheng closed issue #450: [Collector] Provide event(including alarm) logs feature

2018-01-10 Thread GitBox
wu-sheng closed issue #450: [Collector] Provide event(including alarm) logs feature URL: https://github.com/apache/incubator-skywalking/issues/450 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for metrics and traces, maybe alarms

2018-01-10 Thread GitBox
wu-sheng commented on issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for metrics and traces, maybe alarms URL: https://github.com/apache/incubator-skywalking/issues/390#issuecomment-356830889 Designed and provided in 5.0. Check

[GitHub] wu-sheng closed issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for metrics and traces, maybe alarms

2018-01-10 Thread GitBox
wu-sheng closed issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for metrics and traces, maybe alarms URL: https://github.com/apache/incubator-skywalking/issues/390 This is an automated message from the Apache

[GitHub] wu-sheng closed issue #496: webui???????????? ? ????

2018-01-10 Thread GitBox
wu-sheng closed issue #496: webui ? URL: https://github.com/apache/incubator-skywalking/issues/496 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng closed issue #500: webui???????????? ? ????

2018-01-10 Thread GitBox
wu-sheng closed issue #500: webui ? URL: https://github.com/apache/incubator-skywalking/issues/500 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #500: webui???????????? ? ????

2018-01-10 Thread GitBox
wu-sheng commented on issue #500: webui ? URL: https://github.com/apache/incubator-skywalking/issues/500#issuecomment-356830533 Alarm features will be provided in 5.0 . Multi-tenant is not an expected feature in our milestone.

[GitHub] wu-sheng commented on issue #496: webui???????????? ? ????

2018-01-10 Thread GitBox
wu-sheng commented on issue #496: webui ? URL: https://github.com/apache/incubator-skywalking/issues/496#issuecomment-356830520 Alarm features will be provided in 5.0 . Multi-tenant is not an expected feature in our milestone.

[GitHub] wu-sheng commented on issue #568: [Collector] ????es??????es????????????????????????????????????

2018-01-10 Thread GitBox
wu-sheng commented on issue #568: [Collector] es??es URL: https://github.com/apache/incubator-skywalking/issues/568#issuecomment-356830170 Closing this. Already supported. This is

[GitHub] wu-sheng commented on issue #589: [Agent] Provide plugin for Apache Httpcomponent httpclient 4.4 and 4.5

2018-01-10 Thread GitBox
wu-sheng commented on issue #589: [Agent] Provide plugin for Apache Httpcomponent httpclient 4.4 and 4.5 URL: https://github.com/apache/incubator-skywalking/issues/589#issuecomment-356830003 Based on [test

[GitHub] wu-sheng closed issue #584: Add instrument module in collector

2018-01-10 Thread GitBox
wu-sheng closed issue #584: Add instrument module in collector URL: https://github.com/apache/incubator-skywalking/issues/584 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #584: Add instrument module in collector

2018-01-10 Thread GitBox
wu-sheng commented on issue #584: Add instrument module in collector URL: https://github.com/apache/incubator-skywalking/issues/584#issuecomment-356828288 I spend a week to provide the first instrument in #730 . This is an

[GitHub] wu-sheng commented on issue #660: [UI] Feature of dashboard

2018-01-10 Thread GitBox
wu-sheng commented on issue #660: [UI] Feature of dashboard URL: https://github.com/apache/incubator-skywalking/issues/660#issuecomment-356828091 I am closing this. The UI features are developing, and most are finished. Look forward @hanahmily to share us the exited 5.0 UI.

[GitHub] wu-sheng closed issue #660: [UI] Feature of dashboard

2018-01-10 Thread GitBox
wu-sheng closed issue #660: [UI] Feature of dashboard URL: https://github.com/apache/incubator-skywalking/issues/660 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] coveralls commented on issue #739: [Agent] Support the version 9.4.x of postgresql jdbc driver

2018-01-10 Thread GitBox
coveralls commented on issue #739: [Agent] Support the version 9.4.x of postgresql jdbc driver URL: https://github.com/apache/incubator-skywalking/pull/739#issuecomment-356818949 [![Coverage Status](https://coveralls.io/builds/14996693/badge)](https://coveralls.io/builds/14996693)

[GitHub] coveralls commented on issue #739: [Agent] Support the version 9.4.x of postgresql jdbc driver

2018-01-10 Thread GitBox
coveralls commented on issue #739: [Agent] Support the version 9.4.x of postgresql jdbc driver URL: https://github.com/apache/incubator-skywalking/pull/739#issuecomment-356818441 [![Coverage Status](https://coveralls.io/builds/14996669/badge)](https://coveralls.io/builds/14996669)

[GitHub] ascrutae opened a new pull request #739: [Agent] Support the version 9.4.x of postgresql jdbc driver

2018-01-10 Thread GitBox
ascrutae opened a new pull request #739: [Agent] Support the version 9.4.x of postgresql jdbc driver URL: https://github.com/apache/incubator-skywalking/pull/739 This is an automated message from the Apache Git Service. To

[GitHub] ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-10 Thread GitBox
ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405 ## File path: pom.xml ## @@

[GitHub] ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-10 Thread GitBox
ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405 ## File path: pom.xml ## @@

[GitHub] coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735

2018-01-10 Thread GitBox
coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#issuecomment-356800821 [![Coverage Status](https://coveralls.io/builds/14995747/badge)](https://coveralls.io/builds/14995747) Coverage

[GitHub] coveralls commented on issue #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-10 Thread GitBox
coveralls commented on issue #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737#issuecomment-356776742 [![Coverage

[GitHub] michaelsembwever opened a new pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-10 Thread GitBox
michaelsembwever opened a new pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737 With this approach the user can onetime manually download them,

[GitHub] wu-sheng closed pull request #736: Update README.md

2018-01-10 Thread GitBox
wu-sheng closed pull request #736: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/736 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] coveralls commented on issue #736: Update README.md

2018-01-10 Thread GitBox
coveralls commented on issue #736: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/736#issuecomment-356547910 [![Coverage Status](https://coveralls.io/builds/14980639/badge)](https://coveralls.io/builds/14980639) Coverage remained the same at 22.266%

[GitHub] coveralls commented on issue #736: Update README.md

2018-01-10 Thread GitBox
coveralls commented on issue #736: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/736#issuecomment-356548005 [![Coverage Status](https://coveralls.io/builds/14980646/badge)](https://coveralls.io/builds/14980646) Coverage remained the same at 22.266%

[GitHub] wu-sheng opened a new pull request #736: Update README.md

2018-01-10 Thread GitBox
wu-sheng opened a new pull request #736: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/736 The coverage didn't need to show. Because we are using many integration test tech, rather than test cases.

[GitHub] coveralls commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-10 Thread GitBox
coveralls commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356539135 [![Coverage

[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-10 Thread GitBox
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356536368 New protocol has been provided: 1. Add set/get `DataTTLConfigs` and set/get `AlarmThreshold`