[GitHub] coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735

2018-01-11 Thread GitBox
coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#issuecomment-357167473 [![Coverage Status](https://coveralls.io/builds/15017683/badge)](https://coveralls.io/builds/15017683) Coverage

[GitHub] wu-sheng commented on issue #746: How to read span tag in elasticsearch?

2018-01-11 Thread GitBox
wu-sheng commented on issue #746: How to read span tag in elasticsearch? URL: https://github.com/apache/incubator-skywalking/issues/746#issuecomment-357166530 This is String based on BASE64 encode, because Elastic Search only accepts bytes in this format. And the bytes are in Protobuf

[GitHub] wu-sheng commented on issue #744: ??mongoDb??????

2018-01-11 Thread GitBox
wu-sheng commented on issue #744: ??mongoDb?? URL: https://github.com/apache/incubator-skywalking/issues/744#issuecomment-357130273 This is a requirement. We haven't supported yet. This is an automated message from the

[GitHub] lijialing888 opened a new issue #745: How to find apm-toolkit-trace jar file?

2018-01-11 Thread GitBox
lijialing888 opened a new issue #745: How to find apm-toolkit-trace jar file? URL: https://github.com/apache/incubator-skywalking/issues/745 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 3.2.6 ### What version of

[GitHub] 906827215 opened a new issue #744: ??mongoDb??????

2018-01-11 Thread GitBox
906827215 opened a new issue #744: ??mongoDb?? URL: https://github.com/apache/incubator-skywalking/issues/744 MongoDb ???3.2.2?? 2.x.x + 3.x.x+ ? ![qq

[GitHub] coveralls commented on issue #732: Adjust ui-query protocol

2018-01-11 Thread GitBox
coveralls commented on issue #732: Adjust ui-query protocol URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-357121708 [![Coverage Status](https://coveralls.io/builds/15015094/badge)](https://coveralls.io/builds/15015094) Coverage decreased (-0.3%) to

[GitHub] wu-sheng commented on issue #742: compile FAILURE

2018-01-11 Thread GitBox
wu-sheng commented on issue #742: compile FAILURE URL: https://github.com/apache/incubator-skywalking/issues/742#issuecomment-357116082 First, I am confused about your error of maven. The `mvn package` is checked everytime when codes merged. Check the online CI from here:

[GitHub] michaelsembwever closed pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-11 Thread GitBox
michaelsembwever closed pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737 This is a PR merged from a forked repository. As GitHub hides the original diff

[GitHub] wu-sheng commented on issue #738: Concurrency conflicts in Spring plugin #735

2018-01-11 Thread GitBox
wu-sheng commented on issue #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#issuecomment-357103399 @YunaiV Waiting for the automatic integration test report, before merge. We are building the formal plugin check system.

[GitHub] michaelsembwever commented on issue #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-11 Thread GitBox
michaelsembwever commented on issue #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737#issuecomment-357100290 > BTW we need to adjust /docs/Supported-list.md document:

[GitHub] michaelsembwever commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

2018-01-11 Thread GitBox
michaelsembwever commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737#discussion_r161109028 ## File path:

[GitHub] wu-sheng closed pull request #741: Protect the background processes.

2018-01-11 Thread GitBox
wu-sheng closed pull request #741: Protect the background processes. URL: https://github.com/apache/incubator-skywalking/pull/741 This is an automated message from the Apache Git Service. To respond to the message, please

MicroProfile OpenTracing Support?

2018-01-11 Thread John D. Ament
Hi there, I was wondering, are there any plans for Apache SkyWalking (incubating) to add support for MicroProfile OpenTracing ( https://github.com/eclipse/microprofile-opentracing )? John

[GitHub] coveralls commented on issue #741: Protect the background processes.

2018-01-11 Thread GitBox
coveralls commented on issue #741: Protect the background processes. URL: https://github.com/apache/incubator-skywalking/pull/741#issuecomment-356957667 [![Coverage Status](https://coveralls.io/builds/15004575/badge)](https://coveralls.io/builds/15004575) Coverage decreased

[GitHub] wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

2018-01-11 Thread GitBox
wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #732: Adjust ui-query protocol

2018-01-11 Thread GitBox
coveralls commented on issue #732: Adjust ui-query protocol URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356901818 [![Coverage Status](https://coveralls.io/builds/15001040/badge)](https://coveralls.io/builds/15001040) Coverage decreased (-0.08%) to

[GitHub] ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735

2018-01-11 Thread GitBox
ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923141 ## File path:

[GitHub] ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735

2018-01-11 Thread GitBox
ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923152 ## File path:

[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

2018-01-11 Thread GitBox
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356879914 [![Coverage Status](https://coveralls.io/builds/14999785/badge)](https://coveralls.io/builds/14999785)

[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

2018-01-11 Thread GitBox
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356868493 [![Coverage Status](https://coveralls.io/builds/14999179/badge)](https://coveralls.io/builds/14999179)

[GitHub] ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

2018-01-11 Thread GitBox
ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356865310 Done! This is an automated message from the

[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

2018-01-11 Thread GitBox
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356863298 [![Coverage Status](https://coveralls.io/builds/14998949/badge)](https://coveralls.io/builds/14998949)

[GitHub] 237121592 opened a new issue #742: compile FAILURE

2018-01-11 Thread GitBox
237121592 opened a new issue #742: compile FAILURE URL: https://github.com/apache/incubator-skywalking/issues/742 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0.0-alpha ### What version of your OS? windows7

[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-11 Thread GitBox
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356858565 Make the user node as an extend of Node, rather then an attribute of ApplicationNode.