[GitHub] coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735
coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#issuecomment-357167473 [](https://coveralls.io/builds/15017683) Coverage remained the same at 22.003% when pulling **9453c8c403cd7a3578c4d6a0af6026dc6e742cab on YunaiV:master-5.0** into **195cc2a6a1c9500bc46abaf404df6c3b931eeab1 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #746: How to read span tag in elasticsearch?
wu-sheng commented on issue #746: How to read span tag in elasticsearch? URL: https://github.com/apache/incubator-skywalking/issues/746#issuecomment-357166530 This is String based on BASE64 encode, because Elastic Search only accepts bytes in this format. And the bytes are in Protobuf format, after you do the un-BASE64. SkyWalking segment format is here: https://github.com/apache/incubator-skywalking/blob/master/apm-protocol/apm-network/src/main/proto/TraceSegmentService.proto This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #744: ??mongoDb??????
wu-sheng commented on issue #744: ??mongoDb?? URL: https://github.com/apache/incubator-skywalking/issues/744#issuecomment-357130273 This is a requirement. We haven't supported yet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lijialing888 opened a new issue #745: How to find apm-toolkit-trace jar file?
lijialing888 opened a new issue #745: How to find apm-toolkit-trace jar file?
URL: https://github.com/apache/incubator-skywalking/issues/745
Please answer these questions before submitting your issue.
### What version of sky-walking are you using?
3.2.6
### What version of your OS?
any
### What version of your JRE?
8.0
### What company or project?
Top 500 company
### What did you do?
I want use opentracing API, but how to download the adapter jar file?
I could not find it in maven repository.
```xml
org.apache.skywalking
apm-toolkit-trace
${skywalking.version}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] 906827215 opened a new issue #744: ??mongoDb??????
906827215 opened a new issue #744: ??mongoDb?? URL: https://github.com/apache/incubator-skywalking/issues/744 MongoDb ???3.2.2?? 2.x.x + 3.x.x+ ?  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #732: Adjust ui-query protocol
coveralls commented on issue #732: Adjust ui-query protocol URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-357121708 [](https://coveralls.io/builds/15015094) Coverage decreased (-0.3%) to 22.003% when pulling **225903a92a5590014a353206d9b2cb49c9a66c4d on fix/graphql/node-nullable** into **af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #742: compile FAILURE
wu-sheng commented on issue #742: compile FAILURE URL: https://github.com/apache/incubator-skywalking/issues/742#issuecomment-357116082 First, I am confused about your error of maven. The `mvn package` is checked everytime when codes merged. Check the online CI from here: https://travis-ci.org/apache/incubator-skywalking In this morning, because of other reason, we remove the ci-dependencies files for following ASF policy. You can retry compiling. At last, unless you are a professional APM guy and are familiar with SkyWalking project. Using the master codes could be difficult. If you only want to give a try, please use the latest release for now. 5.0 will release in Feb. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michaelsembwever closed pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
michaelsembwever closed pull request #737: Remove OJDBC and resin artifacts
from ci-dependencies driectory as they as not Apache license compatible
URL: https://github.com/apache/incubator-skywalking/pull/737
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/apm-sniffer/apm-sdk-plugin/pom.xml
b/apm-sniffer/apm-sdk-plugin/pom.xml
index 3a26042c5..0bba88f18 100644
--- a/apm-sniffer/apm-sdk-plugin/pom.xml
+++ b/apm-sniffer/apm-sdk-plugin/pom.xml
@@ -38,8 +38,6 @@
mongodb-3.x-plugin
feign-default-http-9.x-plugin
okhttp-3.x-plugin
-resin-3.x-plugin
-resin-4.x-plugin
spring-plugins
struts2-2.x-plugin
nutz-plugins
@@ -51,7 +49,6 @@
mysql-5.x-plugin
h2-1.x-plugin
postgresql-8.x-plugin
-oracle-10.x-plugin
rocketMQ-4.x-plugin
elastic-job-2.x-plugin
mongodb-2.x-plugin
@@ -202,4 +199,43 @@
+
+
+
+
+include-ojdbc
+
+
+
${basedir}/../../ci-dependencies/ojdbc14-10.2.0.4.0.jar
+
+
+
+oracle-10.x-plugin
+
+
+
+
+include-resin-3
+
+
+
${basedir}/../../ci-dependencies/resin-3.0.9.jar
+
+
+
+resin-3.x-plugin
+
+
+
+
+include-resin-4
+
+
+
${basedir}/../../ci-dependencies/resin-4.0.41.jar
+
+
+
+resin-4.x-plugin
+
+
+
diff --git a/ci-dependencies/ojdbc14-10.2.0.4.0.jar
b/ci-dependencies/ojdbc14-10.2.0.4.0.jar
deleted file mode 100644
index f41cf1ae9..0
Binary files a/ci-dependencies/ojdbc14-10.2.0.4.0.jar and /dev/null differ
diff --git a/ci-dependencies/resin-4.0.41.jar b/ci-dependencies/resin-4.0.41.jar
deleted file mode 100644
index 9e04f4ce7..0
Binary files a/ci-dependencies/resin-4.0.41.jar and /dev/null differ
diff --git a/docs/Supported-list.md b/docs/Supported-list.md
index 54b5744dc..c4f84c5a4 100644
--- a/docs/Supported-list.md
+++ b/docs/Supported-list.md
@@ -5,8 +5,8 @@
* Spring MVC 3.x, 4.x with servlet 3.x
* [Nutz Web Framework](https://github.com/nutzam/nutz) 1.x
* [Struts2 MVC](http://struts.apache.org/) 2.3.x -> 2.5.x
- * [Resin](http://www.caucho.com/resin-4.0/) 3
- * [Resin](http://www.caucho.com/resin-4.0/) 4
+ * [Resin](http://www.caucho.com/resin-4.0/) 3 (Optional?)
+ * [Resin](http://www.caucho.com/resin-4.0/) 4 (Optional?)
* [Jetty Server](http://www.eclipse.org/jetty/) 9
* HTTP Client
* [Feign](https://github.com/OpenFeign/feign) 9.x
@@ -17,7 +17,7 @@
* [Jetty Client](http://www.eclipse.org/jetty/) 9
* JDBC
* Mysql Driver 5.x, 6.x
- * Oracle Driver
+ * Oracle Driver (Optional?)
* H2 Driver
* [Sharding-JDBC](https://github.com/shardingjdbc/sharding-jdbc) 1.5.x
* PostgreSQL Driver 8.x, 9.x, 42.x
@@ -44,3 +44,5 @@
* OpenTracing community supported
* Motan
* Hprose-java
+
+?Required dependencies for these components must be first manually downloaded
before being built, due to license incompatibilities. For this reason these
components are not by default included in the SkyWalking releases.
\ No newline at end of file
diff --git a/docs/en/How-to-build.md b/docs/en/How-to-build.md
index b21e504f8..c6ea808e8 100644
--- a/docs/en/How-to-build.md
+++ b/docs/en/How-to-build.md
@@ -11,4 +11,12 @@ This document helps people to compile and build the project
in your maven and ID
1. Run `mvn compile -Dmaven.test.skip=true` to compile project and generate
source codes. Because we use gRPC and protobuf.
1. Set **Generated Source Codes** folders.
* `grpc-java` and `java` folders in
**apm-protocol/apm-network/target/generated-sources/protobuf**
-* `grpc-java` and `java` folders in
**apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/protobuf**
\ No newline at end of file
+* `grpc-java` and `java` folders in
**apm-collector/apm-collector-remote/apm-remote-grpc-provider/target/protobuf**
+
+## Building Resin-3, Resin-4, and OJDBC sdk plugins
+Due to license incompatibilities/restrictions these plugins under
`apm-sniffer/apm-sdk-plugin/` are not built by default.
+Download them manually into the `ci-dependencies/` directory and the plugins
will be included in the maven reactor and built.
+The names of the artifacts downloaded and placed in the `ci-dependencies/`
directory must be exact:
+* resin-3.0.9.jar
+* resin-4.0.41.jar
+* ojdbc14-10.2.0.4.0.jar
[GitHub] wu-sheng commented on issue #738: Concurrency conflicts in Spring plugin #735
wu-sheng commented on issue #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#issuecomment-357103399 @YunaiV Waiting for the automatic integration test report, before merge. We are building the formal plugin check system. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michaelsembwever commented on issue #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
michaelsembwever commented on issue #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible URL: https://github.com/apache/incubator-skywalking/pull/737#issuecomment-357100290 > BTW we need to adjust /docs/Supported-list.md document: > > Add Optional at Resin and Oracle driver plugins. Notice people these plugins are not in official releases, based on ASF license policy. > Link to Build Guide. Help people to build the plugin by theirself. done. let me know when i'm free to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michaelsembwever commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
michaelsembwever commented on a change in pull request #737: Remove OJDBC and
resin artifacts from ci-dependencies driectory as they as not Apache license
compatible
URL:
https://github.com/apache/incubator-skywalking/pull/737#discussion_r161109028
##
File path: apm-sniffer/apm-sdk-plugin/pom.xml
##
@@ -202,4 +200,31 @@
+
+
+
+
+include-ojdbc
+
+
+
${basedir}/../../ci-dependencies/ojdbc14-10.2.0.4.0.jar
+
+
+
+oracle-10.x-plugin
+
+
+
+
+include-resin
Review comment:
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wu-sheng closed pull request #741: Protect the background processes.
wu-sheng closed pull request #741: Protect the background processes. URL: https://github.com/apache/incubator-skywalking/pull/741 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
MicroProfile OpenTracing Support?
Hi there, I was wondering, are there any plans for Apache SkyWalking (incubating) to add support for MicroProfile OpenTracing ( https://github.com/eclipse/microprofile-opentracing )? John
[GitHub] coveralls commented on issue #741: Protect the background processes.
coveralls commented on issue #741: Protect the background processes. URL: https://github.com/apache/incubator-skywalking/pull/741#issuecomment-356957667 [](https://coveralls.io/builds/15004575) Coverage decreased (-0.01%) to 22.252% when pulling **6c11a8404b0a65d20e6642e9dbd42a0b9f8198e9 on fix/ScheduledFuture-failsafe** into **2713b5fd3b3f6705ba8428b0540d02f85efc702d on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver
wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of
postgresql driver
URL: https://github.com/apache/incubator-skywalking/pull/743
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/MultiClassNameMatch.java
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/MultiClassNameMatch.java
similarity index 91%
rename from
apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/MultiClassNameMatch.java
rename to
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/MultiClassNameMatch.java
index 66b2e8840..6453facdf 100644
---
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/MultiClassNameMatch.java
+++
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/MultiClassNameMatch.java
@@ -17,14 +17,12 @@
*/
-package org.apache.skywalking.apm.plugin.jdbc.mysql.define;
+package org.apache.skywalking.apm.agent.core.plugin.match;
import java.util.Arrays;
import java.util.List;
import net.bytebuddy.description.type.TypeDescription;
import net.bytebuddy.matcher.ElementMatcher;
-import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
-import org.apache.skywalking.apm.agent.core.plugin.match.IndirectMatch;
import static net.bytebuddy.matcher.ElementMatchers.named;
diff --git
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
index e8605a35d..4afeb7f0c 100644
---
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
+++
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
@@ -27,7 +27,7 @@
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
import static net.bytebuddy.matcher.ElementMatchers.named;
-import static
org.apache.skywalking.apm.plugin.jdbc.mysql.define.MultiClassNameMatch.byMultiClassMatch;
+import static
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
/**
* {@link CallableInstrumentation} define that the mysql-2.x plugin intercepts
the following methods in the {@link
diff --git
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
index 27b38e174..f17d3da04 100644
---
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
+++
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
@@ -22,7 +22,7 @@
import
org.apache.skywalking.apm.plugin.jdbc.define.AbstractDriverInstrumentation;
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
-import static
org.apache.skywalking.apm.plugin.jdbc.mysql.define.MultiClassNameMatch.byMultiClassMatch;
+import static
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
/**
* {@link DriverInstrumentation} presents that skywalking intercepts {@link
com.mysql.jdbc.Driver}.
diff --git
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
index 512b0c8ee..6c4860176 100644
---
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
+++
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
@@ -21,7 +21,7 @@
import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
-import static
org.apache.skywalking.apm.plugin.jdbc.mysql.define.MultiClassNameMatch.byMultiClassMatch;
+import static
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
/**
* {@link
[GitHub] coveralls commented on issue #732: Adjust ui-query protocol
coveralls commented on issue #732: Adjust ui-query protocol URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356901818 [](https://coveralls.io/builds/15001040) Coverage decreased (-0.08%) to 22.266% when pulling **eaef6f106c45d362bf63ca3fb2712da915085d4b on fix/graphql/node-nullable** into **af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735
ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735 URL: https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923141 ## File path: apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInteceptor.java ## @@ -80,6 +81,8 @@ public Object afterMethod(EnhancedInstance objInst, Method method, Object[] allA Tags.STATUS_CODE.set(span, Integer.toString(response.getStatus())); } ContextManager.stopSpan(); + + ((EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField()).setNativeWebRequest(null); Review comment: I think that you should add some comment so that anyone can understand it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735
ascrutae commented on a change in pull request #738: Concurrency conflicts in
Spring plugin #735
URL:
https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923152
##
File path:
apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/InvokeHandlerMethodInterceptor.java
##
@@ -37,11 +38,13 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
@Override
public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class[] argumentsTypes,
Object ret) throws Throwable {
+if (allArguments[2] instanceof EnhancedInstance) {
Review comment:
I think that you should add some comment so that anyone can understand it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356879914 [](https://coveralls.io/builds/14999785) Coverage remained the same at 22.266% when pulling **c6e593f6f40fee4501675893c7102361c2e64f39 on ascrutae:support/postgresql-jdbc** into **3613691105c3e0929ed812d9ddee8eb7cb5be6b5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356868493 [](https://coveralls.io/builds/14999179) Coverage remained the same at 22.266% when pulling **95cf5ac7a67cd9be9e11d23157ae626d9fcdee5e on ascrutae:support/postgresql-jdbc** into **3613691105c3e0929ed812d9ddee8eb7cb5be6b5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver
ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356865310 Done! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver URL: https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356863298 [](https://coveralls.io/builds/14998949) Coverage remained the same at 22.266% when pulling **97b577864f3145046b791ab41feeba009a22eab3 on ascrutae:support/postgresql-jdbc** into **3613691105c3e0929ed812d9ddee8eb7cb5be6b5 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 237121592 opened a new issue #742: compile FAILURE
237121592 opened a new issue #742: compile FAILURE URL: https://github.com/apache/incubator-skywalking/issues/742 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0.0-alpha ### What version of your OS? windows7 ### What version of your JRE? jre1.8.0_144 ### What company or project? incubator-skywalking ### What did you do? If possible, provide a way for reproducing the error. e.g. demo application, component version. I cloned the incubator-skywalking project on GitHub, but when I compile, IntelliJ IDEA Maven plug-in executes MVN compile -Dmaven.test.skip=true. There will be an exception as follows "C:\Program Files (x86)\Java\jdk1.8.0_144\bin\java" -Dmaven.multiModuleProjectDirectory=D:\incubator-skywalking -Dmaven.home=E:\apache-maven-3.3.9 -Dclassworlds.conf=E:\apache-maven-3.3.9\bin\m2.conf "-javaagent:E:\Program Files\JetBrains\IntelliJ IDEA 2017.2.4\lib\idea_rt.jar=35263:E:\Program Files\JetBrains\IntelliJ IDEA 2017.2.4\bin" -Dfile.encoding=UTF-8 -classpath E:\apache-maven-3.3.9\boot\plexus-classworlds-2.5.2.jar org.codehaus.classworlds.Launcher -Didea.version=2017.2.4 compile -Dmaven.test.skip=true [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-util:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-datacarrier:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-commons:pom:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-agent:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-agent-core:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-dubbo-plugin:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-jdbc-commons:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-deploy-plugin is missing. @ org.apache.skywalking:apm-jdbc-commons:[unknown-version], D:\incubator-skywalking\apm-sniffer\apm-sdk-plugin\jdbc-commons\pom.xml, line 49, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-httpClient-4.x-plugin:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin com.spotify:docker-maven-plugin @ org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 287, column 21 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.skywalking:apm-jedis-2.x-plugin:jar:5.0.0-alpha [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin
[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356858565 Make the user node as an extend of Node, rather then an attribute of ApplicationNode. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
