[GitHub] wu-sheng commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final)

2018-02-06 Thread GitBox
wu-sheng commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final) URL: https://github.com/apache/incubator-skywalking/pull/796#issuecomment-363682205 @carlvine500 Thanks for your continuous contributions. @ascrutae Please review the codes first, then gu

[GitHub] coveralls commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final)

2018-02-06 Thread GitBox
coveralls commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final) URL: https://github.com/apache/incubator-skywalking/pull/796#issuecomment-363673676 [![Coverage Status](https://coveralls.io/builds/15409023/badge)](https://coveralls.io/builds/15409023)

[GitHub] carlvine500 commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final)

2018-02-06 Thread GitBox
carlvine500 commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final) URL: https://github.com/apache/incubator-skywalking/pull/796#issuecomment-363676749 add trace image : producer & consumer https://user-images.githubusercontent.com/7055460/35902985-43903ae8

[GitHub] coveralls commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final)

2018-02-06 Thread GitBox
coveralls commented on issue #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final) URL: https://github.com/apache/incubator-skywalking/pull/796#issuecomment-363673676 [![Coverage Status](https://coveralls.io/builds/15408848/badge)](https://coveralls.io/builds/15408848)

[GitHub] carlvine500 opened a new pull request #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final)

2018-02-06 Thread GitBox
carlvine500 opened a new pull request #796: support rocketMQ-3.x-plugin (from 3.0.4-open to 3.4.6.Final) URL: https://github.com/apache/incubator-skywalking/pull/796 ### New feature or improvement - Describe the details and related test reports. add plugin from rocketMQ-3.x , because

[GitHub] wu-sheng closed pull request #794: bugfix:no data collected after application started

2018-02-06 Thread GitBox
wu-sheng closed pull request #794: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/794 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[GitHub] wu-sheng commented on issue #794: bugfix:no data collected after application started

2018-02-06 Thread GitBox
wu-sheng commented on issue #794: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/794#issuecomment-363655040 @carlvine500 Merged, thanks for you contribution. This

[GitHub] wu-sheng commented on issue #795: Support Jetty Server 8.1.3

2018-02-06 Thread GitBox
wu-sheng commented on issue #795: Support Jetty Server 8.1.3 URL: https://github.com/apache/incubator-skywalking/issues/795#issuecomment-363654975 @ascrutae This is a new requirement, please check your schedule, and reply about whether included in 5.0.0-alpha . Thanks. ---

[GitHub] Jessica-Liu opened a new issue #795: Support Jetty Server 8.1.3

2018-02-06 Thread GitBox
Jessica-Liu opened a new issue #795: Support Jetty Server 8.1.3 URL: https://github.com/apache/incubator-skywalking/issues/795 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [1 ] Requirement

[GitHub] coveralls commented on issue #794: bugfix:no data collected after application started

2018-02-06 Thread GitBox
coveralls commented on issue #794: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/794#issuecomment-363635211 [![Coverage Status](https://coveralls.io/builds/15407737/badge)](https://coveralls.io/builds/15407737) Cover

Podling Report Reminder - February 2018

2018-02-06 Thread johndament
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 21 February 2018, 10:30 am PDT. The report for your podling will for

[GitHub] carlvine500 commented on issue #794: bugfix:no data collected after application started

2018-02-06 Thread GitBox
carlvine500 commented on issue #794: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/794#issuecomment-363641150 @wu-sheng agree , thanks! This is an automated

[GitHub] wu-sheng commented on issue #794: bugfix:no data collected after application started

2018-02-06 Thread GitBox
wu-sheng commented on issue #794: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/794#issuecomment-363640522 @carlvine500 I understand your point, and this pr just can reduce the waiting time in the first N seconds, no guarantee,

[GitHub] coveralls commented on issue #794: bugfix:no data collected after application started

2018-02-06 Thread GitBox
coveralls commented on issue #794: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/794#issuecomment-363635211 [![Coverage Status](https://coveralls.io/builds/15407049/badge)](https://coveralls.io/builds/15407049) Cover

[GitHub] carlvine500 commented on issue #791: bugfix:no data collected after application started

2018-02-06 Thread GitBox
carlvine500 commented on issue #791: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/791#issuecomment-363633595 please skip this pr, I have created a new https://github.com/apache/incubator-skywalking/pull/794 --

[GitHub] carlvine500 closed pull request #791: bugfix:no data collected after application started

2018-02-06 Thread GitBox
carlvine500 closed pull request #791: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/791 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] carlvine500 opened a new pull request #794: bugfix:no data collected after application started 20+seconds

2018-02-06 Thread GitBox
carlvine500 opened a new pull request #794: bugfix:no data collected after application started 20+seconds URL: https://github.com/apache/incubator-skywalking/pull/794 ### Bug fix - Bug description. skywalking can't collect data after application started 20+ seconds .eg : ```

[GitHub] coveralls commented on issue #793: Modify GRPC support version

2018-02-06 Thread GitBox
coveralls commented on issue #793: Modify GRPC support version URL: https://github.com/apache/incubator-skywalking/pull/793#issuecomment-363455008 [![Coverage Status](https://coveralls.io/builds/15404735/badge)](https://coveralls.io/builds/15404735) Coverage remained the same at

[GitHub] wu-sheng closed pull request #793: Modify GRPC support version

2018-02-06 Thread GitBox
wu-sheng closed pull request #793: Modify GRPC support version URL: https://github.com/apache/incubator-skywalking/pull/793 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng closed pull request #792: [Agent] fix kafka plugin don't works

2018-02-06 Thread GitBox
wu-sheng closed pull request #792: [Agent] fix kafka plugin don't works URL: https://github.com/apache/incubator-skywalking/pull/792 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] coveralls commented on issue #793: Modify GRPC support version

2018-02-06 Thread GitBox
coveralls commented on issue #793: Modify GRPC support version URL: https://github.com/apache/incubator-skywalking/pull/793#issuecomment-363455008 [![Coverage Status](https://coveralls.io/builds/15395754/badge)](https://coveralls.io/builds/15395754) Coverage remained the same at

[GitHub] ascrutae opened a new pull request #793: Modify GRPC support version

2018-02-06 Thread GitBox
ascrutae opened a new pull request #793: Modify GRPC support version URL: https://github.com/apache/incubator-skywalking/pull/793 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improv

[GitHub] coveralls commented on issue #792: [Agent] fix kafka plugin don't works

2018-02-06 Thread GitBox
coveralls commented on issue #792: [Agent] fix kafka plugin don't works URL: https://github.com/apache/incubator-skywalking/pull/792#issuecomment-363411039 [![Coverage Status](https://coveralls.io/builds/15395482/badge)](https://coveralls.io/builds/15395482) Coverage remained th

[GitHub] ascrutae commented on issue #792: [Agent] fix kafka plugin don't works

2018-02-06 Thread GitBox
ascrutae commented on issue #792: [Agent] fix kafka plugin don't works URL: https://github.com/apache/incubator-skywalking/pull/792#issuecomment-363446653 Here is the test report: https://github.com/SkywalkingTest/agent-integration-test-report/blob/master/2018/2/ascrutae/testReport-master-

[GitHub] coveralls commented on issue #779: Proposal our ROADMAP.

2018-02-06 Thread GitBox
coveralls commented on issue #779: Proposal our ROADMAP. URL: https://github.com/apache/incubator-skywalking/pull/779#issuecomment-360965887 [![Coverage Status](https://coveralls.io/builds/15394153/badge)](https://coveralls.io/builds/15394153) Coverage remained the same at 21.84

[GitHub] coveralls commented on issue #779: Proposal our ROADMAP.

2018-02-06 Thread GitBox
coveralls commented on issue #779: Proposal our ROADMAP. URL: https://github.com/apache/incubator-skywalking/pull/779#issuecomment-360965887 [![Coverage Status](https://coveralls.io/builds/15394055/badge)](https://coveralls.io/builds/15394055) Coverage remained the same at 21.84

[GitHub] wu-sheng commented on issue #779: Proposal our ROADMAP.

2018-02-06 Thread GitBox
wu-sheng commented on issue #779: Proposal our ROADMAP. URL: https://github.com/apache/incubator-skywalking/pull/779#issuecomment-363424904 @peng-yongsheng @hanahmily I add multi-tenancy support in 5.0(highly recommend in 5.0.0-beta) and provide a release plan. ---

[GitHub] wu-sheng commented on issue #791: bugfix:no data collected after application started

2018-02-06 Thread GitBox
wu-sheng commented on issue #791: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/791#issuecomment-363419467 > I think you are right. This is a bug when using HashMap. I am glad that you have already confirmed this bug. @pe

[GitHub] peng-yongsheng commented on issue #791: bugfix:no data collected after application started

2018-02-06 Thread GitBox
peng-yongsheng commented on issue #791: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/791#issuecomment-363419228 I think you are right. This is a bug when using HashMap. -

[GitHub] wu-sheng closed issue #783: Grpc trace throw exception

2018-02-06 Thread GitBox
wu-sheng closed issue #783: Grpc trace throw exception URL: https://github.com/apache/incubator-skywalking/issues/783 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] wu-sheng commented on issue #783: Grpc trace throw exception

2018-02-06 Thread GitBox
wu-sheng commented on issue #783: Grpc trace throw exception URL: https://github.com/apache/incubator-skywalking/issues/783#issuecomment-363419175 Resolved by #790 , here is the test report: https://github.com/SkywalkingTest/agent-integration-test-report/blob/master/2018/2/ascrutae/testRep

[GitHub] wu-sheng closed pull request #790: [Agent] Fix grpc don't works in 1.8 version

2018-02-06 Thread GitBox
wu-sheng closed pull request #790: [Agent] Fix grpc don't works in 1.8 version URL: https://github.com/apache/incubator-skywalking/pull/790 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] wu-sheng commented on issue #791: bugfix:no data collected after application started

2018-02-06 Thread GitBox
wu-sheng commented on issue #791: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/791#issuecomment-363418717 @carlvine500 I think you should make sure of these things, before we start review: 1. The description should stay in

[GitHub] wu-sheng commented on issue #792: [Agent] fix kafka plugin don't works

2018-02-06 Thread GitBox
wu-sheng commented on issue #792: [Agent] fix kafka plugin don't works URL: https://github.com/apache/incubator-skywalking/pull/792#issuecomment-363417147 @ascrutae Your test cases fail. This is an automated message from the

[GitHub] coveralls commented on issue #792: [Agent] fix kafka plugin don't works

2018-02-06 Thread GitBox
coveralls commented on issue #792: [Agent] fix kafka plugin don't works URL: https://github.com/apache/incubator-skywalking/pull/792#issuecomment-363411039 [![Coverage Status](https://coveralls.io/builds/15393195/badge)](https://coveralls.io/builds/15393195) Coverage remained th

[GitHub] ascrutae opened a new pull request #792: [Agent] fix kafka plugin don't works

2018-02-06 Thread GitBox
ascrutae opened a new pull request #792: [Agent] fix kafka plugin don't works URL: https://github.com/apache/incubator-skywalking/pull/792 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [

Re: SkyWalking Podling Report - February 2018

2018-02-06 Thread Willem Jiang
It looks good, I just signed the report. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Feb 6, 2018 at 6:27 PM, mck wrote: > > > This email was sent by an automated system on behalf of the Ap

SkyWalking Podling Report - February 2018

2018-02-06 Thread mck
> This email was sent by an automated system on behalf of the Apache > Incubator PMC. It is an initial reminder to give you plenty of time to > prepare your quarterly board report. The second report for SkyWalking has been written up. https://wiki.apache.org/incubator/February2018 Luke and Will

[GitHub] coveralls commented on issue #790: [Agent] Fix grpc don't works in 1.8 version

2018-02-06 Thread GitBox
coveralls commented on issue #790: [Agent] Fix grpc don't works in 1.8 version URL: https://github.com/apache/incubator-skywalking/pull/790#issuecomment-363105326 [![Coverage Status](https://coveralls.io/builds/15390747/badge)](https://coveralls.io/builds/15390747) Coverage decr

[GitHub] ascrutae commented on issue #790: [Agent] Fix grpc don't works in 1.8 version

2018-02-06 Thread GitBox
ascrutae commented on issue #790: [Agent] Fix grpc don't works in 1.8 version URL: https://github.com/apache/incubator-skywalking/pull/790#issuecomment-363361858 Here is the test report: https://github.com/SkywalkingTest/agent-integration-test-report/blob/master/2018/2/ascrutae/testReport-

[GitHub] carlvine500 opened a new pull request #791: bugfix:no data collected after application started

2018-02-06 Thread GitBox
carlvine500 opened a new pull request #791: bugfix:no data collected after application started URL: https://github.com/apache/incubator-skywalking/pull/791 ??:skywalking 3.2.6-2017 bug??: ??main??,20+s. ??: 1.DiscoveryRestServiceClient.run() 0s,60s,