[GitHub] nidhibatra11 commented on issue #117: Can't see any traces in skywalking UI

[GitBox]

nidhibatra11 commented on issue #117: Can't see any traces in skywalking UI
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/117#issuecomment-369846421
 
 
   
https://github.com/apache/incubator-skywalking/blob/master/docs/en/Quick-start.md
   
   Wu sheng, I am following this quick start guide link to steer through.
   And the errors I posted earlier are what I see in skywalking-agent.
   If I go by what you saying to have test through the master code, I would
   not be able to discrete out the skywalking-agent out of it. Right?
   Thanks for your patience.
   
   ---nidhi
   
   On Thu, Mar 1, 2018 at 2:18 PM, ?? Wu Sheng 
   wrote:
   
   > This issue possible fixed in latest codes, you can try master code just to
   > test whether fix this , if yes, I cam guide you how to solve in 3. x
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   http://letsdosometalking.blogspot.com
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #858: Add support for mssql jdbc monitoring

[GitBox]

wu-sheng commented on issue #858: Add support for mssql jdbc monitoring
URL: 
https://github.com/apache/incubator-skywalking/issues/858#issuecomment-369831872
 
 
   @zone1511 And 
https://github.com/SkywalkingTest/skywalking-agent-testcases/blob/master/docs/how-to-write-a-plugin-testcase-cn.md
 this is a plugin test guide, if any plugin merged into master, you should 
follow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #858: Add support for mssql jdbc monitoring

[GitBox]

wu-sheng commented on issue #858: Add support for mssql jdbc monitoring
URL: 
https://github.com/apache/incubator-skywalking/issues/858#issuecomment-369786154
 
 
   @zone1511 The test just begin, follow #855  for update. And you should join 
gitter for our discussions and news post.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zone1511 commented on issue #858: Add support for mssql jdbc monitoring

[GitBox]

zone1511 commented on issue #858: Add support for mssql jdbc monitoring
URL: 
https://github.com/apache/incubator-skywalking/issues/858#issuecomment-369784096
 
 
   Does the 5.0 ui ready to use or I have to use old ui to test the plugin?
   
   Sent from my iPhone
   
   > On 2 Mar 2018, at 6:15 AM, ?? Wu Sheng  wrote:
   > 
   > sure. welcome. And i think you are familiar with our plugin process.
   > 
   > BTW, because rocketmq 3.x plugin has been merged, please send a pr to 
update supported list document.
   > 
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub, or mute the thread.
   > 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Podling Report Reminder - March 2018

[johndament]

Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 21 March 2018, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, March 07).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.
*   How does the podling rate their own maturity.

This should be appended to the Incubator Wiki page at:

https://wiki.apache.org/incubator/March2018

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC

[GitHub] wu-sheng commented on issue #858: Add support for mssql jdbc monitoring

[GitBox]

wu-sheng commented on issue #858: Add support for mssql jdbc monitoring
URL: 
https://github.com/apache/incubator-skywalking/issues/858#issuecomment-369749839
 
 
   sure. welcome. And i think you are familiar with our plugin process. 
   
   BTW, because rocketmq 3.x plugin has been merged, please send a pr to update 
supported list document.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zone1511 opened a new issue #858: Add support for mssql jdbc monitoring

[GitBox]

zone1511 opened a new issue #858: Add support for mssql jdbc monitoring
URL: https://github.com/apache/incubator-skywalking/issues/858
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [X] Feature or performance improvement
   ### Requirement or improvement
   Currently H2,mysql,oracle and postgresql jdbc monitoring are supported. I 
can contribute the mssql jdbc monitoring component


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #857: UI up to date.

[GitBox]

wu-sheng closed pull request #857: UI up to date.
URL: https://github.com/apache/incubator-skywalking/pull/857
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #857: UI up to date.

[GitBox]

coveralls commented on issue #857: UI up to date.
URL: 
https://github.com/apache/incubator-skywalking/pull/857#issuecomment-369623661
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15760110/badge)](https://coveralls.io/builds/15760110)
   
   Coverage remained the same at 19.497% when pulling 
**c2ddbe986133e613188f53cdd2e746b902ca0cef on sync-ui** into 
**accaf60afa5d7e71889eeb8b161a8a57ff6953e3 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #857: UI up to date.

[GitBox]

wu-sheng opened a new pull request #857: UI up to date.
URL: https://github.com/apache/incubator-skywalking/pull/857
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #121: Fix/e2e

[GitBox]

wu-sheng closed pull request #121: Fix/e2e
URL: https://github.com/apache/incubator-skywalking-ui/pull/121
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hanahmily opened a new pull request #121: Fix/e2e

[GitBox]

hanahmily opened a new pull request #121: Fix/e2e
URL: https://github.com/apache/incubator-skywalking-ui/pull/121
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #832: Add [Agent] Jedis LETTUCE client plugin

[GitBox]

coveralls commented on issue #832: Add [Agent] Jedis LETTUCE client plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/832#issuecomment-368721697
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15756793/badge)](https://coveralls.io/builds/15756793)
   
   Coverage decreased (-0.004%) to 19.493% when pulling 
**6dafc2e813a1f5cca64a2065bed4ababd14d1341 on lytscu:jedis** into 
**accaf60afa5d7e71889eeb8b161a8a57ff6953e3 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #856: Change the traceId type to be collection in trace graphql protocol.

[GitBox]

wu-sheng closed pull request #856: Change the traceId type to be collection in 
trace graphql protocol.
URL: https://github.com/apache/incubator-skywalking/pull/856
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/BasicTrace.java
 
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/BasicTrace.java
index 127157bab..0d21d3ee3 100644
--- 
a/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/BasicTrace.java
+++ 
b/apm-collector/apm-collector-storage/collector-storage-define/src/main/java/org/apache/skywalking/apm/collector/storage/ui/trace/BasicTrace.java
@@ -18,15 +18,32 @@
 
 package org.apache.skywalking.apm.collector.storage.ui.trace;
 
+import java.util.LinkedList;
+import java.util.List;
+
 /**
  * @author peng-yongsheng
  */
 public class BasicTrace {
+
+private String segmentId;
 private String operationName;
 private int duration;
 private long start;
 private Boolean isError;
-private String traceId;
+private List traceIds;
+
+public String getSegmentId() {
+return segmentId;
+}
+
+public void setSegmentId(String segmentId) {
+this.segmentId = segmentId;
+}
+
+public BasicTrace() {
+this.traceIds = new LinkedList<>();
+}
 
 public String getOperationName() {
 return operationName;
@@ -60,11 +77,11 @@ public void setError(Boolean error) {
 isError = error;
 }
 
-public String getTraceId() {
-return traceId;
+public List getTraceIds() {
+return traceIds;
 }
 
-public void setTraceId(String traceId) {
-this.traceId = traceId;
+public void setTraceIds(List traceIds) {
+this.traceIds = traceIds;
 }
 }
diff --git 
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/SegmentDurationEsUIDAO.java
 
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/SegmentDurationEsUIDAO.java
index 058b106a8..90046b2d3 100644
--- 
a/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/SegmentDurationEsUIDAO.java
+++ 
b/apm-collector/apm-collector-storage/collector-storage-es-provider/src/main/java/org/apache/skywalking/apm/collector/storage/es/dao/ui/SegmentDurationEsUIDAO.java
@@ -91,7 +91,7 @@ public TraceBrief loadTop(long startSecondTimeBucket, long 
endSecondTimeBucket,
 for (SearchHit searchHit : searchResponse.getHits().getHits()) {
 BasicTrace basicTrace = new BasicTrace();
 
-
basicTrace.setTraceId((String)searchHit.getSource().get(SegmentDurationTable.COLUMN_TRACE_ID));
+
basicTrace.setSegmentId((String)searchHit.getSource().get(SegmentDurationTable.COLUMN_SEGMENT_ID));
 
basicTrace.setStart(((Number)searchHit.getSource().get(SegmentDurationTable.COLUMN_START_TIME)).longValue());
 
basicTrace.setOperationName((String)searchHit.getSource().get(SegmentDurationTable.COLUMN_SERVICE_NAME));
 
basicTrace.setDuration(((Number)searchHit.getSource().get(SegmentDurationTable.COLUMN_DURATION)).intValue());
diff --git 
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/SegmentDurationH2UIDAO.java
 
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/SegmentDurationH2UIDAO.java
index 7699f0903..b47fd6617 100644
--- 
a/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/SegmentDurationH2UIDAO.java
+++ 
b/apm-collector/apm-collector-storage/collector-storage-h2-provider/src/main/java/org/apache/skywalking/apm/collector/storage/h2/dao/ui/SegmentDurationH2UIDAO.java
@@ -101,9 +101,9 @@ public TraceBrief loadTop(long startSecondTimeBucket, long 
endSecondTimeBucket,
 try (ResultSet rs = client.executeQuery(sql, p)) {
 while (rs.next()) {
 BasicTrace basicTrace = new BasicTrace();
+
basicTrace.setSegmentId(rs.getString(SegmentDurationTable.COLUMN_SEGMENT_ID));
 
basicTrace.setDuration(rs.getInt(SegmentDurationTable.COLUMN_DURATION));
 
basicTrace.setStart(rs.getLong(SegmentDurationTable.COLUMN_START_TIME));
-  

[GitHub] coveralls commented on issue #856: Change the traceId type to be collection in trace graphql protocol.

[GitBox]

coveralls commented on issue #856: Change the traceId type to be collection in 
trace graphql protocol.
URL: 
https://github.com/apache/incubator-skywalking/pull/856#issuecomment-369548774
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15755853/badge)](https://coveralls.io/builds/15755853)
   
   Coverage decreased (-0.01%) to 19.497% when pulling 
**08d26eca09af37d0ca1fd49d9e820381655ea6b6 on 
peng-yongsheng:feature/queryBasicTraces** into 
**a498a91fceade42436fd3d990d31ddd06c218860 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] peng-yongsheng opened a new pull request #856: Change the traceId type to be collection in trace graphql protocol.

[GitBox]

peng-yongsheng opened a new pull request #856: Change the traceId type to be 
collection in trace graphql protocol.
URL: https://github.com/apache/incubator-skywalking/pull/856
 
 
   trace.graphqls
   
   ```
   type BasicTrace {
   -   traceId: String
   +   traceIds: [String!]!
   }
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #105: trace/queryBasicTraces

[GitBox]

wu-sheng commented on issue #105: trace/queryBasicTraces
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/105#issuecomment-369523311
 
 
   ```
 "operationName": 
"org.skywaking.apm.testcase.dubbo.services.GreetService.doBusiness()",
 "duration": 1000,
 "start": "1490976210501",
 "isError": false
   ```
   
   Miss **traceId**.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services