[GitHub] coveralls commented on issue #727: Finish the proto TODO list

[GitBox]

coveralls commented on issue #727: Finish the proto TODO list
URL: 
https://github.com/apache/incubator-skywalking/pull/727#issuecomment-355436138
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14908998/badge)](https://coveralls.io/builds/14908998)
   
   Coverage increased (+0.1%) to 22.251% when pulling 
**dfeeeab1086298d246f6e75eb7f873cacec19273 on adjust-network-proto** into 
**60422f512bffd17f86121655fa84d88a88fedd51 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wolfelven opened a new issue #89: skywalking-ui can't open

[GitBox]

wolfelven opened a new issue #89: skywalking-ui can't open
URL: https://github.com/apache/incubator-skywalking-ui/issues/89
 
 
   According to the README.md, I download 
https://github.com/apache/incubator-skywalking-ui/releases/v3.2.6. when I run 
startup.sh,the commond shows:
   Starting web service
   Skywalking Web started successfully!
   But I can't open http://127.0.0.1:8080/ in browser .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wolfelven commented on issue #88: ???ui??

[GitBox]

wolfelven commented on issue #88: ???ui??
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/88#issuecomment-355451485
 
 
   release v3.2.6?tar.gz?zip?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wolfelven commented on issue #89: skywalking-ui can't open

[GitBox]

wolfelven commented on issue #89: skywalking-ui can't open
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/89#issuecomment-355457377
 
 
   sorry, my /logs is empty.
   By the way, I only startup the web-ui, there is no skywalking-agent and 
collector.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #89: skywalking-ui can't open

[GitBox]

wu-sheng commented on issue #89: skywalking-ui can't open
URL: 
https://github.com/apache/incubator-skywalking-ui/issues/89#issuecomment-355458234
 
 
   I think you should check you JRE(1.8 requirement). And you can try to run 
the commands(in .bat) line by line by yourself, in order to find what really 
happen. The output(`startup successfully`) likes Tomcat's startup, which only 
means the commend executed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae opened a new pull request #729: [Agent] fix jetty client doesn't work in after version 9.1

[GitBox]

ascrutae opened a new pull request #729: [Agent] fix jetty client doesn't work 
in after version 9.1
URL: https://github.com/apache/incubator-skywalking/pull/729
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #728: [Agent] fix the spring plugin doesn't work

[GitBox]

wu-sheng closed pull request #728: [Agent] fix the spring plugin doesn't work
URL: https://github.com/apache/incubator-skywalking/pull/728
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/EnhanceRequireObjectCache.java
 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/EnhanceRequireObjectCache.java
index 4b80c011a..914882eed 100644
--- 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/EnhanceRequireObjectCache.java
+++ 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/EnhanceRequireObjectCache.java
@@ -16,7 +16,6 @@
  *
  */
 
-
 package org.apache.skywalking.apm.plugin.spring.mvc.commons;
 
 import java.lang.reflect.Method;
@@ -26,13 +25,14 @@
 public class EnhanceRequireObjectCache {
 private PathMappingCache pathMappingCache;
 private NativeWebRequest nativeWebRequest;
+private HttpServletResponse httpResponse;
 
 public void setPathMappingCache(PathMappingCache pathMappingCache) {
 this.pathMappingCache = pathMappingCache;
 }
 
 public HttpServletResponse getHttpServletResponse() {
-return (HttpServletResponse)nativeWebRequest.getNativeResponse();
+return httpResponse == null ? 
(HttpServletResponse)nativeWebRequest.getNativeResponse() : httpResponse;
 }
 
 public void setNativeWebRequest(NativeWebRequest nativeWebRequest) {
@@ -50,4 +50,12 @@ public void addPathMapping(Method method, String url) {
 public PathMappingCache getPathMappingCache() {
 return pathMappingCache;
 }
+
+public void setHttpResponse(HttpServletResponse httpResponse) {
+this.httpResponse = httpResponse;
+}
+
+public HttpServletResponse getHttpResponse() {
+return httpResponse;
+}
 }
diff --git 
a/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/define/AnnotationMethodHandlerAdapterInstrumentation.java
 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/define/AnnotationMethodHandlerAdapterInstrumentation.java
new file mode 100644
index 0..cfaba1b92
--- /dev/null
+++ 
b/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/define/AnnotationMethodHandlerAdapterInstrumentation.java
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.spring.mvc.commons.define;
+
+import net.bytebuddy.description.method.MethodDescription;
+import net.bytebuddy.matcher.ElementMatcher;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.ConstructorInterceptPoint;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.InstanceMethodsInterceptPoint;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassInstanceMethodsEnhancePluginDefine;
+import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
+
+import static net.bytebuddy.matcher.ElementMatchers.named;
+import static 
org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName;
+
+public class AnnotationMethodHandlerAdapterInstrumentation extends 
ClassInstanceMethodsEnhancePluginDefine {
+@Override protected ConstructorInterceptPoint[] 
getConstructorsInterceptPoints() {
+return new ConstructorInterceptPoint[0];
+}
+
+@Override protected InstanceMethodsInterceptPoint[] 
getInstanceMethodsInterceptPoints() {
+return new InstanceMethodsInterceptPoint[] {
+new InstanceMethodsInterceptPoint() {
+@Override 

[GitHub] coveralls commented on issue #727: Finish the proto TODO list

[GitBox]

coveralls commented on issue #727: Finish the proto TODO list
URL: 
https://github.com/apache/incubator-skywalking/pull/727#issuecomment-355483852
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14912149/badge)](https://coveralls.io/builds/14912149)
   
   Coverage increased (+0.1%) to 22.251% when pulling 
**1bf8961fdda61c6e74ebaf2e69fb1c75c7defad8 on adjust-network-proto** into 
**48717e448f97b20db43180d5179a2ad01567e3e6 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

[GitBox]

coveralls commented on issue #670: [Agent] Provide plugins for Apache 
httpcomponent AsyncClient 4.1 #588
URL: 
https://github.com/apache/incubator-skywalking/pull/670#issuecomment-355455861
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14910499/badge)](https://coveralls.io/builds/14910499)
   
   Coverage decreased (-0.02%) to 22.115% when pulling 
**722f8a92cd8829a9585615892240bcc3f9b89bf7 on lytscu:develop** into 
**60422f512bffd17f86121655fa84d88a88fedd51 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae opened a new pull request #728: [Agent] fix the spring plugin doesn't work

[GitBox]

ascrutae opened a new pull request #728: [Agent] fix the spring plugin doesn't 
work
URL: https://github.com/apache/incubator-skywalking/pull/728
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #730: Support collector service instrumentation

[GitBox]

coveralls commented on issue #730: Support collector service instrumentation
URL: 
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355756686
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14930736/badge)](https://coveralls.io/builds/14930736)
   
   Coverage remained the same at 22.342% when pulling 
**59dca4b333d2db720df436051e8aa98701897c4a on collector/instrument** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WangHouLing commented on issue #698: Can I multiple agents on one box?

[GitBox]

WangHouLing commented on issue #698: Can I multiple agents on one box?
URL: 
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353537676
 
 
   @wu-sheng I'm sorry to give you a reply so late!
zone1511 has already expressed what I mean :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] li-ya closed issue #596: ManagedChannel isShutdown() isTerminated() ?????

[GitBox]

li-ya closed issue #596: ManagedChannel isShutdown() isTerminated() ?
URL: https://github.com/apache/incubator-skywalking/issues/596
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] li-ya commented on issue #596: ManagedChannel isShutdown() isTerminated() ?????

[GitBox]

li-ya commented on issue #596: ManagedChannel isShutdown() isTerminated() ?
URL: 
https://github.com/apache/incubator-skywalking/issues/596#issuecomment-353546408
 
 
   I can not reproduce the problem in my system,so I close the issure


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WangHouLing commented on issue #698: Can I multiple agents on one box?

[GitBox]

WangHouLing commented on issue #698: Can I multiple agents on one box?
URL: 
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353537702
 
 
   @wu-sheng I'm sorry to give you a reply so late!
zone1511 has already expressed what I mean :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zone1511 commented on issue #698: Can I multiple agents on one box?

[GitBox]

zone1511 commented on issue #698: Can I multiple agents on one box?
URL: 
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353536088
 
 
   he means in single os, running multiple application which want to monitor by 
the skywalking agent. Any way to specify the agent application name from JVM 
argument instead of reading from agent config.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zone1511 commented on issue #698: [Agent]Can we config the same agent jar/folder in different applications?

[GitBox]

zone1511 commented on issue #698: [Agent]Can we config the same agent 
jar/folder in different applications?
URL: 
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353546540
 
 
   Hi PMC,
 So the agent will read the config file related to its absolute location? 
In this way, we don't need to share one agent per machine and we can have many 
agent plus config plus log folder so each monitored application. As different 
agent may need to load different plugin for performance reason. If use same 
folder for multiple app. It is difficult to manage. 
   
   Sent from my iPhone
   
   > On 22 Dec 2017, at 3:26 PM, ?? Wu Sheng  wrote:
   > 
   > The easy answer is YES, you can.
   > 
   > But you should aware of these:
   > 
   > Follow this document(assume you need cn version) : link . You can use 
-Dskywalking.* to override any config in file as you wish.
   > When two application use the same agent folder, by default, your logs 
output into the same file. This is hard to read and understand, but these is a 
bug in this version(3.2.6) to override it. I already try to fix it, see #697.
   > So, that is why I just recommend use separated agent jars. OK?
   > 
   > BTW, I just change the issue title.
   > 
   > Hope these can help you.
   > 
   > ?
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub, or mute the thread.
   > 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jjtyro opened a new pull request #701: [Agent-Plugin] Add support to MysqlDataSource

[GitBox]

jjtyro opened a new pull request #701: [Agent-Plugin] Add support to 
MysqlDataSource
URL: https://github.com/apache/incubator-skywalking/pull/701
 
 
   MysqlDataSource use com.mysql.jdbc.NonRegisteringDriver?not 
com.mysql.jdbc.Driver.
   Add it to Agent's mysql-5.x-plugin.  #699 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jjtyro commented on issue #699: MySQL Plugin not support application using MysqlDataSource

[GitBox]

jjtyro commented on issue #699: MySQL Plugin not support application using 
MysqlDataSource 
URL: 
https://github.com/apache/incubator-skywalking/issues/699#issuecomment-353727775
 
 
   @wu-sheng  A little bit of code change?a pull request has been sent.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource

[GitBox]

wu-sheng commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL: 
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353729341
 
 
   @jjtyro This pull request seems good enough, but you have a conflict. Please 
resolve it first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #702: [Agent] Support the async function of okhttp plugin

[GitBox]

coveralls commented on issue #702: [Agent] Support the  async function of 
okhttp plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/702#issuecomment-353772081
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14791262/badge)](https://coveralls.io/builds/14791262)
   
   Coverage decreased (-0.09%) to 23.019% when pulling 
**7dd6eec651dc39784a319168c1402c9385729841 on 
ascrutae:feature/okhttpclient-async** into 
**cf72037f67da11cadc5cfd2e97b22c15d5aabb30 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae opened a new pull request #702: support the async function of okhttp plugin

[GitBox]

ascrutae opened a new pull request #702: support the  async function of okhttp 
plugin
URL: https://github.com/apache/incubator-skywalking/pull/702
 
 
   The okhttp plugin doesn't support the async function. This PR support the 
async function of the plugin


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #703: Prepare for ui-query GraphQL protocol

[GitBox]

wu-sheng opened a new pull request #703: Prepare for ui-query GraphQL protocol
URL: https://github.com/apache/incubator-skywalking/pull/703
 
 
   1. Move `apm-network` module under the new root module `apm-protocol`. 
   1. Add `apm-ui-query` under the `apm-protocol` module.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #702: [Agent] Support the async function of okhttp plugin

[GitBox]

wu-sheng closed pull request #702: [Agent] Support the  async function of 
okhttp plugin
URL: https://github.com/apache/incubator-skywalking/pull/702
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/EnqueueInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/EnqueueInterceptor.java
new file mode 100644
index 0..14b415bae
--- /dev/null
+++ 
b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/EnqueueInterceptor.java
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.okhttp.v3;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import okhttp3.Headers;
+import okhttp3.HttpUrl;
+import okhttp3.Request;
+import org.apache.skywalking.apm.agent.core.context.CarrierItem;
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+public class EnqueueInterceptor implements InstanceMethodsAroundInterceptor, 
InstanceConstructorInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
+MethodInterceptResult result) throws Throwable {
+
+Request request = (Request)objInst.getSkyWalkingDynamicField();
+
+ContextCarrier contextCarrier = new ContextCarrier();
+HttpUrl requestUrl = request.url();
+AbstractSpan span = 
ContextManager.createExitSpan(requestUrl.uri().getPath(), contextCarrier, 
requestUrl.host() + ":" + requestUrl.port());
+span.setComponent(ComponentsDefine.OKHTTP);
+Tags.HTTP.METHOD.set(span, request.method());
+Tags.URL.set(span, requestUrl.uri().toString());
+SpanLayer.asHttp(span);
+
+Field headersField = Request.class.getDeclaredField("headers");
+Field modifiersField = Field.class.getDeclaredField("modifiers");
+modifiersField.setAccessible(true);
+modifiersField.setInt(headersField, headersField.getModifiers() & 
~Modifier.FINAL);
+
+headersField.setAccessible(true);
+Headers.Builder headerBuilder = request.headers().newBuilder();
+CarrierItem next = contextCarrier.items();
+while (next.hasNext()) {
+next = next.next();
+headerBuilder.add(next.getHeadKey(), next.getHeadValue());
+}
+headersField.set(request, headerBuilder.build());
+
+objInst.setSkyWalkingDynamicField(ContextManager.capture());
+}
+
+@Override
+public Object afterMethod(EnhancedInstance objInst, Method method, 
Object[] allArguments, Class[] argumentsTypes,
+Object ret) throws Throwable {
+ContextManager.stopSpan();
+return ret;
+}
+
+@Override public void handleMethodException(EnhancedInstance objInst, 
Method method, Object[] allArguments,
+Class[] argumentsTypes, Throwable t) {
+ContextManager.activeSpan().errorOccurred().log(t);
+}
+
+@Override public void onConstruct(EnhancedInstance objInst, Object[] 

[GitHub] coveralls commented on issue #703: Prepare for ui-query GraphQL protocol

[GitBox]

coveralls commented on issue #703: Prepare for ui-query GraphQL protocol
URL: 
https://github.com/apache/incubator-skywalking/pull/703#issuecomment-353815152
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14794961/badge)](https://coveralls.io/builds/14794961)
   
   Coverage remained the same at 23.019% when pulling 
**6e152b4fb03fbb4a2c9b76f0502017611e7fdb86 on 5.0-alpha/ui-query-protocol** 
into **121cabb5ba433d72f5d6f1c8c2ed3d63cabd0b27 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae opened a new pull request #704: [Agent] Unsupport the async function of jetty client plugin

[GitBox]

ascrutae opened a new pull request #704: [Agent] Unsupport the async function 
of jetty client plugin
URL: https://github.com/apache/incubator-skywalking/pull/704
 
 
   The async function of jetty client doesn't work. Remove this function 
temporarily. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae closed pull request #703: Prepare for ui-query GraphQL protocol

[GitBox]

ascrutae closed pull request #703: Prepare for ui-query GraphQL protocol
URL: https://github.com/apache/incubator-skywalking/pull/703
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #704: [Agent] Unsupport the async function of jetty client plugin

[GitBox]

wu-sheng closed pull request #704: [Agent] Unsupport the async function of 
jetty client plugin
URL: https://github.com/apache/incubator-skywalking/pull/704
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-sniffer/apm-sdk-plugin/jetty-plugin/jetty-client-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jetty/v9/client/AsyncHttpRequestSendInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/jetty-plugin/jetty-client-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jetty/v9/client/AsyncHttpRequestSendInterceptor.java
deleted file mode 100644
index 490be9d74..0
--- 
a/apm-sniffer/apm-sdk-plugin/jetty-plugin/jetty-client-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jetty/v9/client/AsyncHttpRequestSendInterceptor.java
+++ /dev/null
@@ -1,71 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- */
-
-
-package org.apache.skywalking.apm.plugin.jetty.v9.client;
-
-import java.lang.reflect.Method;
-import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
-import org.apache.skywalking.apm.agent.core.context.tag.Tags;
-import org.eclipse.jetty.client.HttpRequest;
-import org.eclipse.jetty.http.HttpFields;
-import org.apache.skywalking.apm.agent.core.context.CarrierItem;
-import org.apache.skywalking.apm.agent.core.context.ContextManager;
-import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
-import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer;
-import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
-import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
-import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
-import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
-
-public class AsyncHttpRequestSendInterceptor implements 
InstanceMethodsAroundInterceptor {
-
-@Override
-public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
-MethodInterceptResult result) throws Throwable {
-HttpRequest request = (HttpRequest)objInst;
-ContextCarrier contextCarrier = new ContextCarrier();
-AbstractSpan span = 
ContextManager.createExitSpan(request.getURI().getPath(), contextCarrier, 
request.getHost() + ":" + request.getPort());
-span.setComponent(ComponentsDefine.JETTY_CLIENT);
-Tags.HTTP.METHOD.set(span, request.getMethod().asString());
-Tags.URL.set(span, request.getURI().toString());
-SpanLayer.asHttp(span);
-
-CarrierItem next = contextCarrier.items();
-HttpFields field = request.getHeaders();
-while (next.hasNext()) {
-next = next.next();
-field.add(next.getHeadKey(), next.getHeadValue());
-}
-
-EnhancedInstance callBackResult = (EnhancedInstance)allArguments[0];
-callBackResult.setSkyWalkingDynamicField(ContextManager.capture());
-}
-
-@Override
-public Object afterMethod(EnhancedInstance objInst, Method method, 
Object[] allArguments, Class[] argumentsTypes,
-Object ret) throws Throwable {
-ContextManager.stopSpan();
-return ret;
-}
-
-@Override public void handleMethodException(EnhancedInstance objInst, 
Method method, Object[] allArguments,
-Class[] argumentsTypes, Throwable t) {
-ContextManager.activeSpan().errorOccurred().log(t);
-}
-}
diff --git 
a/apm-sniffer/apm-sdk-plugin/jetty-plugin/jetty-client-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jetty/v9/client/CompleteListenerInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/jetty-plugin/jetty-client-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jetty/v9/client/CompleteListenerInterceptor.java
deleted file mode 100644
index 677fbff99..0
--- 

[GitHub] coveralls commented on issue #704: [Agent] Unsupport the async function of jetty client plugin

[GitBox]

coveralls commented on issue #704: [Agent] Unsupport the async function of 
jetty client plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/704#issuecomment-353827968
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14795374/badge)](https://coveralls.io/builds/14795374)
   
   Coverage decreased (-0.01%) to 23.005% when pulling 
**65693c3d7f36549ccab68770c037e22b2deab62d on ascrutae:fix/jettyclient-issue** 
into **5e40b8e3fbf7e4142796efb694f810325dc85d4c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource

[GitBox]

wu-sheng commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL: 
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353835124
 
 
   @jjtyro Thanks for you helps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jjtyro commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource

[GitBox]

jjtyro commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL: 
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353835231
 
 
   @wu-sheng no tks! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #555: ofbiz??agent??

[GitBox]

wu-sheng commented on issue #555: ofbiz??agent??
URL: 
https://github.com/apache/incubator-skywalking/issues/555#issuecomment-353840446
 
 
   @yeshm  #706 helps to solve this by skipping the can't resolved type.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #578: [Agent] drools????

[GitBox]

wu-sheng closed issue #578: [Agent] drools
URL: https://github.com/apache/incubator-skywalking/issues/578
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #578: [Agent] drools????

[GitBox]

wu-sheng commented on issue #578: [Agent] drools
URL: 
https://github.com/apache/incubator-skywalking/issues/578#issuecomment-353840423
 
 
   @jaketyao #706 helps to solve this by skipping the can't resolved type.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #638: [Vote][Discussion]New collector/ui API practices

[GitBox]

wu-sheng closed issue #638: [Vote][Discussion]New collector/ui API practices
URL: https://github.com/apache/incubator-skywalking/issues/638
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #638: [Vote][Discussion]New collector/ui API practices

[GitBox]

wu-sheng commented on issue #638: [Vote][Discussion]New collector/ui API 
practices
URL: 
https://github.com/apache/incubator-skywalking/issues/638#issuecomment-353842583
 
 
   Received @peng-yongsheng and @hanahmily feedbacks. We are going to GraphQL 
to implement these APIs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wengangJi opened a new issue #705: mvn compile error

[GitBox]

wengangJi opened a new issue #705: mvn compile error
URL: https://github.com/apache/incubator-skywalking/issues/705
 
 
   ![Uploading image.png?]()
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #701: [Agent-Plugin] Add support to MysqlDataSource

[GitBox]

wu-sheng closed pull request #701: [Agent-Plugin] Add support to MysqlDataSource
URL: https://github.com/apache/incubator-skywalking/pull/701
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
index bea877b05..27b38e174 100644
--- 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
+++ 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
@@ -32,6 +32,6 @@
 public class DriverInstrumentation extends AbstractDriverInstrumentation {
 @Override
 protected ClassMatch enhanceClass() {
-return byMultiClassMatch("com.mysql.jdbc.Driver", 
"com.mysql.cj.jdbc.Driver");
+return byMultiClassMatch("com.mysql.jdbc.Driver", 
"com.mysql.cj.jdbc.Driver", "com.mysql.jdbc.NonRegisteringDriver");
 }
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource

[GitBox]

coveralls commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL: 
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353834893
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14795674/badge)](https://coveralls.io/builds/14795674)
   
   Coverage remained the same at 23.005% when pulling 
**35610fab7759f81b17ef775c825521331ab1ad03 on 
jjtyro:fix-agent-to-support-mysqldatasource** into 
**6b288b38f332214912bdd4f874ec918afbf307ae on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #705: mvn compile error

[GitBox]

wu-sheng closed issue #705: mvn compile error
URL: https://github.com/apache/incubator-skywalking/issues/705
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #705: mvn compile error

[GitBox]

wu-sheng commented on issue #705: mvn compile error
URL: 
https://github.com/apache/incubator-skywalking/issues/705#issuecomment-353835509
 
 
   @wengangJi This is not an error triggered by SkyWalking project. This 
depends on Google gRPC/Protobuf tools: `protoc`. So if you have any problem to 
run it, you should submit an issue in Protobuf or gRPC project.
   
   I just can share with you about that, I can run this tool in my windows 7. 
Most of our known developers are using Mac OS.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #706: Add a ProtectiveShieldMatcher to prevent match exception.

[GitBox]

wu-sheng opened a new pull request #706: Add a ProtectiveShieldMatcher to 
prevent match exception.
URL: https://github.com/apache/incubator-skywalking/pull/706
 
 
In same cases, some frameworks and libraries use some binary codes tech 
too. From the community feedback, some of
   them have compatible issues with byte-buddy core, which trigger "Can't 
resolve type description" exception.
   
   So I build this protective shield by a nested matcher. When the origin 
matcher(s) can't resolve the type, the
   SkyWalking agent ignores this types.
   
   Notice: this ignore mechanism may miss some instrumentations, but at most 
cases, it's same. If missing happens, please pay attention to the WARNING logs.
   
   FYI @peng-yongsheng @ascrutae 
   
   This related to #578 #555 , from the Raphew's help: 
https://github.com/raphw/byte-buddy/issues/373


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #707: Init ui-protocol

[GitBox]

coveralls commented on issue #707: Init ui-protocol
URL: 
https://github.com/apache/incubator-skywalking/pull/707#issuecomment-353846882
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14796397/badge)](https://coveralls.io/builds/14796397)
   
   Coverage remained the same at 23.005% when pulling 
**48f0f22de697d5e37307ab34ed6b57c09d1c6df4 on feature/ui-protocol** into 
**720f4048acfe424e98e2746ea19fd623e948b8e3 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae closed pull request #706: [Agent]Add a ProtectiveShieldMatcher to prevent match exception.

[GitBox]

ascrutae closed pull request #706: [Agent]Add a ProtectiveShieldMatcher to 
prevent match exception.
URL: https://github.com/apache/incubator-skywalking/pull/706
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on issue #706: [Agent]Add a ProtectiveShieldMatcher to prevent match exception.

[GitBox]

ascrutae commented on issue #706: [Agent]Add a ProtectiveShieldMatcher to 
prevent match exception.
URL: 
https://github.com/apache/incubator-skywalking/pull/706#issuecomment-353852416
 
 
   This function is tested. Here is the [auto_test 
report](https://github.com/SkywalkingTest/agent-integration-test-report/blob/master/fix/cant-resolve-types/report-2017-12-25-16-04.md)
   
   *NOTE*: Ignore the failure cases. because those cases are not perfect and 
the follow-up will improve it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #704: [Agent] Unsupport the async function of jetty client plugin

[GitBox]

coveralls commented on issue #704: [Agent] Unsupport the async function of 
jetty client plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/704#issuecomment-353825542
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14795267/badge)](https://coveralls.io/builds/14795267)
   
   Coverage decreased (-0.01%) to 23.005% when pulling 
**bb2897684d16135d8e43d2df4c900bf4b1a8713a on ascrutae:fix/jettyclient-issue** 
into **121cabb5ba433d72f5d6f1c8c2ed3d63cabd0b27 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on issue #704: [Agent] Unsupport the async function of jetty client plugin

[GitBox]

ascrutae commented on issue #704: [Agent] Unsupport the async function of jetty 
client plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/704#issuecomment-353825749
 
 
   Yeah. the interceptor class is incorrect since we changed the package to 
`apache`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #707: Init ui-protocol

[GitBox]

wu-sheng opened a new pull request #707: Init ui-protocol
URL: https://github.com/apache/incubator-skywalking/pull/707
 
 
   I add 7 `.graphqls` files to define the protocol between UI and collector as 
we discussed in #638 . The scripts are defined by functions.
   
   - common
   Include common objects, which used in global
   - overview-layer
   Query data without specific application, server or service. It includes info 
for overview the whole cluster.
   - application-layer
   Query data with specific application code.
   - server-layer
   Query data with specific server id.
   - service-layer
   Query data with specific service id
   - trace
   Query trace by some conditions.
   - alarm
   Query alarm info.
   
   I open this pull request for @peng-yongsheng @hanahmily to participate the 
protocol. And please send pull requests about the potocol into branch 
`feature/ui-protocol`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #730: Support collector service instrumentation

[GitBox]

coveralls commented on issue #730: Support collector service instrumentation
URL: 
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355827374
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14937704/badge)](https://coveralls.io/builds/14937704)
   
   Coverage remained the same at 22.342% when pulling 
**63781283fedc024c218d01ea98daff30e52ef208 on collector/instrument** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

[GitBox]

coveralls commented on issue #732: Make the nodes of Topology nullable. And 
elements in it are not null.
URL: 
https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356176479
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14960415/badge)](https://coveralls.io/builds/14960415)
   
   Coverage remained the same at 22.342% when pulling 
**d730e174f625b49cac3873b7d87d1c318b4503c1 on fix/graphql/node-nullable** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #732: Make the nodes of Topology nullable. And elements in it are not null.

[GitBox]

wu-sheng opened a new pull request #732: Make the nodes of Topology nullable. 
And elements in it are not null.
URL: https://github.com/apache/incubator-skywalking/pull/732
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin

[GitBox]

wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin
URL: 
https://github.com/apache/incubator-skywalking/issues/735#issuecomment-356291663
 
 
   Wait for @YunaiV 's pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] clevertension commented on issue #659: [Agent] Spring Bean Plugin

[GitBox]

clevertension commented on issue #659: [Agent] Spring Bean Plugin
URL: 
https://github.com/apache/incubator-skywalking/issues/659#issuecomment-355870454
 
 
   sorry, i can't finish this task before spring festival, so anyone who have 
the time can take this task now


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #659: [Agent] Spring Bean Plugin

[GitBox]

wu-sheng commented on issue #659: [Agent] Spring Bean Plugin
URL: 
https://github.com/apache/incubator-skywalking/issues/659#issuecomment-355870818
 
 
   @ascrutae I hope you have the time to provide this plugin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on issue #659: [Agent] Spring Bean Plugin

[GitBox]

ascrutae commented on issue #659: [Agent] Spring Bean Plugin
URL: 
https://github.com/apache/incubator-skywalking/issues/659#issuecomment-355873211
 
 
   OK? I got it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #730: Support collector service instrumentation

[GitBox]

coveralls commented on issue #730: Support collector service instrumentation
URL: 
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355879558
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14942177/badge)](https://coveralls.io/builds/14942177)
   
   Coverage remained the same at 22.342% when pulling 
**f13d63a20dd88cba78754b3eeb6ed8c5724a7659 on collector/instrument** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #730: Support collector service instrumentation

[GitBox]

coveralls commented on issue #730: Support collector service instrumentation
URL: 
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355922069
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14944621/badge)](https://coveralls.io/builds/14944621)
   
   Coverage remained the same at 22.342% when pulling 
**21ed217c647130a96404433fd79376d65ed2d6d5 on collector/instrument** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xjr100419 opened a new issue #731: ?????????????

[GitBox]

xjr100419 opened a new issue #731: ?
URL: https://github.com/apache/incubator-skywalking/issues/731
 
 
   ### What version of sky-walking are you using?
   v3.2.6
   
   ### What version of your OS?
   window
   
   ### What version of your JRE?
   java8
   
   
   ?? agent.config 
   # Ignore the segments if their operation names start with these suffix.
   # 
agent.ignore_suffix=.jpg,.jpeg,.js,.css,.png,.bmp,.gif,.ico,.mp3,.mp4,.html,.svg
   
   ? ??
    spring cloud  ?? ??
   
   ? ?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

[GitBox]

coveralls commented on issue #670: [Agent] Provide plugins for Apache 
httpcomponent AsyncClient 4.1 #588
URL: 
https://github.com/apache/incubator-skywalking/pull/670#issuecomment-355894264
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14943132/badge)](https://coveralls.io/builds/14943132)
   
   Coverage decreased (-0.002%) to 22.34% when pulling 
**c07097efecb7e736f9a0702b2a0a6948c8dd4e7a on lytscu:develop** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #670: [Agent] Provide plugins for Apache httpcomponent AsyncClient 4.1 #588

[GitBox]

coveralls commented on issue #670: [Agent] Provide plugins for Apache 
httpcomponent AsyncClient 4.1 #588
URL: 
https://github.com/apache/incubator-skywalking/pull/670#issuecomment-355894151
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14943121/badge)](https://coveralls.io/builds/14943121)
   
   Coverage decreased (-0.02%) to 22.323% when pulling 
**c07097efecb7e736f9a0702b2a0a6948c8dd4e7a on lytscu:develop** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

[GitBox]

ascrutae commented on a change in pull request #737: Remove OJDBC and resin 
artifacts from ci-dependencies driectory as they as not Apache license 
compatible
URL: 
https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405
 
 

 ##
 File path: pom.xml
 ##
 @@ -318,4 +278,89 @@
 
 
 
+
+
+
+
+
+install-ojdbc
+
+
+
${basedir}/ci-dependencies/ojdbc14-10.2.0.4.0.jar
+
+
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.6.0
+
+
+install-ojdbc
+false
+process-resources
+
+exec
+
+
+mvn
+
+
install:install-file
+
-Dfile=ojdbc14-10.2.0.4.0.jar
+
-DgroupId=com.oracle
+
-DartifactId=ojdbc14
+
-Dversion=10.2.0.4.0
+-Dpackaging=jar
+
+
${project.basedir}/ci-dependencies
+
+
+
+
+
+
+
+
+
+install-resin
 
 Review comment:
   I think the `resin-3` plugin should be removed too. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #584: Add instrument module in collector

[GitBox]

wu-sheng closed issue #584: Add instrument module in collector
URL: https://github.com/apache/incubator-skywalking/issues/584
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for metrics and traces, maybe alarms

[GitBox]

wu-sheng commented on issue #390: [Collector-QUERY-APIs] Provide Collector 
APIKit for metrics and traces, maybe alarms
URL: 
https://github.com/apache/incubator-skywalking/issues/390#issuecomment-356830889
 
 
   Designed and provided in 5.0. Check 
[UI-Query-Protocol](https://github.com/apache/incubator-skywalking/blob/master/apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for metrics and traces, maybe alarms

[GitBox]

wu-sheng closed issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for 
metrics and traces, maybe alarms
URL: https://github.com/apache/incubator-skywalking/issues/390
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #450: [Collector] Provide event(including alarm) logs feature

[GitBox]

wu-sheng closed issue #450: [Collector] Provide event(including alarm) logs 
feature
URL: https://github.com/apache/incubator-skywalking/issues/450
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lytscu commented on issue #437: [Agent] ServiceComb Plugin

[GitBox]

lytscu commented on issue #437: [Agent] ServiceComb Plugin
URL: 
https://github.com/apache/incubator-skywalking/issues/437#issuecomment-356837774
 
 
   Ok ,I will make contact with Teacher Jiang.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #584: Add instrument module in collector

[GitBox]

wu-sheng commented on issue #584: Add instrument module in collector
URL: 
https://github.com/apache/incubator-skywalking/issues/584#issuecomment-356828288
 
 
   I spend a week to provide the first instrument in #730 . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #660: [UI] Feature of dashboard

[GitBox]

wu-sheng commented on issue #660: [UI] Feature of dashboard
URL: 
https://github.com/apache/incubator-skywalking/issues/660#issuecomment-356828091
 
 
   I am closing this. The UI features are developing, and most are finished. 
Look forward @hanahmily to share us the exited 5.0 UI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #660: [UI] Feature of dashboard

[GitBox]

wu-sheng closed issue #660: [UI] Feature of dashboard
URL: https://github.com/apache/incubator-skywalking/issues/660
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #739: [Agent] Support the version 9.4.x of postgresql jdbc driver

[GitBox]

coveralls commented on issue #739: [Agent] Support the version 9.4.x of 
postgresql jdbc driver
URL: 
https://github.com/apache/incubator-skywalking/pull/739#issuecomment-356818441
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14996669/badge)](https://coveralls.io/builds/14996669)
   
   Coverage remained the same at 22.266% when pulling 
**4223d22028be49787d99669382facfb72d5d5b65 on 
ascrutae:feature/support-postgresql-9.x** into 
**6e1ac504f21cb8248a863c433c26357e64f05650 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #500: webui???????????? ? ????

[GitBox]

wu-sheng commented on issue #500: webui ?  
URL: 
https://github.com/apache/incubator-skywalking/issues/500#issuecomment-356830533
 
 
   Alarm features will be provided in 5.0 . Multi-tenant is not an expected 
feature in our milestone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #496: webui???????????? ? ????

[GitBox]

wu-sheng commented on issue #496: webui ? 
URL: 
https://github.com/apache/incubator-skywalking/issues/496#issuecomment-356830520
 
 
   Alarm features will be provided in 5.0 . Multi-tenant is not an expected 
feature in our milestone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #496: webui???????????? ? ????

[GitBox]

wu-sheng closed issue #496: webui ? 
URL: https://github.com/apache/incubator-skywalking/issues/496
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #500: webui???????????? ? ????

[GitBox]

wu-sheng closed issue #500: webui ?  
URL: https://github.com/apache/incubator-skywalking/issues/500
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #740: maven error

[GitBox]

wu-sheng closed issue #740: maven error
URL: https://github.com/apache/incubator-skywalking/issues/740
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #740: maven error

[GitBox]

wu-sheng commented on issue #740: maven error
URL: 
https://github.com/apache/incubator-skywalking/issues/740#issuecomment-356841151
 
 
   First of all, CI passed, means the compile status is health. Then we didn't 
expect you to compile a single module of the project. See 
https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md
 to know how to compile.
   
   And then, 5.0 is our next release, and branch `master` is for development. 
So I didn't recommend you to use it, else you want to contribute somethings.
   
   We haven't release version after we accepted by Apache. So 3.x is not an 
Apache release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae opened a new pull request #739: [Agent] Support the version 9.4.x of postgresql jdbc driver

[GitBox]

ascrutae opened a new pull request #739: [Agent] Support the version 9.4.x of 
postgresql jdbc driver
URL: https://github.com/apache/incubator-skywalking/pull/739
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #589: [Agent] Provide plugin for Apache Httpcomponent httpclient 4.4 and 4.5

[GitBox]

wu-sheng commented on issue #589: [Agent] Provide plugin for Apache 
Httpcomponent httpclient 4.4 and 4.5
URL: 
https://github.com/apache/incubator-skywalking/issues/589#issuecomment-356830003
 
 
   Based on [test 
reports](https://github.com/SkywalkingTest/agent-integration-test-report#httpclient),
 http client 4.4 , 4.5 have been supported.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #568: [Collector] ????es??????es????????????????????????????????????

[GitBox]

wu-sheng commented on issue #568: [Collector] 
es??es
URL: 
https://github.com/apache/incubator-skywalking/issues/568#issuecomment-356830170
 
 
   Closing this. Already supported.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #450: [Collector] Provide event(including alarm) logs feature

[GitBox]

wu-sheng commented on issue #450: [Collector] Provide event(including alarm) 
logs feature
URL: 
https://github.com/apache/incubator-skywalking/issues/450#issuecomment-356831047
 
 
   Alerting based on response time and success rate will be provided in 5.0 . 
Almost codes are done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #451: [Collector] Limit the amount of Elastic Search stored

[GitBox]

wu-sheng closed issue #451: [Collector] Limit the amount of Elastic Search 
stored
URL: https://github.com/apache/incubator-skywalking/issues/451
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wolfelven opened a new issue #740: maven error

[GitBox]

wolfelven opened a new issue #740: maven error
URL: https://github.com/apache/incubator-skywalking/issues/740
 
 
   [ERROR] Failed to execute goal on project client-component: Could not 
resolve dependencies for project 
org.apache.skywalking:client-component:jar:5.0.0-alpha: Failure to find 
org.apache.skywalking:apm-network:jar:5.0.0-alpha in 
https://repo.maven.apache.org/maven2 was cached in the local repository, 
resolution will not be reattempted until the update interval of central has 
elapsed or updates are forced -> [Help 1]
   When I execute mvn compile -Dmaven.test.skip=true in apm-collector?terminal 
shows this error


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible

[GitBox]

ascrutae commented on a change in pull request #737: Remove OJDBC and resin 
artifacts from ci-dependencies driectory as they as not Apache license 
compatible
URL: 
https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405
 
 

 ##
 File path: pom.xml
 ##
 @@ -318,4 +278,89 @@
 
 
 
+
+
+
+
+
+install-ojdbc
+
+
+
${basedir}/ci-dependencies/ojdbc14-10.2.0.4.0.jar
+
+
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.6.0
+
+
+install-ojdbc
+false
+process-resources
+
+exec
+
+
+mvn
+
+
install:install-file
+
-Dfile=ojdbc14-10.2.0.4.0.jar
+
-DgroupId=com.oracle
+
-DartifactId=ojdbc14
+
-Dversion=10.2.0.4.0
+-Dpackaging=jar
+
+
${project.basedir}/ci-dependencies
+
+
+
+
+
+
+
+
+
+install-resin
 
 Review comment:
   I think the `resin-3` plugin should be removed too. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #739: [Agent] Support the version 9.4.x of postgresql jdbc driver

[GitBox]

coveralls commented on issue #739: [Agent] Support the version 9.4.x of 
postgresql jdbc driver
URL: 
https://github.com/apache/incubator-skywalking/pull/739#issuecomment-356818949
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14996693/badge)](https://coveralls.io/builds/14996693)
   
   Coverage remained the same at 22.266% when pulling 
**4223d22028be49787d99669382facfb72d5d5b65 on 
ascrutae:feature/support-postgresql-9.x** into 
**6e1ac504f21cb8248a863c433c26357e64f05650 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735

[GitBox]

coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735
URL: 
https://github.com/apache/incubator-skywalking/pull/738#issuecomment-356800821
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14995747/badge)](https://coveralls.io/builds/14995747)
   
   Coverage remained the same at 22.266% when pulling 
**8854921f9e23650e4dcc185eefe16da6136bf6f6 on YunaiV:master-5.0** into 
**6e1ac504f21cb8248a863c433c26357e64f05650 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on issue #738: Concurrency conflicts in Spring plugin #735

[GitBox]

ascrutae commented on issue #738: Concurrency conflicts in Spring plugin #735
URL: 
https://github.com/apache/incubator-skywalking/pull/738#issuecomment-356842920
 
 
   I think the `NativeWebRequest` object should be remove too,


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #736: Update README.md

[GitBox]

wu-sheng opened a new pull request #736: Update README.md
URL: https://github.com/apache/incubator-skywalking/pull/736
 
 
   The coverage didn't need to show. Because we are using many integration test 
tech, rather than test cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #736: Update README.md

[GitBox]

coveralls commented on issue #736: Update README.md
URL: 
https://github.com/apache/incubator-skywalking/pull/736#issuecomment-356548005
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14980646/badge)](https://coveralls.io/builds/14980646)
   
   Coverage remained the same at 22.266% when pulling 
**a0fba78f2a29a6d7a80cb83464468d3600e8bfd8 on tweeter** into 
**1e117cf7191a3075fa160d72e6b6290339fbc714 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #736: Update README.md

[GitBox]

coveralls commented on issue #736: Update README.md
URL: 
https://github.com/apache/incubator-skywalking/pull/736#issuecomment-356547910
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14980639/badge)](https://coveralls.io/builds/14980639)
   
   Coverage remained the same at 22.266% when pulling 
**a0fba78f2a29a6d7a80cb83464468d3600e8bfd8 on tweeter** into 
**1e117cf7191a3075fa160d72e6b6290339fbc714 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

[GitBox]

wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of 
postgresql driver
URL: https://github.com/apache/incubator-skywalking/pull/743
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/MultiClassNameMatch.java
 
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/MultiClassNameMatch.java
similarity index 91%
rename from 
apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/MultiClassNameMatch.java
rename to 
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/MultiClassNameMatch.java
index 66b2e8840..6453facdf 100644
--- 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/MultiClassNameMatch.java
+++ 
b/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/MultiClassNameMatch.java
@@ -17,14 +17,12 @@
  */
 
 
-package org.apache.skywalking.apm.plugin.jdbc.mysql.define;
+package org.apache.skywalking.apm.agent.core.plugin.match;
 
 import java.util.Arrays;
 import java.util.List;
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
-import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
-import org.apache.skywalking.apm.agent.core.plugin.match.IndirectMatch;
 
 import static net.bytebuddy.matcher.ElementMatchers.named;
 
diff --git 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
index e8605a35d..4afeb7f0c 100644
--- 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
+++ 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/CallableInstrumentation.java
@@ -27,7 +27,7 @@
 import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
 
 import static net.bytebuddy.matcher.ElementMatchers.named;
-import static 
org.apache.skywalking.apm.plugin.jdbc.mysql.define.MultiClassNameMatch.byMultiClassMatch;
+import static 
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
 
 /**
  * {@link CallableInstrumentation} define that the mysql-2.x plugin intercepts 
the following methods in the {@link
diff --git 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
index 27b38e174..f17d3da04 100644
--- 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
+++ 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/DriverInstrumentation.java
@@ -22,7 +22,7 @@
 import 
org.apache.skywalking.apm.plugin.jdbc.define.AbstractDriverInstrumentation;
 import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
 
-import static 
org.apache.skywalking.apm.plugin.jdbc.mysql.define.MultiClassNameMatch.byMultiClassMatch;
+import static 
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
 
 /**
  * {@link DriverInstrumentation} presents that skywalking intercepts {@link 
com.mysql.jdbc.Driver}.
diff --git 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
index 512b0c8ee..6c4860176 100644
--- 
a/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
+++ 
b/apm-sniffer/apm-sdk-plugin/mysql-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/mysql/define/Mysql5xConnectionInstrumentation.java
@@ -21,7 +21,7 @@
 
 import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch;
 
-import static 
org.apache.skywalking.apm.plugin.jdbc.mysql.define.MultiClassNameMatch.byMultiClassMatch;
+import static 
org.apache.skywalking.apm.agent.core.plugin.match.MultiClassNameMatch.byMultiClassMatch;
 
 /**
  * {@link 

[GitHub] ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735

[GitBox]

ascrutae commented on a change in pull request #738: Concurrency conflicts in 
Spring plugin #735
URL: 
https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923152
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/InvokeHandlerMethodInterceptor.java
 ##
 @@ -37,11 +38,13 @@ public void beforeMethod(EnhancedInstance objInst, Method 
method, Object[] allAr
 @Override
 public Object afterMethod(EnhancedInstance objInst, Method method, 
Object[] allArguments, Class[] argumentsTypes,
 Object ret) throws Throwable {
+if (allArguments[2] instanceof EnhancedInstance) {
 
 Review comment:
   I think that you should add some comment so that anyone can understand it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #738: Concurrency conflicts in Spring plugin #735

[GitBox]

ascrutae commented on a change in pull request #738: Concurrency conflicts in 
Spring plugin #735
URL: 
https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923141
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInteceptor.java
 ##
 @@ -80,6 +81,8 @@ public Object afterMethod(EnhancedInstance objInst, Method 
method, Object[] allA
 Tags.STATUS_CODE.set(span, Integer.toString(response.getStatus()));
 }
 ContextManager.stopSpan();
+
+
((EnhanceRequireObjectCache)objInst.getSkyWalkingDynamicField()).setNativeWebRequest(null);
 
 Review comment:
   I think that you should add some comment so that anyone can understand it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #732: Adjust ui-query protocol

[GitBox]

coveralls commented on issue #732: Adjust ui-query protocol
URL: 
https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356901818
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15001040/badge)](https://coveralls.io/builds/15001040)
   
   Coverage decreased (-0.08%) to 22.266% when pulling 
**eaef6f106c45d362bf63ca3fb2712da915085d4b on fix/graphql/node-nullable** into 
**af2c1b979fe025603dc65d7e2a2dbdea8005ede8 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

[GitBox]

coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of 
postgresql driver
URL: 
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356863298
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14998949/badge)](https://coveralls.io/builds/14998949)
   
   Coverage remained the same at 22.266% when pulling 
**97b577864f3145046b791ab41feeba009a22eab3 on 
ascrutae:support/postgresql-jdbc** into 
**3613691105c3e0929ed812d9ddee8eb7cb5be6b5 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

[GitBox]

ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of 
postgresql driver
URL: 
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356865310
 
 
   Done!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #741: Protect the background processes.

[GitBox]

wu-sheng opened a new pull request #741: Protect the background processes.
URL: https://github.com/apache/incubator-skywalking/pull/741
 
 
   There is an important feature of `ScheduledExecutorService`. The timer could 
be suppressed with an exception in `run()`.
   ```
   encounters an exception, subsequent executions are suppressed.
   ```
   
   I fix this by adding a new `RunnableWithExceptionProtection`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

[GitBox]

coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of 
postgresql driver
URL: 
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356879914
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14999785/badge)](https://coveralls.io/builds/14999785)
   
   Coverage remained the same at 22.266% when pulling 
**c6e593f6f40fee4501675893c7102361c2e64f39 on 
ascrutae:support/postgresql-jdbc** into 
**3613691105c3e0929ed812d9ddee8eb7cb5be6b5 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] 237121592 opened a new issue #742: compile FAILURE

[GitBox]

237121592 opened a new issue #742: compile FAILURE
URL: https://github.com/apache/incubator-skywalking/issues/742
 
 
   Please answer these questions before submitting your issue.
   
   ### What version of sky-walking are you using?
   5.0.0-alpha
   
   ### What version of your OS?
   windows7
   
   ### What version of your JRE?
   jre1.8.0_144
   ### What company or project?
   incubator-skywalking
   
   
   ### What did you do?
   If possible, provide a way for reproducing the error. e.g. demo application, 
component version.
   I cloned the incubator-skywalking project on GitHub, but when I compile, 
IntelliJ IDEA Maven plug-in executes MVN compile -Dmaven.test.skip=true.
   There will be an exception as follows
   
   "C:\Program Files (x86)\Java\jdk1.8.0_144\bin\java" 
-Dmaven.multiModuleProjectDirectory=D:\incubator-skywalking 
-Dmaven.home=E:\apache-maven-3.3.9 
-Dclassworlds.conf=E:\apache-maven-3.3.9\bin\m2.conf "-javaagent:E:\Program 
Files\JetBrains\IntelliJ IDEA 2017.2.4\lib\idea_rt.jar=35263:E:\Program 
Files\JetBrains\IntelliJ IDEA 2017.2.4\bin" -Dfile.encoding=UTF-8 -classpath 
E:\apache-maven-3.3.9\boot\plexus-classworlds-2.5.2.jar 
org.codehaus.classworlds.Launcher -Didea.version=2017.2.4 compile 
-Dmaven.test.skip=true
   [INFO] Scanning for projects...
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-util:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-datacarrier:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-commons:pom:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-agent:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-agent-core:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-dubbo-plugin:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-jdbc-commons:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 'build.plugins.plugin.version' for 
org.apache.maven.plugins:maven-deploy-plugin is missing. @ 
org.apache.skywalking:apm-jdbc-commons:[unknown-version], 
D:\incubator-skywalking\apm-sniffer\apm-sdk-plugin\jdbc-commons\pom.xml, line 
49, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-httpClient-4.x-plugin:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin com.spotify:docker-maven-plugin @ 
org.apache.skywalking:apm:5.0.0-alpha, D:\incubator-skywalking\pom.xml, line 
287, column 21
   [WARNING] 
   [WARNING] Some problems were encountered while building the effective model 
for org.apache.skywalking:apm-jedis-2.x-plugin:jar:5.0.0-alpha
   [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but 
found duplicate declaration of plugin 

[GitHub] coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of postgresql driver

[GitBox]

coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of 
postgresql driver
URL: 
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356868493
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14999179/badge)](https://coveralls.io/builds/14999179)
   
   Coverage remained the same at 22.266% when pulling 
**95cf5ac7a67cd9be9e11d23157ae626d9fcdee5e on 
ascrutae:support/postgresql-jdbc** into 
**3613691105c3e0929ed812d9ddee8eb7cb5be6b5 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

[GitBox]

wu-sheng commented on issue #732: Make the nodes of Topology nullable. And 
elements in it are not null.
URL: 
https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356858565
 
 
   Make the user node as an extend of Node, rather then an attribute of 
ApplicationNode.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services