coveralls commented on issue #727: Finish the proto TODO list
URL:
https://github.com/apache/incubator-skywalking/pull/727#issuecomment-355436138
[![Coverage
Status](https://coveralls.io/builds/14908998/badge)](https://coveralls.io/builds/14908998)
Coverage increased (+0.1%) to
wolfelven opened a new issue #89: skywalking-ui can't open
URL: https://github.com/apache/incubator-skywalking-ui/issues/89
According to the README.md, I download
https://github.com/apache/incubator-skywalking-ui/releases/v3.2.6. when I run
startup.sh,the commond shows:
Starting web
wolfelven commented on issue #88: ???ui??
URL:
https://github.com/apache/incubator-skywalking-ui/issues/88#issuecomment-355451485
release v3.2.6?tar.gz?zip?
This is an automated message from the Apache Git
wolfelven commented on issue #89: skywalking-ui can't open
URL:
https://github.com/apache/incubator-skywalking-ui/issues/89#issuecomment-355457377
sorry, my /logs is empty.
By the way, I only startup the web-ui, there is no skywalking-agent and
collector.
wu-sheng commented on issue #89: skywalking-ui can't open
URL:
https://github.com/apache/incubator-skywalking-ui/issues/89#issuecomment-355458234
I think you should check you JRE(1.8 requirement). And you can try to run
the commands(in .bat) line by line by yourself, in order to find what
ascrutae opened a new pull request #729: [Agent] fix jetty client doesn't work
in after version 9.1
URL: https://github.com/apache/incubator-skywalking/pull/729
This is an automated message from the Apache Git Service.
To
wu-sheng closed pull request #728: [Agent] fix the spring plugin doesn't work
URL: https://github.com/apache/incubator-skywalking/pull/728
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
coveralls commented on issue #727: Finish the proto TODO list
URL:
https://github.com/apache/incubator-skywalking/pull/727#issuecomment-355483852
[![Coverage
Status](https://coveralls.io/builds/14912149/badge)](https://coveralls.io/builds/14912149)
Coverage increased (+0.1%) to
coveralls commented on issue #670: [Agent] Provide plugins for Apache
httpcomponent AsyncClient 4.1 #588
URL:
https://github.com/apache/incubator-skywalking/pull/670#issuecomment-355455861
[![Coverage
ascrutae opened a new pull request #728: [Agent] fix the spring plugin doesn't
work
URL: https://github.com/apache/incubator-skywalking/pull/728
This is an automated message from the Apache Git Service.
To respond to the
coveralls commented on issue #730: Support collector service instrumentation
URL:
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355756686
[![Coverage
Status](https://coveralls.io/builds/14930736/badge)](https://coveralls.io/builds/14930736)
Coverage
WangHouLing commented on issue #698: Can I multiple agents on one box?
URL:
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353537676
@wu-sheng I'm sorry to give you a reply so late!
zone1511 has already expressed what I mean :)
li-ya closed issue #596: ManagedChannel isShutdown() isTerminated() ?
URL: https://github.com/apache/incubator-skywalking/issues/596
This is an automated message from the Apache Git Service.
To respond to the message,
li-ya commented on issue #596: ManagedChannel isShutdown() isTerminated() ?
URL:
https://github.com/apache/incubator-skywalking/issues/596#issuecomment-353546408
I can not reproduce the problem in my system,so I close the issure
WangHouLing commented on issue #698: Can I multiple agents on one box?
URL:
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353537702
@wu-sheng I'm sorry to give you a reply so late!
zone1511 has already expressed what I mean :)
zone1511 commented on issue #698: Can I multiple agents on one box?
URL:
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353536088
he means in single os, running multiple application which want to monitor by
the skywalking agent. Any way to specify the agent
zone1511 commented on issue #698: [Agent]Can we config the same agent
jar/folder in different applications?
URL:
https://github.com/apache/incubator-skywalking/issues/698#issuecomment-353546540
Hi PMC,
So the agent will read the config file related to its absolute location?
In this
jjtyro opened a new pull request #701: [Agent-Plugin] Add support to
MysqlDataSource
URL: https://github.com/apache/incubator-skywalking/pull/701
MysqlDataSource use com.mysql.jdbc.NonRegisteringDriver?not
com.mysql.jdbc.Driver.
Add it to Agent's mysql-5.x-plugin. #699
jjtyro commented on issue #699: MySQL Plugin not support application using
MysqlDataSource
URL:
https://github.com/apache/incubator-skywalking/issues/699#issuecomment-353727775
@wu-sheng A little bit of code change?a pull request has been sent.
wu-sheng commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL:
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353729341
@jjtyro This pull request seems good enough, but you have a conflict. Please
resolve it first.
coveralls commented on issue #702: [Agent] Support the async function of
okhttp plugin
URL:
https://github.com/apache/incubator-skywalking/pull/702#issuecomment-353772081
[![Coverage
Status](https://coveralls.io/builds/14791262/badge)](https://coveralls.io/builds/14791262)
ascrutae opened a new pull request #702: support the async function of okhttp
plugin
URL: https://github.com/apache/incubator-skywalking/pull/702
The okhttp plugin doesn't support the async function. This PR support the
async function of the plugin
wu-sheng opened a new pull request #703: Prepare for ui-query GraphQL protocol
URL: https://github.com/apache/incubator-skywalking/pull/703
1. Move `apm-network` module under the new root module `apm-protocol`.
1. Add `apm-ui-query` under the `apm-protocol` module.
wu-sheng closed pull request #702: [Agent] Support the async function of
okhttp plugin
URL: https://github.com/apache/incubator-skywalking/pull/702
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
coveralls commented on issue #703: Prepare for ui-query GraphQL protocol
URL:
https://github.com/apache/incubator-skywalking/pull/703#issuecomment-353815152
[![Coverage
Status](https://coveralls.io/builds/14794961/badge)](https://coveralls.io/builds/14794961)
Coverage remained
ascrutae opened a new pull request #704: [Agent] Unsupport the async function
of jetty client plugin
URL: https://github.com/apache/incubator-skywalking/pull/704
The async function of jetty client doesn't work. Remove this function
temporarily.
ascrutae closed pull request #703: Prepare for ui-query GraphQL protocol
URL: https://github.com/apache/incubator-skywalking/pull/703
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng closed pull request #704: [Agent] Unsupport the async function of
jetty client plugin
URL: https://github.com/apache/incubator-skywalking/pull/704
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
coveralls commented on issue #704: [Agent] Unsupport the async function of
jetty client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/704#issuecomment-353827968
[![Coverage
Status](https://coveralls.io/builds/14795374/badge)](https://coveralls.io/builds/14795374)
wu-sheng commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL:
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353835124
@jjtyro Thanks for you helps.
This is an automated message
jjtyro commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL:
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353835231
@wu-sheng no tks!
This is an automated message from the
wu-sheng commented on issue #555: ofbiz??agent??
URL:
https://github.com/apache/incubator-skywalking/issues/555#issuecomment-353840446
@yeshm #706 helps to solve this by skipping the can't resolved type.
This is an
wu-sheng closed issue #578: [Agent] drools
URL: https://github.com/apache/incubator-skywalking/issues/578
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
wu-sheng commented on issue #578: [Agent] drools
URL:
https://github.com/apache/incubator-skywalking/issues/578#issuecomment-353840423
@jaketyao #706 helps to solve this by skipping the can't resolved type.
This is an
wu-sheng closed issue #638: [Vote][Discussion]New collector/ui API practices
URL: https://github.com/apache/incubator-skywalking/issues/638
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on issue #638: [Vote][Discussion]New collector/ui API
practices
URL:
https://github.com/apache/incubator-skywalking/issues/638#issuecomment-353842583
Received @peng-yongsheng and @hanahmily feedbacks. We are going to GraphQL
to implement these APIs.
wengangJi opened a new issue #705: mvn compile error
URL: https://github.com/apache/incubator-skywalking/issues/705
![Uploading image.png?]()
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng closed pull request #701: [Agent-Plugin] Add support to MysqlDataSource
URL: https://github.com/apache/incubator-skywalking/pull/701
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
coveralls commented on issue #701: [Agent-Plugin] Add support to MysqlDataSource
URL:
https://github.com/apache/incubator-skywalking/pull/701#issuecomment-353834893
[![Coverage
Status](https://coveralls.io/builds/14795674/badge)](https://coveralls.io/builds/14795674)
Coverage
wu-sheng closed issue #705: mvn compile error
URL: https://github.com/apache/incubator-skywalking/issues/705
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
wu-sheng commented on issue #705: mvn compile error
URL:
https://github.com/apache/incubator-skywalking/issues/705#issuecomment-353835509
@wengangJi This is not an error triggered by SkyWalking project. This
depends on Google gRPC/Protobuf tools: `protoc`. So if you have any problem to
wu-sheng opened a new pull request #706: Add a ProtectiveShieldMatcher to
prevent match exception.
URL: https://github.com/apache/incubator-skywalking/pull/706
In same cases, some frameworks and libraries use some binary codes tech
too. From the community feedback, some of
them have
coveralls commented on issue #707: Init ui-protocol
URL:
https://github.com/apache/incubator-skywalking/pull/707#issuecomment-353846882
[![Coverage
Status](https://coveralls.io/builds/14796397/badge)](https://coveralls.io/builds/14796397)
Coverage remained the same at 23.005%
ascrutae closed pull request #706: [Agent]Add a ProtectiveShieldMatcher to
prevent match exception.
URL: https://github.com/apache/incubator-skywalking/pull/706
This is an automated message from the Apache Git Service.
To
ascrutae commented on issue #706: [Agent]Add a ProtectiveShieldMatcher to
prevent match exception.
URL:
https://github.com/apache/incubator-skywalking/pull/706#issuecomment-353852416
This function is tested. Here is the [auto_test
coveralls commented on issue #704: [Agent] Unsupport the async function of
jetty client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/704#issuecomment-353825542
[![Coverage
Status](https://coveralls.io/builds/14795267/badge)](https://coveralls.io/builds/14795267)
ascrutae commented on issue #704: [Agent] Unsupport the async function of jetty
client plugin
URL:
https://github.com/apache/incubator-skywalking/pull/704#issuecomment-353825749
Yeah. the interceptor class is incorrect since we changed the package to
`apache`
wu-sheng opened a new pull request #707: Init ui-protocol
URL: https://github.com/apache/incubator-skywalking/pull/707
I add 7 `.graphqls` files to define the protocol between UI and collector as
we discussed in #638 . The scripts are defined by functions.
- common
Include common
coveralls commented on issue #730: Support collector service instrumentation
URL:
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355827374
[![Coverage
Status](https://coveralls.io/builds/14937704/badge)](https://coveralls.io/builds/14937704)
Coverage
coveralls commented on issue #732: Make the nodes of Topology nullable. And
elements in it are not null.
URL:
https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356176479
[![Coverage
wu-sheng opened a new pull request #732: Make the nodes of Topology nullable.
And elements in it are not null.
URL: https://github.com/apache/incubator-skywalking/pull/732
This is an automated message from the Apache Git
wu-sheng commented on issue #735: Concurrency conflicts in Spring plugin
URL:
https://github.com/apache/incubator-skywalking/issues/735#issuecomment-356291663
Wait for @YunaiV 's pull request.
This is an automated message
clevertension commented on issue #659: [Agent] Spring Bean Plugin
URL:
https://github.com/apache/incubator-skywalking/issues/659#issuecomment-355870454
sorry, i can't finish this task before spring festival, so anyone who have
the time can take this task now
wu-sheng commented on issue #659: [Agent] Spring Bean Plugin
URL:
https://github.com/apache/incubator-skywalking/issues/659#issuecomment-355870818
@ascrutae I hope you have the time to provide this plugin.
This is an
ascrutae commented on issue #659: [Agent] Spring Bean Plugin
URL:
https://github.com/apache/incubator-skywalking/issues/659#issuecomment-355873211
OK? I got it
This is an automated message from the Apache Git Service.
To
coveralls commented on issue #730: Support collector service instrumentation
URL:
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355879558
[![Coverage
Status](https://coveralls.io/builds/14942177/badge)](https://coveralls.io/builds/14942177)
Coverage
coveralls commented on issue #730: Support collector service instrumentation
URL:
https://github.com/apache/incubator-skywalking/pull/730#issuecomment-355922069
[![Coverage
Status](https://coveralls.io/builds/14944621/badge)](https://coveralls.io/builds/14944621)
Coverage
xjr100419 opened a new issue #731: ?
URL: https://github.com/apache/incubator-skywalking/issues/731
### What version of sky-walking are you using?
v3.2.6
### What version of your OS?
window
### What version of your JRE?
java8
?? agent.config
coveralls commented on issue #670: [Agent] Provide plugins for Apache
httpcomponent AsyncClient 4.1 #588
URL:
https://github.com/apache/incubator-skywalking/pull/670#issuecomment-355894264
[![Coverage
coveralls commented on issue #670: [Agent] Provide plugins for Apache
httpcomponent AsyncClient 4.1 #588
URL:
https://github.com/apache/incubator-skywalking/pull/670#issuecomment-355894151
[![Coverage
ascrutae commented on a change in pull request #737: Remove OJDBC and resin
artifacts from ci-dependencies driectory as they as not Apache license
compatible
URL:
https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405
##
File path: pom.xml
##
@@
wu-sheng closed issue #584: Add instrument module in collector
URL: https://github.com/apache/incubator-skywalking/issues/584
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wu-sheng commented on issue #390: [Collector-QUERY-APIs] Provide Collector
APIKit for metrics and traces, maybe alarms
URL:
https://github.com/apache/incubator-skywalking/issues/390#issuecomment-356830889
Designed and provided in 5.0. Check
wu-sheng closed issue #390: [Collector-QUERY-APIs] Provide Collector APIKit for
metrics and traces, maybe alarms
URL: https://github.com/apache/incubator-skywalking/issues/390
This is an automated message from the Apache
wu-sheng closed issue #450: [Collector] Provide event(including alarm) logs
feature
URL: https://github.com/apache/incubator-skywalking/issues/450
This is an automated message from the Apache Git Service.
To respond to the
lytscu commented on issue #437: [Agent] ServiceComb Plugin
URL:
https://github.com/apache/incubator-skywalking/issues/437#issuecomment-356837774
Ok ,I will make contact with Teacher Jiang.
This is an automated message from
wu-sheng commented on issue #584: Add instrument module in collector
URL:
https://github.com/apache/incubator-skywalking/issues/584#issuecomment-356828288
I spend a week to provide the first instrument in #730 .
This is an
wu-sheng commented on issue #660: [UI] Feature of dashboard
URL:
https://github.com/apache/incubator-skywalking/issues/660#issuecomment-356828091
I am closing this. The UI features are developing, and most are finished.
Look forward @hanahmily to share us the exited 5.0 UI.
wu-sheng closed issue #660: [UI] Feature of dashboard
URL: https://github.com/apache/incubator-skywalking/issues/660
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
coveralls commented on issue #739: [Agent] Support the version 9.4.x of
postgresql jdbc driver
URL:
https://github.com/apache/incubator-skywalking/pull/739#issuecomment-356818441
[![Coverage
Status](https://coveralls.io/builds/14996669/badge)](https://coveralls.io/builds/14996669)
wu-sheng commented on issue #500: webui ?
URL:
https://github.com/apache/incubator-skywalking/issues/500#issuecomment-356830533
Alarm features will be provided in 5.0 . Multi-tenant is not an expected
feature in our milestone.
wu-sheng commented on issue #496: webui ?
URL:
https://github.com/apache/incubator-skywalking/issues/496#issuecomment-356830520
Alarm features will be provided in 5.0 . Multi-tenant is not an expected
feature in our milestone.
wu-sheng closed issue #496: webui ?
URL: https://github.com/apache/incubator-skywalking/issues/496
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
wu-sheng closed issue #500: webui ?
URL: https://github.com/apache/incubator-skywalking/issues/500
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
wu-sheng closed issue #740: maven error
URL: https://github.com/apache/incubator-skywalking/issues/740
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
wu-sheng commented on issue #740: maven error
URL:
https://github.com/apache/incubator-skywalking/issues/740#issuecomment-356841151
First of all, CI passed, means the compile status is health. Then we didn't
expect you to compile a single module of the project. See
ascrutae opened a new pull request #739: [Agent] Support the version 9.4.x of
postgresql jdbc driver
URL: https://github.com/apache/incubator-skywalking/pull/739
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #589: [Agent] Provide plugin for Apache
Httpcomponent httpclient 4.4 and 4.5
URL:
https://github.com/apache/incubator-skywalking/issues/589#issuecomment-356830003
Based on [test
wu-sheng commented on issue #568: [Collector]
es??es
URL:
https://github.com/apache/incubator-skywalking/issues/568#issuecomment-356830170
Closing this. Already supported.
This is
wu-sheng commented on issue #450: [Collector] Provide event(including alarm)
logs feature
URL:
https://github.com/apache/incubator-skywalking/issues/450#issuecomment-356831047
Alerting based on response time and success rate will be provided in 5.0 .
Almost codes are done.
wu-sheng closed issue #451: [Collector] Limit the amount of Elastic Search
stored
URL: https://github.com/apache/incubator-skywalking/issues/451
This is an automated message from the Apache Git Service.
To respond to the
wolfelven opened a new issue #740: maven error
URL: https://github.com/apache/incubator-skywalking/issues/740
[ERROR] Failed to execute goal on project client-component: Could not
resolve dependencies for project
org.apache.skywalking:client-component:jar:5.0.0-alpha: Failure to find
ascrutae commented on a change in pull request #737: Remove OJDBC and resin
artifacts from ci-dependencies driectory as they as not Apache license
compatible
URL:
https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405
##
File path: pom.xml
##
@@
coveralls commented on issue #739: [Agent] Support the version 9.4.x of
postgresql jdbc driver
URL:
https://github.com/apache/incubator-skywalking/pull/739#issuecomment-356818949
[![Coverage
Status](https://coveralls.io/builds/14996693/badge)](https://coveralls.io/builds/14996693)
coveralls commented on issue #738: Concurrency conflicts in Spring plugin #735
URL:
https://github.com/apache/incubator-skywalking/pull/738#issuecomment-356800821
[![Coverage
Status](https://coveralls.io/builds/14995747/badge)](https://coveralls.io/builds/14995747)
Coverage
ascrutae commented on issue #738: Concurrency conflicts in Spring plugin #735
URL:
https://github.com/apache/incubator-skywalking/pull/738#issuecomment-356842920
I think the `NativeWebRequest` object should be remove too,
wu-sheng opened a new pull request #736: Update README.md
URL: https://github.com/apache/incubator-skywalking/pull/736
The coverage didn't need to show. Because we are using many integration test
tech, rather than test cases.
coveralls commented on issue #736: Update README.md
URL:
https://github.com/apache/incubator-skywalking/pull/736#issuecomment-356548005
[![Coverage
Status](https://coveralls.io/builds/14980646/badge)](https://coveralls.io/builds/14980646)
Coverage remained the same at 22.266%
coveralls commented on issue #736: Update README.md
URL:
https://github.com/apache/incubator-skywalking/pull/736#issuecomment-356547910
[![Coverage
Status](https://coveralls.io/builds/14980639/badge)](https://coveralls.io/builds/14980639)
Coverage remained the same at 22.266%
wu-sheng closed pull request #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of
postgresql driver
URL: https://github.com/apache/incubator-skywalking/pull/743
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
ascrutae commented on a change in pull request #738: Concurrency conflicts in
Spring plugin #735
URL:
https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923152
##
File path:
ascrutae commented on a change in pull request #738: Concurrency conflicts in
Spring plugin #735
URL:
https://github.com/apache/incubator-skywalking/pull/738#discussion_r160923141
##
File path:
coveralls commented on issue #732: Adjust ui-query protocol
URL:
https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356901818
[![Coverage
Status](https://coveralls.io/builds/15001040/badge)](https://coveralls.io/builds/15001040)
Coverage decreased (-0.08%) to
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of
postgresql driver
URL:
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356863298
[![Coverage
Status](https://coveralls.io/builds/14998949/badge)](https://coveralls.io/builds/14998949)
ascrutae commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of
postgresql driver
URL:
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356865310
Done!
This is an automated message from the
wu-sheng opened a new pull request #741: Protect the background processes.
URL: https://github.com/apache/incubator-skywalking/pull/741
There is an important feature of `ScheduledExecutorService`. The timer could
be suppressed with an exception in `run()`.
```
encounters an
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of
postgresql driver
URL:
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356879914
[![Coverage
Status](https://coveralls.io/builds/14999785/badge)](https://coveralls.io/builds/14999785)
237121592 opened a new issue #742: compile FAILURE
URL: https://github.com/apache/incubator-skywalking/issues/742
Please answer these questions before submitting your issue.
### What version of sky-walking are you using?
5.0.0-alpha
### What version of your OS?
windows7
coveralls commented on issue #743: [Agent] Support jdbc4, jdbc3 and jdbc42 of
postgresql driver
URL:
https://github.com/apache/incubator-skywalking/pull/743#issuecomment-356868493
[![Coverage
Status](https://coveralls.io/builds/14999179/badge)](https://coveralls.io/builds/14999179)
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And
elements in it are not null.
URL:
https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356858565
Make the user node as an extend of Node, rather then an attribute of
ApplicationNode.
101 - 200 of 1702 matches
Mail list logo