[GitHub] wu-sheng commented on issue #967: Wengang ji branch

wu-sheng commented on issue #967: Wengang ji branch URL: https://github.com/apache/incubator-skywalking/pull/967#issuecomment-374807235 I am going to close this pull request. Please start a new if you are ready. FYI @apache/skywalking-committers --

[GitHub] wu-sheng commented on issue #969: fix #939

wu-sheng commented on issue #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374807391 @peng-yongsheng Could you review this too? This is an automated message from the Apache Git Servic

[GitHub] coveralls commented on issue #969: fix #939

coveralls commented on issue #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969#issuecomment-374694660 [](https://coveralls.io/builds/16088325) Coverage remained the same at 19.191% when pulli

[GitHub] ascrutae opened a new pull request #971: Upgrade netty version

ascrutae opened a new pull request #971: Upgrade netty version URL: https://github.com/apache/incubator-skywalking/pull/971 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve perf

[GitHub] ascrutae closed pull request #971: Upgrade netty version

ascrutae closed pull request #971: Upgrade netty version URL: https://github.com/apache/incubator-skywalking/pull/971 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reque

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [](https://coveralls.io/builds/16088920) Coverage in

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

wu-sheng commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374821750 FYI @hanahmily TLS has been established in core with optional setting. And you should be care of port setting, only `agent_gRP

[GitHub] wu-sheng commented on issue #968: Support TLS of gRPC between agent and server.

wu-sheng commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374821750 FYI @hanahmily TLS has been established in core with optional setting. And you should take care of port setting, only `agent_g

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [](https://coveralls.io/builds/16089097) Coverage in

[GitHub] wendal commented on issue #443: Which companies are using SkyWalking

wendal commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-374826028 广州文尔软件科技有限公司 https://www.site0.cn 当前使用的版本号 3.2.6 This is an automated

[GitHub] chidaodezhongsheng commented on issue #443: Which companies are using SkyWalking

chidaodezhongsheng commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-374827519 当当网 [http://www.dangdang.com/](url) 已在生产环境使用，并自研PHP探针，当前使用的版本号为3.2.6 --

[GitHub] peng-yongsheng closed issue #939: [collector] '/ by zero' error in 5.0.0-alpha

peng-yongsheng closed issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] peng-yongsheng closed pull request #969: fix #939

peng-yongsheng closed pull request #969: fix #939 URL: https://github.com/apache/incubator-skywalking/pull/969 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha

wu-sheng commented on issue #939: [collector] '/ by zero' error in 5.0.0-alpha URL: https://github.com/apache/incubator-skywalking/issues/939#issuecomment-374846516 @cyberdak Yes, I am looking forward #773 too. @peng-yongsheng is still working on test tools. -

[GitHub] wu-sheng closed issue #930: Divide 0 when the whole application cluster fails

wu-sheng closed issue #930: Divide 0 when the whole application cluster fails URL: https://github.com/apache/incubator-skywalking/issues/930 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #930: Divide 0 when the whole application cluster fails

wu-sheng commented on issue #930: Divide 0 when the whole application cluster fails URL: https://github.com/apache/incubator-skywalking/issues/930#issuecomment-374846575 Same as #939 . Fixed. Closing. This is an automated me

[GitHub] wu-sheng commented on issue #956: Support ES type/table namespace feature

wu-sheng commented on issue #956: Support ES type/table namespace feature URL: https://github.com/apache/incubator-skywalking/pull/956#issuecomment-374865461 @peng-yongsheng @ascrutae @hanahmily This feature has been provided. Please review. ---

[GitHub] wu-sheng commented on issue #956: Support ES type/table namespace feature

wu-sheng commented on issue #956: Support ES type/table namespace feature URL: https://github.com/apache/incubator-skywalking/pull/956#issuecomment-374865754 I changed basic `ElasticSearchClient`, and isolate all codes to access type/table name directly. Add `#formatTableName` name to add

[GitHub] coveralls commented on issue #956: Support ES type/table namespace feature

coveralls commented on issue #956: Support ES type/table namespace feature URL: https://github.com/apache/incubator-skywalking/pull/956#issuecomment-373734453 [](https://coveralls.io/builds/16092090) Coverage remained

[GitHub] xyydcoo opened a new issue #972: Jedis error

xyydcoo opened a new issue #972: Jedis error URL: https://github.com/apache/incubator-skywalking/issues/972 log: ERROR 2018-03-21 09:54:57 SkyWalkingAgent : Enhance class redis.clients.jedis.JedisCluster error. org.apache.skywalking.apm.agent.core.plugin.PluginException: Can't creat

[GitHub] xyydcoo opened a new issue #973: Topology show error

xyydcoo opened a new issue #973: Topology show error URL: https://github.com/apache/incubator-skywalking/issues/973 Display errors, the number of instances when an application is used is shown to be 0, with multiple instances beginning to show normal and then 0. version:apache-skywa

[GitHub] archer-christ opened a new issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running

archer-christ opened a new issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running URL: https://github.com/apache/incubator-skywalking/issues/974 ___ ### Requirement or improvement When I use `TraceContext.traceId()` or logback toolkit

[GitHub] wu-sheng commented on issue #972: Jedis error

wu-sheng commented on issue #972: Jedis error URL: https://github.com/apache/incubator-skywalking/issues/972#issuecomment-374919198 @ascrutae Hi Xin, I think you should notice Jedis 2.9.0 is using in our end user. And we haven't run test cases in here: https://github.com/SkywalkingTest/ag

[GitHub] wu-sheng commented on issue #973: Topology show error

wu-sheng commented on issue #973: Topology show error URL: https://github.com/apache/incubator-skywalking/issues/973#issuecomment-374919497 @peng-yongsheng You should pay attention about this in your automatic backend test cases. @xyydcoo Please provide es data, and query in Brows

[GitHub] wu-sheng commented on issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running

wu-sheng commented on issue #974: can the TraceContext.traceId() is a real traceId when the collector is not running URL: https://github.com/apache/incubator-skywalking/issues/974#issuecomment-374920948 @archer-christ I understand your requirement, but I think it is a little hard to imp

[GitHub] ascrutae commented on issue #968: Support TLS of gRPC between agent and server.

ascrutae commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374952166 I had tested it in Linux and OSX, this feature has worked. Th

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [](https://coveralls.io/builds/16098047) Coverage in

[GitHub] ascrutae commented on issue #956: Support ES type/table namespace feature

ascrutae commented on issue #956: Support ES type/table namespace feature URL: https://github.com/apache/incubator-skywalking/pull/956#issuecomment-374976147 This feature had been tested. This is an automated message from the

[GitHub] ascrutae commented on issue #956: Support ES type/table namespace feature

ascrutae commented on issue #956: Support ES type/table namespace feature URL: https://github.com/apache/incubator-skywalking/pull/956#issuecomment-374976080 This feature had been tested. This is an automated message from the

[GitHub] wu-sheng closed pull request #956: Support ES type/table namespace feature

wu-sheng closed pull request #956: Support ES type/table namespace feature URL: https://github.com/apache/incubator-skywalking/pull/956 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] wu-sheng commented on issue #932: Support table name prefix for namespace

wu-sheng commented on issue #932: Support table name prefix for namespace URL: https://github.com/apache/incubator-skywalking/issues/932#issuecomment-375111202 Provided. This is an automated message from the Apache Git Servi

[GitHub] coveralls commented on issue #968: Support TLS of gRPC between agent and server.

coveralls commented on issue #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968#issuecomment-374619598 [](https://coveralls.io/builds/16109730) Coverage in

[GitHub] wu-sheng closed pull request #968: Support TLS of gRPC between agent and server.

wu-sheng closed pull request #968: Support TLS of gRPC between agent and server. URL: https://github.com/apache/incubator-skywalking/pull/968 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

wu-sheng commented on issue #845: add jdk-cross-thread-plugin URL: https://github.com/apache/incubator-skywalking/pull/845#issuecomment-375132498 @carlvine500 I think @ascrutae 's question is for you. Can you provide some answers? --

[GitHub] wu-sheng commented on issue #935: Support Zookeeper namespace in Collector config module

wu-sheng commented on issue #935: Support Zookeeper namespace in Collector config module URL: https://github.com/apache/incubator-skywalking/issues/935#issuecomment-375135337 Provided. This is an automated message from the A

[GitHub] wu-sheng commented on issue #936: Support TLS(optional) in gRPC transport

wu-sheng commented on issue #936: Support TLS(optional) in gRPC transport URL: https://github.com/apache/incubator-skywalking/issues/936#issuecomment-375135361 Provided. This is an automated message from the Apache Git Servic

[GitHub] wu-sheng closed issue #935: Support Zookeeper namespace in Collector config module

wu-sheng closed issue #935: Support Zookeeper namespace in Collector config module URL: https://github.com/apache/incubator-skywalking/issues/935 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] wu-sheng closed issue #936: Support TLS(optional) in gRPC transport

wu-sheng closed issue #936: Support TLS(optional) in gRPC transport URL: https://github.com/apache/incubator-skywalking/issues/936 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] wu-sheng opened a new issue #149: Add links in Topology, application, service overview.

wu-sheng opened a new issue #149: Add links in Topology, application, service overview. URL: https://github.com/apache/incubator-skywalking-ui/issues/149 1. Support click application in Topology, to show more info, and go to find how many servers in that Application. 2. Add Application,

[GitHub] wu-sheng opened a new issue #150: Optimize topology, support layout options

wu-sheng opened a new issue #150: Optimize topology, support layout options URL: https://github.com/apache/incubator-skywalking-ui/issues/150 Provide more than default layout options for end users, in order to make topology more clear. --

[GitHub] wu-sheng closed issue #951: Add namespace(lable) in sw3 propagation protocol

wu-sheng closed issue #951: Add namespace(lable) in sw3 propagation protocol URL: https://github.com/apache/incubator-skywalking/issues/951 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #951: Add namespace(lable) in sw3 propagation protocol

wu-sheng commented on issue #951: Add namespace(lable) in sw3 propagation protocol URL: https://github.com/apache/incubator-skywalking/issues/951#issuecomment-375142885 Provided. This is an automated message from the Apache

[GitHub] wu-sheng closed issue #932: Support table name prefix for namespace

wu-sheng closed issue #932: Support table name prefix for namespace URL: https://github.com/apache/incubator-skywalking/issues/932 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] carlvine500 commented on issue #443: Which companies are using SkyWalking

carlvine500 commented on issue #443: Which companies are using SkyWalking URL: https://github.com/apache/incubator-skywalking/issues/443#issuecomment-368444891 北京商云科技发展有限公司， 微商城， http://www.bizsaas.cn 苏州渠成易销网络科技有限公司，crm系统， http://www.successchannel.com -

[GitHub] wu-sheng opened a new pull request #975: Support direct server setting in agent.

wu-sheng opened a new pull request #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided

[GitHub] wu-sheng commented on issue #975: Support direct server setting in agent.

wu-sheng commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375199594 @hanahmily You can set domain name in this, I think. This is an aut

[GitHub] coveralls commented on issue #975: Support direct server setting in agent.

coveralls commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375206448 [](https://coveralls.io/builds/16115544) Coverage increase

[GitHub] wu-sheng opened a new issue #151: Place conjecture nodes outside application topology

wu-sheng opened a new issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151 Make application topology layout in high priority, then place the conjecture nodes around the topology. -

[GitHub] wu-sheng opened a new issue #976: Add total distributed calls in Overview page

wu-sheng opened a new issue #976: Add total distributed calls in Overview page URL: https://github.com/apache/incubator-skywalking/issues/976 For improving the end user experience, current overview is too static. I recommend to add a new metric, also a new backend service. The metric

[GitHub] wu-sheng closed issue #134: Add total distributed calls in Overview page

wu-sheng closed issue #134: Add total distributed calls in Overview page URL: https://github.com/apache/incubator-skywalking-ui/issues/134 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] wu-sheng commented on issue #976: Add total distributed calls in Overview page

wu-sheng commented on issue #976: Add total distributed calls in Overview page URL: https://github.com/apache/incubator-skywalking/issues/976#issuecomment-375228685 Come frome https://github.com/apache/incubator-skywalking-ui/issues/134 -

[GitHub] xyydcoo commented on issue #973: Topology show error

xyydcoo commented on issue #973: Topology show error URL: https://github.com/apache/incubator-skywalking/issues/973#issuecomment-375229445 [参数.txt](https://github.com/apache/incubator-skywalking/files/1836779/default.txt) es数据链接：https://pan.baidu.com/s/19t_L02m3iMQRzevDS8y3SQ 密码：s0

[GitHub] wu-sheng opened a new issue #977: Add calls and online time to replace tps

wu-sheng opened a new issue #977: Add calls and online time to replace tps URL: https://github.com/apache/incubator-skywalking/issues/977 For a low throughput system, tps is always 0. For improving that, I proposal to add calls and online time in those services. Just keep tps in protocol b

[GitHub] wu-sheng commented on issue #973: Topology show error

wu-sheng commented on issue #973: Topology show error URL: https://github.com/apache/incubator-skywalking/issues/973#issuecomment-375237469 FYI @hanahmily I think you may be interested in the topology based on this data. Th

[GitHub] wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question

wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770#issuecomment-375239858 This pr stays no change in near one month, and some conflicts. I am closing this pr, if you have more things to contr

[GitHub] wu-sheng closed pull request #770: Decouple JDBCURL parser logic from URLParser question

wu-sheng closed pull request #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] zone1511 opened a new issue #978: Purpose of tag method in AbstractSpan

zone1511 opened a new issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or discussion - [ ] Bug - [ ] Requ

[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan

wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375487066 why do you need gettag in span? can you provide scenario? This is a

[GitHub] zone1511 commented on issue #978: Purpose of tag method in AbstractSpan

zone1511 commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375496224 Need to pass data around before and after method invokation. Does the span a go place to store? If not, where to store the temp data

[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan

wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375498603 Yes, that depends how does your intercepted object use in thread? if no concurrency situation, you can use dynamic field to propagat

[GitHub] zone1511 commented on issue #978: Purpose of tag method in AbstractSpan

zone1511 commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375503420 Does the before and after method interceptor guarantee to run on same thread? What is the original purpose of Tag in span?

[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan

wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375510423 Yes, they are always in one thread, guarantee by Javs stack module, not by SkyWalking. But you must be careful of concurrency. For t

[GitHub] zilanghuo opened a new issue #979: get 5.x jar

zilanghuo opened a new issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979 Excuse me, how can I get 5. X version of the jar package. This is an automated message from the Apache Git Service.

[GitHub] cyberdak commented on issue #979: get 5.x jar

cyberdak commented on issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979#issuecomment-375522384 Now you need build it from source. https://github.com/apache/incubator-skywalking/blob/master/docs/cn/How-to-build-CN.md Here is the build manual.

[GitHub] zilanghuo commented on issue #979: get 5.x jar

zilanghuo commented on issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979#issuecomment-375525996 thank you! This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] wu-sheng closed issue #979: get 5.x jar

wu-sheng closed issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] wu-sheng commented on issue #979: get 5.x jar

wu-sheng commented on issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979#issuecomment-375526281 @cyberdak Thanks for pointing to right direction. @zilanghuo Apache release process is still on going, after we passed, you will have way to download

[GitHub] wu-sheng opened a new pull request #980: Fix document.

wu-sheng opened a new pull request #980: Fix document. URL: https://github.com/apache/incubator-skywalking/pull/980 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] msqiao commented on issue #940: [skywalking-ui]Request Error 500

msqiao commented on issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940#issuecomment-375526556 response message:{"timestamp":1521772932819,"status":500,"error":"Internal Server Error","exception":"com.netflix.zuul.exception.ZuulExcep

[GitHub] coveralls commented on issue #980: Fix document.

coveralls commented on issue #980: Fix document. URL: https://github.com/apache/incubator-skywalking/pull/980#issuecomment-375532066 [](https://coveralls.io/builds/16136795) Coverage remained the same at 19.215% when

[GitHub] ascrutae closed pull request #980: Fix document.

ascrutae closed pull request #980: Fix document. URL: https://github.com/apache/incubator-skywalking/pull/980 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] coveralls commented on issue #975: Support direct server setting in agent.

coveralls commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375206448 [](https://coveralls.io/builds/16137161) Coverage increase

[GitHub] ascrutae opened a new pull request #981: Add direct_servers check

ascrutae opened a new pull request #981: Add direct_servers check URL: https://github.com/apache/incubator-skywalking/pull/981 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve p

[GitHub] ascrutae closed pull request #981: Add direct_servers check

ascrutae closed pull request #981: Add direct_servers check URL: https://github.com/apache/incubator-skywalking/pull/981 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[GitHub] coveralls commented on issue #975: Support direct server setting in agent.

coveralls commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375206448 [](https://coveralls.io/builds/16139072) Coverage increase

[GitHub] wu-sheng closed pull request #975: Support direct server setting in agent.

wu-sheng closed pull request #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] wu-sheng closed issue #952: Support direct link config for gRPC uplink service

wu-sheng closed issue #952: Support direct link config for gRPC uplink service URL: https://github.com/apache/incubator-skywalking/issues/952 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] wu-sheng commented on issue #952: Support direct link config for gRPC uplink service

wu-sheng commented on issue #952: Support direct link config for gRPC uplink service URL: https://github.com/apache/incubator-skywalking/issues/952#issuecomment-375665152 Supported. This is an automated message from the Apac

[GitHub] wu-sheng opened a new pull request #152: Remove unnecessary files

wu-sheng opened a new pull request #152: Remove unnecessary files URL: https://github.com/apache/incubator-skywalking-ui/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] hanahmily closed pull request #152: Remove unnecessary files

hanahmily closed pull request #152: Remove unnecessary files URL: https://github.com/apache/incubator-skywalking-ui/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng opened a new pull request #982: Sync to fix release check

wu-sheng opened a new pull request #982: Sync to fix release check URL: https://github.com/apache/incubator-skywalking/pull/982 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] wu-sheng commented on issue #982: Sync to fix release check

wu-sheng commented on issue #982: Sync to fix release check URL: https://github.com/apache/incubator-skywalking/pull/982#issuecomment-375853613 Wait @ascrutae to fix def file reader bug, casued by header added. This is an aut

[GitHub] coveralls commented on issue #982: Sync to fix release check

coveralls commented on issue #982: Sync to fix release check URL: https://github.com/apache/incubator-skywalking/pull/982#issuecomment-375853620 [](https://coveralls.io/builds/16157214) Coverage increased (+0.01%) to

[GitHub] ascrutae opened a new pull request #983: revert code

ascrutae opened a new pull request #983: revert code URL: https://github.com/apache/incubator-skywalking/pull/983 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] wu-sheng closed pull request #983: revert code

wu-sheng closed pull request #983: revert code URL: https://github.com/apache/incubator-skywalking/pull/983 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] ascrutae opened a new pull request #984: revert code

ascrutae opened a new pull request #984: revert code URL: https://github.com/apache/incubator-skywalking/pull/984 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] wu-sheng closed pull request #984: revert code

wu-sheng closed pull request #984: revert code URL: https://github.com/apache/incubator-skywalking/pull/984 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] coveralls commented on issue #983: revert code

coveralls commented on issue #983: revert code URL: https://github.com/apache/incubator-skywalking/pull/983#issuecomment-375855963 [](https://coveralls.io/builds/16157361) Coverage decreased (-0.01%) to 19.237% when p

[GitHub] coveralls commented on issue #982: Sync to fix release check

coveralls commented on issue #982: Sync to fix release check URL: https://github.com/apache/incubator-skywalking/pull/982#issuecomment-375853620 [](https://coveralls.io/builds/16157387) Coverage remained the same at 1

[GitHub] ascrutae closed pull request #982: Sync to fix release check

ascrutae closed pull request #982: Sync to fix release check URL: https://github.com/apache/incubator-skywalking/pull/982 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] jackychee opened a new issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0

jackychee opened a new issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0 URL: https://github.com/apache/incubator-skywalking/issues/985 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] jackychee closed issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0

jackychee closed issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0 URL: https://github.com/apache/incubator-skywalking/issues/985 This is an automated message from the Apache Git Service. To respond t

[GitHub] jackychee commented on issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0

jackychee commented on issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0 URL: https://github.com/apache/incubator-skywalking/issues/985#issuecomment-375864560 aha, i found it solved. I have another solution that use ThreadLocal to keep ClientCallImpl instance temp

[GitHub] jackychee opened a new issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0

jackychee opened a new issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0 URL: https://github.com/apache/incubator-skywalking/issues/985 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] wu-sheng commented on issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0

wu-sheng commented on issue #985: grpc-1.x-plugin throw ClassCastException in gRPC-java v1.10.0 URL: https://github.com/apache/incubator-skywalking/issues/985#issuecomment-375869382 @jackychee can gou provide your solution, or send a pull request to fix for the community? FYI @ascrutae th

[GitHub] zone1511 commented on issue #978: Purpose of tag method in AbstractSpan

zone1511 commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375894697 @wu-sheng for adding runtime context for TracingContext, where should I get start from? ---

[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan

wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375901736 @zone1511 contextmanager should the entrance, add a method there. The context interface and implementations also need to change. -

[GitHub] peng-yongsheng opened a new pull request #986: Update How-to-release.md

peng-yongsheng opened a new pull request #986: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/986 Set the release version when build source release. This is an automated message from the Apac

[GitHub] coveralls commented on issue #986: Update How-to-release.md

coveralls commented on issue #986: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/986#issuecomment-375945123 [](https://coveralls.io/builds/16163536) Coverage remained the same at 19

[GitHub] wu-sheng closed pull request #986: Update How-to-release.md

wu-sheng closed pull request #986: Update How-to-release.md URL: https://github.com/apache/incubator-skywalking/pull/986 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

<    1   2   3   4   5   6   7   8   9   10   >