[GitHub] peng-yongsheng opened a new pull request #11: Add copyFrom method for complex data type.

2018-10-21 Thread GitBox
peng-yongsheng opened a new pull request #11: Add copyFrom method for complex data type. URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/11 This is an automated message from the Apache Git Service. To respo

[GitHub] wu-sheng closed pull request #11: Add copyFrom method for complex data type.

2018-10-22 Thread GitBox
wu-sheng closed pull request #11: Add copyFrom method for complex data type. URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] peng-yongsheng opened a new pull request #12: Use add data to set the values into remote data builder.

2018-10-29 Thread GitBox
peng-yongsheng opened a new pull request #12: Use add data to set the values into remote data builder. URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/12 This is an automated message from the Apache Git Ser

[GitHub] peng-yongsheng closed pull request #12: Use add data to set the values into remote data builder.

2018-10-29 Thread GitBox
peng-yongsheng closed pull request #12: Use add data to set the values into remote data builder. URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new issue #285: Refresh data when we update global calendar in topo page.

2020-04-20 Thread GitBox
Fine0830 opened a new issue #285: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/285 Refresh topo, instance, service detail data when we update global calendar in topo page. This is an automated message from t

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #286: Fix: profile span

2020-04-20 Thread GitBox
Fine0830 opened a new pull request #286: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/286 Fixes type to view profile span This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [skywalking-rocketbot-ui] Jtrust opened a new issue #287: Import and export the configuration file for the dashboard layout

2020-04-22 Thread GitBox
Jtrust opened a new issue #287: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/287 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [skywalking-rocketbot-ui] Jtrust opened a new pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-22 Thread GitBox
Jtrust opened a new pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288 Feature [#287](https://github.com/apache/skywalking-rocketbot-ui/issues/287) `https://s1.ax1x.com/2020/04/22/JUlQrd.jpg"; alt="JUlQrd.jpg" border="0" />` -

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-22 Thread GitBox
wu-sheng commented on issue #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-617798538 I prefer dashboard level import/export to be more flexible This is an automated message from the Apache

[GitHub] [skywalking-rocketbot-ui] Jtrust commented on issue #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-22 Thread GitBox
Jtrust commented on issue #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-617829775 > I prefer dashboard level import/export to be more flexible This is a good direction and I'm trying to get some ideas

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-23 Thread GitBox
Fine0830 commented on a change in pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#discussion_r413659335 ## File path: src/views/components/dashboard/tool-group.vue ## @@ -101,6 +115,31 @@ limitations under the License. --> this.handleH

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on issue #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-23 Thread GitBox
Fine0830 commented on issue #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-618291506 Thanks for working on this. Could you update the icon style? Now the icons don't look neat enough. Thi

[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on issue #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-23 Thread GitBox
Fine0830 edited a comment on issue #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-618291506 Thanks for working on this. Could you update the icon style? Now the icons don't look neat enough. You use` js` native API to implement functions. Does `Vue` hav

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on issue #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-23 Thread GitBox
Fine0830 commented on issue #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-618294328 Could you take a more detailed screenshot? This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-rocketbot-ui] BFergerson opened a new pull request #289: Add Vert.x logo to topology

2020-04-24 Thread GitBox
BFergerson opened a new pull request #289: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-26 Thread GitBox
Jtrust commented on pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-619550403 > Thanks for working on this. Could you update the icon style? Now the icons don't look neat enough. You use` js` native API to implement functions. Does `Vue` hav

[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-26 Thread GitBox
Jtrust commented on pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-619552152 > I prefer dashboard level import/export to be more flexible ![pic](https://raw.githubusercontent.com/Jtrust/images/master/img/20200426213312.png) how abo

[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-26 Thread GitBox
Jtrust commented on pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-619554600 > Could you take a more detailed screenshot? ok This is an automated message from the Apach

[GitHub] [skywalking-rocketbot-ui] Jtrust commented on pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-26 Thread GitBox
Jtrust commented on pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-61931 > Could you take a more detailed screenshot? ok This is an automated message from the Apach

[GitHub] [skywalking-rocketbot-ui] Jtrust removed a comment on pull request #288: Feat:Import and export the configuration file for the dashboard layout

2020-04-26 Thread GitBox
Jtrust removed a comment on pull request #288: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/288#issuecomment-619554600 > Could you take a more detailed screenshot? ok This is an automated message from t

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 opened a new pull request #290: Add Python logo in topo

2020-05-05 Thread GitBox
kezhenxu94 opened a new pull request #290: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #290: Add Python logo in topo

2020-05-05 Thread GitBox
kezhenxu94 commented on pull request #290: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290#issuecomment-624475309 > Does python only need one icon rather than different libraries? This one is just for those libraries that are built in Python core (similar to JDK HTTP

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #290: Add Python logo in topo

2020-05-06 Thread GitBox
wu-sheng commented on pull request #290: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290#issuecomment-624488681 Got it. But Python and its component ids have not been reserved in the `component-libraries.yml`. Please add it there. -

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #290: Add Python logo in topo

2020-05-06 Thread GitBox
kezhenxu94 commented on pull request #290: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/290#issuecomment-624493687 > Got it. But Python and its component ids have not been reserved in the `component-libraries.yml`. Please add it there. It's already there for a while h

[GitHub] [skywalking-rocketbot-ui] efekaptan opened a new pull request #291: Add Mariadb component icon into topology

2020-05-06 Thread GitBox
efekaptan opened a new pull request #291: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/291 ![Screenshot 2020-05-06 at 20 30 26](https://user-images.githubusercontent.com/1737260/81216105-a7dad380-8fda-11ea-8329-4b7181ebfa14.png) -

[GitHub] [skywalking-rocketbot-ui] TinyAllen opened a new pull request #292: Fix: Topology first visit bug.

2020-05-06 Thread GitBox
TinyAllen opened a new pull request #292: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [skywalking-rocketbot-ui] TinyAllen opened a new pull request #293: Fix: Only check the real node

2020-05-06 Thread GitBox
TinyAllen opened a new pull request #293: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [skywalking-rocketbot-ui] gy0801151351 opened a new issue #294: skywaling 7.0.0 login feature

2020-05-10 Thread GitBox
gy0801151351 opened a new issue #294: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/294 I found that the login logic of WebApp UI was commented out. Related source is "skywalking-ui/src/router.ts". So, is there any security feature to protect the WebApp UI ? ---

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #294: skywaling 7.0.0 login feature

2020-05-10 Thread GitBox
wu-sheng commented on issue #294: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/294#issuecomment-626287121 You should setup login by yourself. Such as through Nginx. We are not providing those. The thing you found is legacy codes only.

[GitHub] [skywalking-rocketbot-ui] mrproliu opened a new issue #295: Missing relation scopes in alarm view

2020-05-11 Thread GitBox
mrproliu opened a new issue #295: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/295 Follow the https://github.com/apache/skywalking/pull/4769, the UI level currently misses the relation scopes items in the filter scope selection, and need to propagate the scope to the Graph

[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-21 Thread GitBox
Fine0830 opened a new pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297 Use new metrics system and custom configurations in dashboard **screenshots** ![屏幕快照 2020-05-22 上午11 25 25](https://user-images.githubusercontent.com/20871783/82628812-71c7

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632687670 I am doing the offline test and DM with @Fine0830. Polish this PR, and make it suitable for more people to test. ---

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on a change in pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#discussion_r429291032 ## File path: src/views/components/dashboard/dashboard-item.vue ## @@ -93,7 +93,7 @@ limitations under the License. --> };

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632730455 ![image](https://user-images.githubusercontent.com/5441976/82679907-26dc3700-9c7e-11ea-92bf-f56bb732a9b0.png) Service list on the standard APM page is not righ

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632731597 Changing query type from avg value to all values doesn't work. Don't know why. ![image](https://user-images.githubusercontent.com/5441976/82680128-6c98ff8

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632731224 The multiple metrics linear visualization doesn't show the correct backend result. ![image](https://user-images.githubusercontent.com/5441976/82680068-58ed99

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632732736 Height config is only working like before, ![image](https://user-images.githubusercontent.com/5441976/82680255-98b48080-9c7e-11ea-9090-ea2134106cce.png)

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632733545 Miss readSampledRecords type. `top_n_database_statement`'s metrics type is `SAMPLED_RECORD` ![image](https://user-images.githubusercontent.com/5441976/826

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632734364 SortedMetrics doesn't show the name correctly. ![image](https://user-images.githubusercontent.com/5441976/82680651-2abc8900-9c7f-11ea-95c1-7363452936e9.png)

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632737036 Every time, when I can't the component config, and close the config page. I have to refresh the browser page, otherwise, most likely, the change wouldn't take ef

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632731224 The multiple metrics linear visualization doesn't show the correct backend result. ![image](https://user-images.githubusercontent.com/5441976/82680068

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632741685 One key point, we shouldn't/can't hard code anything about any metrics because in the case of the metric, we can't expect which metrics they will generate

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632741685 One key point, we should/can't hard code anything about any metrics because in the case of the metric, we can't expect which metrics they will generate, and what

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964143 We need to add a static filter here, once user set this, use `searchServices` rather than `getAllServices` to get service list. ![image](https://user-images.g

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964542 Add a new option `all services` ![image](https://user-images.githubusercontent.com/5441976/82718970-d0e8ad00-9cd8-11ea-8cf6-d61d68c812bf.png) This i

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964926 The unit doesn't set up right. ![image](https://user-images.githubusercontent.com/5441976/82719023-5704f380-9cd9-11ea-8409-3880b91fe025.png) I thin

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-22 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964542 Add a new option `all services` ![image](https://user-images.githubusercontent.com/5441976/82718970-d0e8ad00-9cd8-11ea-8cf6-d61d68c812bf.png)

[GitHub] [skywalking-rocketbot-ui] itdamo commented on issue #283: skywaling 7.0.0 profile analysis function ui error

2020-05-25 Thread GitBox
itdamo commented on issue #283: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/283#issuecomment-633439466 I'v meeted the same error. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-rocketbot-ui] itdamo edited a comment on issue #283: skywaling 7.0.0 profile analysis function ui error

2020-05-25 Thread GitBox
itdamo edited a comment on issue #283: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/283#issuecomment-633439466 I'v meeted the same error. ![image](https://user-images.githubusercontent.com/5277544/82792421-fa086980-9ea1-11ea-8b9a-d098aff1c088.png) ---

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #283: skywaling 7.0.0 profile analysis function ui error

2020-05-25 Thread GitBox
wu-sheng closed issue #283: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #283: skywaling 7.0.0 profile analysis function ui error

2020-05-25 Thread GitBox
wu-sheng commented on issue #283: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/283#issuecomment-633455499 Fixed in the master already. Backend TTL issue caused this. This is an automated message from the Apa

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #295: Missing relation scopes in alarm view

2020-05-25 Thread GitBox
wu-sheng commented on issue #295: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/295#issuecomment-633460571 Provided in the master. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #295: Missing relation scopes in alarm view

2020-05-25 Thread GitBox
wu-sheng closed issue #295: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-rocketbot-ui] SecMao commented on issue #284: browser compability problem in Edge

2020-05-25 Thread GitBox
SecMao commented on issue #284: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/284#issuecomment-633475238 another problem in IE 11: children node with class 'ell' is not restricted by 'max-width' style set on parent. [max-width](https://github.com/apache/skywal

[GitHub] [skywalking-rocketbot-ui] SecMao edited a comment on issue #284: browser compability problem in Edge

2020-05-25 Thread GitBox
SecMao edited a comment on issue #284: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/284#issuecomment-633475238 another problem in IE 11: children node with class 'ell' is not restricted by 'max-width' style set on parent. [max-width](https://github.com/apache

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 opened a new pull request #298: Create .asf.yaml to mute the noises from PR/comments

2020-05-25 Thread GitBox
kezhenxu94 opened a new pull request #298: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/298 Recently the PR and comments events are sent to the dev@ mailing list, which generates much noise, this patch creates `.asf.yaml` to mute the events and sends them to notifications@ M

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 commented on pull request #298: Create .asf.yaml to mute the noises from PR/comments

2020-05-25 Thread GitBox
kezhenxu94 commented on pull request #298: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/298#issuecomment-633533146 Not sure why the problem doesn't exist in other SkyWalking repos This is an automated message

[GitHub] [skywalking-rocketbot-ui] kezhenxu94 merged pull request #298: Create .asf.yaml to mute the noises from PR/comments

2020-05-25 Thread GitBox
kezhenxu94 merged pull request #298: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-26 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634049566 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [skywalking-rocketbot-ui] karqical2016 opened a new issue #299: Proxy error: Could not proxy request /graphql from localhost:8080

2020-05-27 Thread GitBox
karqical2016 opened a new issue #299: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/299 Proxy error: Could not proxy request /graphql from localhost:8080 to http://127.0.0.1:12800. See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (E

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=1`

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #299: Proxy error: Could not proxy request /graphql from localhost:8080

2020-05-27 Thread GitBox
wu-sheng commented on issue #299: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/299#issuecomment-634643192 I run this in every day, all things are good. The UI requires the backend standing by. This is an au

[GitHub] [skywalking-rocketbot-ui] wu-sheng closed issue #299: Proxy error: Could not proxy request /graphql from localhost:8080

2020-05-27 Thread GitBox
wu-sheng closed issue #299: URL: https://github.com/apache/skywalking-rocketbot-ui/issues/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. The linear graph type is not configurable, but SLA has the bar graph, but

[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312 This PR is much better now, I think we left the following things to improve 1. The linear graph type is not configurable, but SLA has the bar graph, but

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635034168 Could you change all the config keys in full names? From my reading, they were using one char only, and your new keys are correct. ![image](https://user-

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
Fine0830 commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635118520 > Could you change all the config keys in full names? From my reading, they were using one char only, and your new keys are correct. > > ![image](https://

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
wu-sheng commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635119257 @Fine0830 I think all names should be full names, including topology template. This is an autom

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #297: Feat: New metrics and custom configurations in dashboard

2020-05-27 Thread GitBox
Fine0830 commented on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635124393 > @Fine0830 I think all names should be full names, including topology template. All of key names? If that, Yes, they are full names. https://user-image

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #136: optimize UT

2022-04-04 Thread GitBox
wu-sheng commented on code in PR #136: URL: https://github.com/apache/skywalking-java/pull/136#discussion_r841440944 ## apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/common/AtomicRangeIntegerTest.java: ## @@ -49,19 +49,22 @@ public void

[GitHub] asfgit closed pull request #666: Update README.md

2017-12-13 Thread GitBox
asfgit closed pull request #666: Update README.md URL: https://github.com/apache/incubator-skywalking/pull/666 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] asfgit closed pull request #620: [Discussion] Skywalking 5 Dashboard Service

2017-12-13 Thread GitBox
asfgit closed pull request #620: [Discussion] Skywalking 5 Dashboard Service URL: https://github.com/apache/incubator-skywalking/pull/620 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] ascrutae opened a new pull request #671: fix the local span cannot ref other trace segment

2017-12-13 Thread GitBox
ascrutae opened a new pull request #671: fix the local span cannot ref other trace segment URL: https://github.com/apache/incubator-skywalking/pull/671 This is an automated message from the Apache Git Service. To respond to

[GitHub] ascrutae opened a new pull request #672: [Agent] Fix the enhance class is incorrect

2017-12-13 Thread GitBox
ascrutae opened a new pull request #672: [Agent] Fix the enhance class is incorrect URL: https://github.com/apache/incubator-skywalking/pull/672 The enhance class that intercept by the opentracing activation is incorrect. it will cause that the segment miss some span.

[GitHub] wu-sheng closed pull request #671: [Agent] Cannot propagate the context across threads

2017-12-13 Thread GitBox
wu-sheng closed pull request #671: [Agent] Cannot propagate the context across threads URL: https://github.com/apache/incubator-skywalking/pull/671 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wu-sheng commented on issue #672: [Agent] Fix the enhance class is incorrect

2017-12-13 Thread GitBox
wu-sheng commented on issue #672: [Agent] Fix the enhance class is incorrect URL: https://github.com/apache/incubator-skywalking/pull/672#issuecomment-351599721 Rename to apache causes this, again. This is an automated messag

[GitHub] wu-sheng closed pull request #672: [Agent] Fix the enhance class is incorrect

2017-12-13 Thread GitBox
wu-sheng closed pull request #672: [Agent] Fix the enhance class is incorrect URL: https://github.com/apache/incubator-skywalking/pull/672 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] clevertension commented on issue #659: [Agent] Spring Bean Plugin

2017-12-13 Thread GitBox
clevertension commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-351614082 anyone doing this req? This is an automated message from the Apache Git S

[GitHub] wu-sheng commented on issue #659: [Agent] Spring Bean Plugin

2017-12-13 Thread GitBox
wu-sheng commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-351618695 @clevertension Not yet. If you are interesting, feel free to assign this issue to yourself, since you are already a committer. You have the rig

[GitHub] myoss opened a new issue #673: [Collector] add prefix for all storage table name

2017-12-13 Thread GitBox
myoss opened a new issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673 Table Name??? This is an automated message from the Apache

[GitHub] wu-sheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-13 Thread GitBox
wu-sheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351620223 Thanks for your suggestion. Please use English since your comments are documented by ASF. Chinese is not a good way, s

[GitHub] wu-sheng commented on issue #662: [Protocol] ?? .proto ???? rpc register ? Register????

2017-12-13 Thread GitBox
wu-sheng commented on issue #662: [Protocol] ?? .proto rpc register ? Register URL: https://github.com/apache/incubator-skywalking/issues/662#issuecomment-351620684 With collector side support, I will do the adjustments as soon as the ASF repo is ready. Sadly, it is still not.

[GitHub] wu-sheng commented on issue #659: [Agent] Spring Bean Plugin

2017-12-14 Thread GitBox
wu-sheng commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-351618695 @clevertension Not yet. If you are interesting, feel free to do. Just please let us know. ---

[GitHub] ascrutae opened a new pull request #674: [Agent] fix jedis testcase failed

2017-12-14 Thread GitBox
ascrutae opened a new pull request #674: [Agent] fix jedis testcase failed URL: https://github.com/apache/incubator-skywalking/pull/674 The test case cannot passed by using HashSet in some machine. Currently The test case change the HashSet to LinkedHashSet to keep iteration order so that

[GitHub] wu-sheng closed pull request #674: [Agent] fix jedis testcase failed

2017-12-14 Thread GitBox
wu-sheng closed pull request #674: [Agent] fix jedis testcase failed URL: https://github.com/apache/incubator-skywalking/pull/674 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-14 Thread GitBox
peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351690807 The elasticsearch database provide sharding index. Unless you want to use relation database such as mysql.

[GitHub] wu-sheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-14 Thread GitBox
wu-sheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351703212 > The elasticsearch database provide sharding index. Unless you want to use relation database such as mysql. @my

[GitHub] myoss commented on issue #673: [Collector] add prefix for all storage table name

2017-12-14 Thread GitBox
myoss commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351703575 i want to use in elasticsearch ... This is an automated me

[GitHub] myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
myoss opened a new issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675 Please answer these questions before submitting your issue. ### What version of sky-walking are you using? 5.0-2018-preview la

[GitHub] ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351708813 which agent version are you use? This is an

[GitHub] ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351708813 This version are not published, You can using the 3.2.6 version. ---

[GitHub] ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351708813 This version is not published, You can use the 3.2.6 version. --

[GitHub] ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
ascrutae commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351708813 This version is not publish, You can use the 3.2.6 version.

[GitHub] peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name

2017-12-14 Thread GitBox
peng-yongsheng commented on issue #673: [Collector] add prefix for all storage table name URL: https://github.com/apache/incubator-skywalking/issues/673#issuecomment-351712699 Sorry, I misunderstand the word distinguish as distributed. I don't recommend every one to share datab

[GitHub] wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351712867 ```java @Override public ElementMatcher getConstructorMatcher() { return takesArgume

[GitHub] wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient

2017-12-14 Thread GitBox
wu-sheng commented on issue #675: [Agent] java.lang.NoClassDefFoundError: okhttp3/OkHttpClient URL: https://github.com/apache/incubator-skywalking/issues/675#issuecomment-351713290 > This version is not published, You can use the 3.2.6 version. @myoss , But still @ascrutae is saying

<    4   5   6   7   8   9   10   11   12   13   >