[GitHub] ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
ascrutae commented on a change in pull request #737: Remove OJDBC and resin
artifacts from ci-dependencies driectory as they as not Apache license
compatible
URL:
https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405
##
File path: pom.xml
##
@@ -318,4 +278,89 @@
+
+
+
+
+
+install-ojdbc
+
+
+
${basedir}/ci-dependencies/ojdbc14-10.2.0.4.0.jar
+
+
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.6.0
+
+
+install-ojdbc
+false
+process-resources
+
+exec
+
+
+mvn
+
+
install:install-file
+
-Dfile=ojdbc14-10.2.0.4.0.jar
+
-DgroupId=com.oracle
+
-DartifactId=ojdbc14
+
-Dversion=10.2.0.4.0
+-Dpackaging=jar
+
+
${project.basedir}/ci-dependencies
+
+
+
+
+
+
+
+
+
+install-resin
Review comment:
I think the `resin-3` plugin should be removed too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ascrutae commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
ascrutae commented on a change in pull request #737: Remove OJDBC and resin
artifacts from ci-dependencies driectory as they as not Apache license
compatible
URL:
https://github.com/apache/incubator-skywalking/pull/737#discussion_r160851405
##
File path: pom.xml
##
@@ -318,4 +278,89 @@
+
+
+
+
+
+install-ojdbc
+
+
+
${basedir}/ci-dependencies/ojdbc14-10.2.0.4.0.jar
+
+
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.6.0
+
+
+install-ojdbc
+false
+process-resources
+
+exec
+
+
+mvn
+
+
install:install-file
+
-Dfile=ojdbc14-10.2.0.4.0.jar
+
-DgroupId=com.oracle
+
-DartifactId=ojdbc14
+
-Dversion=10.2.0.4.0
+-Dpackaging=jar
+
+
${project.basedir}/ci-dependencies
+
+
+
+
+
+
+
+
+
+install-resin
Review comment:
I think the `resin-3` plugin should be removed too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
