[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356858565 Make the user node as an extend of Node, rather then an attribute of ApplicationNode. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356536368 New protocol has been provided: 1. Add set/get `DataTTLConfigs` and set/get `AlarmThreshold` service. 1. All empty arrays are represented by `[]`, not `null`. 1. Add Mutation type, represents for all modification operations. 1. Support **Pagination** in some query. 1. Seperate alarm into to title and content @peng-yongsheng @hanahmily This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356307637 If we are using `[Node!]!` as you expected, a lot of parts in protocol need to be changed by following the same style. I hope to catch up in next day. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
