[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-11 Thread GitBox
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356858565 Make the user node as an extend of Node, rather then an attribute of ApplicationNode.

[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-10 Thread GitBox
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356536368 New protocol has been provided: 1. Add set/get `DataTTLConfigs` and set/get `AlarmThreshold`

[GitHub] wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null.

2018-01-09 Thread GitBox
wu-sheng commented on issue #732: Make the nodes of Topology nullable. And elements in it are not null. URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-356307637 If we are using `[Node!]!` as you expected, a lot of parts in protocol need to be changed by