Re: [slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-08-04 Thread Ceki Gulcu
Jörn Huxhorn wrote: Are you serious? I was. I once heard a lecture on logging and the prof said that the main objective of any logging framework must be to not break the application it is logging. Absolutely. From this point of view - that I absolutely share - the quality of the slf4j

Re: [slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-08-01 Thread Jörn Huxhorn
Hi Ceki. You forgot the double[] in your last commit. Regards, Joern. On Thu, Jul 31, 2008 at 10:51 PM, [EMAIL PROTECTED] wrote: Author: ceki Date: Thu Jul 31 22:51:04 2008 New Revision: 1086 Modified: slf4j/trunk/slf4j-api/src/main/java/org/slf4j/helpers/MessageFormatter.java

Re: [slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-08-01 Thread Ceki Gulcu
Hi Jörn, At least someone is watching over the code. Cool. I just realized that toString(primitive[]) methods in Arrays class were introduced in JDK 1.5. SLF4J needs to work on JDK 1.4 if not 1.3. Yikes. Jörn Huxhorn wrote: Hi Ceki. You forgot the double[] in your last commit.

Re: [slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-08-01 Thread Ceki Gulcu
Jörn Huxhorn wrote: And I just found out that it would be more appropriate to use Arrays.deepToString((Object[]) o); in case of Object[]. Right, except that deepToString is JDK 1.5. Double yikes. -- Ceki Gülcü QOS.ch is looking to hire talented developers located in Switzerland to work on

Re: [slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-08-01 Thread Jörn Huxhorn
Damn, you are right! I'm not watching out for 1.5 since I have a =1.5 requirement for Lilith. There's still a problem with your deeplyAppendParameter method: It's not handling recursive arrays yet. While this isn't a terribly realistic case it would cause a stack overflow at the moment. Take a

Re: [slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-08-01 Thread Ceki Gulcu
Jörn Huxhorn wrote: Damn, you are right! There's still a problem with your deeplyAppendParameter method: It's not handling recursive arrays yet. Yes, indeed. While this isn't a terribly realistic case it would cause a stack overflow at the moment. Take a look at the 1.5 implementation of

[slf4j-dev] svn commit: r1086 - in slf4j/trunk/slf4j-api/src: main/java/org/slf4j/helpers test/java/org/slf4j/helpers

2008-07-31 Thread ceki
Author: ceki Date: Thu Jul 31 22:51:04 2008 New Revision: 1086 Modified: slf4j/trunk/slf4j-api/src/main/java/org/slf4j/helpers/MessageFormatter.java slf4j/trunk/slf4j-api/src/test/java/org/slf4j/helpers/MessageFormatterTest.java Log: - add support for array values in parameters For