On Tue, Jul 2, 2013 at 7:39 PM, Alexander Klimetschek
aklim...@adobe.com wrote:
Felix wrote:
...(3) Maybe we can find a better name for the AdapterMethodProvider
interface -- something
which is more in line with the AdapterFactory service name.
What about simply AdapterProvider?...
Good
[
https://issues.apache.org/jira/browse/SLING-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698716#comment-13698716
]
Felix Meschberger commented on SLING-2002:
--
I have added more hints yet in Revs
Hi Alex,
why do you think registering logic by path is bad. Especially if I look at
potential for multitenantsupport it would be great to be able to register
postbehavior that is tenantspecific. And the tenantsupport of Sling is
completely based on paths.
Regarding usage of Servlet Filters as
Hi,
On Wed, Jul 3, 2013 at 12:55 PM, Dominik Süß dominik.su...@gmail.com wrote:
...why do you think registering logic by path is bad. Especially if I look at
potential for multitenantsupport it would be great to be able to register
postbehavior that is tenantspecific. And the tenantsupport of
Hi Bertrand,
while I agree that paths should not drive the app they might build a scope
for the logic, since the content is organized in a tree structure and not
in by it's resourceType hierarchy, Therefore you often do have pathspecific
operations (just think of workflows and workflowlaunchers
Hi Dominik,
Wouldn't a ResourceDecorator be a better solution in those case? I.e. if a
resource is of type app/foo and is under /content/bar, decorate the
resource to app/bar ?
The fact that you can register servlets by path should *not* in my opinion
be a reason to extend behavior-by-path to
Bertrand-
This all looks good to me. I would like to see condition metadata provided
in the @Adapter annotation. But this can be added after you commit (just
ideally before the release).
Regards,
Justin
On Tue, Jul 2, 2013 at 10:09 AM, Bertrand Delacretaz bdelacre...@apache.org
wrote:
Hi,
hi Justin,
On Wed, Jul 3, 2013 at 2:41 PM, Justin Edelson jus...@justinedelson.com wrote:
...I would like to see condition metadata provided
in the @Adapter annotation...
I'm generating that, see the bottom of this SLING-2938 screenshot
which describes an Adapter method:
On Wed, Jul 3, 2013 at 2:53 PM, Dominik Süß dominik.su...@gmail.com wrote:
...I bet a bunch of
scripts/servlet currently check the contentpath first and react on this...
Those servlets should die ;-)
-Bertrand
Hi,
On Tue, Jul 2, 2013 at 2:38 PM, Alexander Klimetschek aklim...@adobe.comwrote:
Ack on the overall goal.
The way I see it, it boils down to having the sling post servlet (or more
specifically that new POST-pipeline) not just one special servlet out of
many, but an integral part of
On Wed, Jul 3, 2013 at 2:58 PM, Justin Edelson jus...@justinedelson.com wrote:
...Why wouldn't you register by resource type + method + selector? After all,
that's what you do now. For pipeline components, we could add a phase
registration property (or maybe ranking is enough)
And phase
Thanks for taking this up, Stefan.
I think we should also try to close down the first version of the discovery
api and release this, so other parts of our code can really rely on this
api.
Apart from that, I don't have a strong preference, although it would be
nice to just use Apache stuff :)
Hi Bertrand,
On Wed, Jul 3, 2013 at 8:55 AM, Bertrand Delacretaz
bdelacre...@apache.orgwrote:
hi Justin,
On Wed, Jul 3, 2013 at 2:41 PM, Justin Edelson jus...@justinedelson.com
wrote:
...I would like to see condition metadata provided
in the @Adapter annotation...
I'm generating that,
[
https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler reassigned SLING-2925:
---
Assignee: Carsten Ziegeler
Wasted work in
[
https://issues.apache.org/jira/browse/SLING-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-2925:
Fix Version/s: Extensions Event 3.2.0
Wasted work in
On Wed, Jul 3, 2013 at 3:07 PM, Justin Edelson jus...@justinedelson.com wrote:
...
@Adapter(condition=if the resource type is slingbucks/list).
...
Makes sense, noted in SLING-2938
-Bertrand
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698943#comment-13698943
]
Carsten Ziegeler commented on SLING-2938:
-
Who is processing this annotation and
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698948#comment-13698948
]
Bertrand Delacretaz commented on SLING-2938:
The @Adapter annotation is
If I got the implementation right you always trigger exactly one, so this
is not an aspect, this is wat actualy is done to perform the post.
Aspects are handled via PostProcessors.
On Wed, Jul 3, 2013 at 2:58 PM, Justin Edelson jus...@justinedelson.comwrote:
Hi,
On Tue, Jul 2, 2013 at 2:38
Just read the answer in the issue :)
I like the general intention - however it feels a little bit strange to
register a AdapterProvider, annotate a method and then this gets picked up
at runtime and a new AdapterFactory is registered.
Can't we make this annoation build time only - as an
I'm more in the camp of fix-the-docs :) One could argue that higher
priority means they have the most power and therefore are run last and can
overrule everything previous filters have done - this again would be
somehow in line with service ranking in general.
In general, when there is a doubt and
[
https://issues.apache.org/jira/browse/SLING-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698982#comment-13698982
]
Bertrand Delacretaz commented on SLING-2803:
I briefly reviewed the
On Wed, Jul 3, 2013 at 4:00 PM, Carsten Ziegeler cziege...@apache.org wrote:
...In general, when there is a doubt and it's not clearly a bug, I would think
that the implementation is right and the docs are wrong...
yes, yes, yes, +1 !
People have been running our code, not our docs...changing
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/1711/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$maven-jcrocm-plugin/1711/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.commons.json/1711/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1711/
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$adapter-annotations/1711/
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.engine/81/
--
[INFO]
[INFO]
[
https://issues.apache.org/jira/browse/SLING-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-2943.
-
Resolution: Fixed
Fixed in revision 1499459
Classloader might not be
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing-war/82/
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/82/
See
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/82/
See https://builds.apache.org/job/sling-trunk-1.7/82/changes
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.jcr.jackrabbit.server/1712/
--
[INFO]
[INFO]
See https://builds.apache.org/job/sling-trunk-1.6/1712/changes
Changes:
[cziegeler] SLING-2943 : Classloader might not be invalidated in a cluster
--
[...truncated 6356 lines...]
[INFO] Apache Sling JCR ClassLoader .. SUCCESS
On 03.07.2013, at 14:58, Justin Edelson jus...@justinedelson.com wrote:
IMHO :operation is an aspect of the current default POST servlet. If we are
going to move more POST-specific handling into the engine, then we should
be using selectors.
Yes, my main point was to have only one. You are
On 03.07.2013, at 17:34, Radu Cotescu r...@apache.org wrote:
1. Currently there's no support for hierarchical structures. ValueMap
doesn't provide this kind of support.
Yes, the jcr property value map implementation supports relative paths. This
should definitely be supported, as you very
Justin,
Thanks for the response, I was able to check out the code there, but when I
tried to check my changes back in a received the following error:
dklco@dk6d-laptop:~/Development/6ddev/workspaces/sling/sling$ svn ci -m
Adding my GPG key
SendingKEYS
svn: E195023: Commit failed (details
2013/7/3 Alexander Klimetschek aklim...@adobe.com
On 03.07.2013, at 17:34, Radu Cotescu r...@apache.org wrote:
1. Currently there's no support for hierarchical structures. ValueMap
doesn't provide this kind of support.
Yes, the jcr property value map implementation supports relative
[
https://issues.apache.org/jira/browse/SLING-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699411#comment-13699411
]
Robert Munteanu commented on SLING-2939:
[~egli] - JGroups can function well with
Hi,
Found what Alex was talking about in the
org.apache.sling.jcr.resource.JcrPropertyMap class. I'm sorry for my
previous answer. The implementation wasn't that obvious at first.
What do you think the best approach would be given the hierarchical
structures problem and the currently proposed
As I wrote, a hierarchy is only supported by a single implementation for
reading - not for writing, so it doesn't make sense to me to support this
in validation as this can't be written through the resource api in the same
way. The post servlet is splitting paths and creates a resource for each
43 matches
Mail list logo
