Chetan Mehrotra created SLING-3242:
--
Summary: Allow refering to OSGi appenders from within Logback
config
Key: SLING-3242
URL: https://issues.apache.org/jira/browse/SLING-3242
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra resolved SLING-3242.
Resolution: Fixed
Added support in rev r1541422
It can be used in following manner
Hi Bertrand,
it looks cool indeed!
I agree it'd be nice to enable feature flags also on the resource (even if
I'm not too much convinced access gates are a good fit for it) and service
level, and design the API for that too.
However I'm not sure how that could be done for services in general,
Currently Sling is packaging 1.6.4 for the slf4j-api. Most recent
release is 1.7.5 and has some noteworthy changes [1] including
performance, usage of varargs etc. The core API bundle has no
compatibility breaking change.
Slf4j bundle maps the package exports to bundle version. So with 1.7.5
the
Chetan Mehrotra created SLING-3243:
--
Summary: Update the Slf4j API bundle to 1.7.5
Key: SLING-3243
URL: https://issues.apache.org/jira/browse/SLING-3243
Project: Sling
Issue Type: Task
[
https://issues.apache.org/jira/browse/SLING-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821168#comment-13821168
]
Chetan Mehrotra commented on SLING-3243:
Checking for the {{Import-Package}}
[
https://issues.apache.org/jira/browse/SLING-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821173#comment-13821173
]
Chetan Mehrotra commented on SLING-3243:
Based on above we need to take care of
Yup would run the integration tests.
I have created SLING-3243 to track this.
Chetan Mehrotra
[1] https://issues.apache.org/jira/browse/SLING-3243
[
https://issues.apache.org/jira/browse/SLING-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821180#comment-13821180
]
Bertrand Delacretaz commented on SLING-3231:
I don't have a very strong
Bertrand Delacretaz created SLING-3244:
--
Summary: Upgrade sling.api in commons/testing
Key: SLING-3244
URL: https://issues.apache.org/jira/browse/SLING-3244
Project: Sling
Issue Type:
Hi Dominik,
On Tue, Nov 12, 2013 at 5:07 PM, Dominik Süß dominik.su...@gmail.com wrote:
...as far as I can see the API is just covering the java aspect of this...
Nothing prevents you from using the FeatureFlags service in scripted code.
you could have a gate looking for a marker at a
[
https://issues.apache.org/jira/browse/SLING-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-3244.
Resolution: Fixed
Changes committed in revision 1541469
Upgrade sling.api in
Hi Robert,
On Tue, Nov 12, 2013 at 5:38 PM, Robert Munteanu rob...@lmn.ro wrote:
...1. I am typically wary of using Strings and am thinking that Enums
would be a nice fit for feature flags...
I see your point, what's the reason? Performance? Risk of typos?
...how about having a FeatureFlag
Hi Tommaso,
On Wed, Nov 13, 2013 at 11:01 AM, Tommaso Teofili
tommaso.teof...@gmail.com wrote:
...I agree it'd be nice to enable feature flags also on the resource (even if
I'm not too much convinced access gates are a good fit for it) and service
level, and design the API for that too
I
[
https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra resolved SLING-3049.
Resolution: Fixed
Fix Version/s: Commons Log 4.0.0
Applied the patch and also added
I assume yes, but it doesn't for dates.
In particular, org.apache.jackrabbit.value.DateValue converts to ISO8601 when
asked for a string, while ValueMapDecorator gives you the string format of the
Calendar object.
Is this a bug, or should I interpret the Value in ValueMapDecorator more
[
https://issues.apache.org/jira/browse/SLING-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra resolved SLING-3231.
Resolution: Fixed
Fix Version/s: Launchpad Base 2.5.2
Assignee: Chetan
Hi,
Since SLING-3244 was fixed could we also get a 2.0.16 release
for org.apache.sling.commons.testing?
Thanks,
Radu
On Wed, Nov 13, 2013 at 12:57 PM, Bertrand Delacretaz (JIRA)
j...@apache.org wrote:
Bertrand Delacretaz created SLING-3244:
--
Hi Bertrand
Thanks. This looks like a promising start.
I have some comments, though ;-)
1. My first reaction to the SlingHttpServletRequest argument was: Why an
argument ? Why not a ThreadLocal managed by the actual service with the help of
a request filter ? (ok, what to do with non-request
[
https://issues.apache.org/jira/browse/SLING-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821263#comment-13821263
]
Jörg Hoh commented on SLING-3148:
-
@Carsten: I currently see a problem, when I have 2
Hi
Just a stupid idea:
public final class Context {
public static Context from(SlingHttpServletRequest req) {
return new Context(req, ...);
}
...
final SlingHttpServletRequest req;
private Context(SlingHttpServletRequest req, ...) {
this.req = req;
}
Hi
Am 13.11.2013 um 23:12 schrieb Felix Meschberger fmesc...@adobe.com:
Hi Bertrand
Thanks. This looks like a promising start.
I have some comments, though ;-)
1. My first reaction to the SlingHttpServletRequest argument was: Why an
argument ? Why not a ThreadLocal managed by the
Sounds reasonable to me.
Regards
Felix
—
Felix Meschberger | Principal Scientist | Adobe
Am 13.11.2013 um 21:17 schrieb Chetan Mehrotra chetan.mehro...@gmail.com:
Currently Sling is packaging 1.6.4 for the slf4j-api. Most recent
release is 1.7.5 and has some noteworthy changes [1]
Hi,
I am try to run integration test by executing following command at
trunklaunchpad/testing
mvn clean install
However it results in following exception. Is this the right way to
test or I need to follow some other steps
[INFO]
Hi Bertrand,
the UI of an application based on Sling are often composed of existing
resourceTypes so you cannot just decide in the code to display or not to
display so you have to annotate/flag the resources and then have some
code deciding if this resource should be rendered or not. For sure you
[ERROR] Caused by: java.lang.ClassNotFoundException:
org.apache.sling.commons.testing.junit.categories.OakOnly
Adding org.apache.sling.commons.testing as a dependency in the
integrationTesting profile seems to resolve the issue
Chetan Mehrotra
On Wed, Nov 13, 2013 at 7:24 PM, Chetan Mehrotra
[
https://issues.apache.org/jira/browse/SLING-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821389#comment-13821389
]
Chetan Mehrotra edited comment on SLING-3243 at 11/13/13 2:49 PM:
[
https://issues.apache.org/jira/browse/SLING-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821389#comment-13821389
]
Chetan Mehrotra commented on SLING-3243:
Did the required changes in rev 1541534
Bertrand, Dominik,
the feature flag may also have an impact on the nodes/properties that
you need to render the feature. Being able to handle this in the
resource tree directly without having to handle it in component code
would be great. However, I am not sure if the intention of the feature
Hi,
On Wed, Nov 13, 2013 at 3:39 PM, Chetan Mehrotra
chetan.mehro...@gmail.com wrote:
[ERROR] Caused by: java.lang.ClassNotFoundException:
org.apache.sling.commons.testing.junit.categories.OakOnly
Adding org.apache.sling.commons.testing as a dependency in the
integrationTesting profile seems
Hi Ruben,
the intention is to disable features that are not should not be globally
available but might be activated under certain conditions. This reduces the
need to branch non-production ready features away and merge them in later
and opens the option to have something like a Friendly user Test
[
https://issues.apache.org/jira/browse/SLING-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821417#comment-13821417
]
Bertrand Delacretaz commented on SLING-3148:
Let's continue the discussion on
If I build 'sling/launchpad/integration-tests' then it fixes the
issue. So problem resolved for now. Looks like I was having a stale
snapshot
Chetan Mehrotra
On Wed, Nov 13, 2013 at 8:48 PM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
Hi,
On Wed, Nov 13, 2013 at 3:39 PM, Chetan Mehrotra
The Buildbot has detected a new failure on builder sling-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/sling-trunk/builds/5
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: osiris_ubuntu
Build Reason: forced: by IRC user moi
Build failed due to following reason
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.195 sec
Results :
Failed tests:
testDeferredConfigInstall(org.apache.sling.installer.it.ConfigInstallTest):
Config must be removed once ConfigurationAdmin restarts: Configuration
is still
I have done the required changes as part of SLING-3243. However one
area is pending
The Sling Parent pom.xml pins the slf4j-api bundle at 1.5.2. To make
use of new varargs support as part of slf4j api 1.7.5 (it now uses JDK
1.5) we would need to update this version. Note that at binary level
[
https://issues.apache.org/jira/browse/SLING-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reopened SLING-1794:
Assignee: Bertrand Delacretaz (was: Robert Munteanu)
Just saw this again on a
[
https://issues.apache.org/jira/browse/SLING-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821502#comment-13821502
]
Bertrand Delacretaz edited comment on SLING-1794 at 11/13/13 4:43 PM:
On Wednesday, November 13, 2013, Chetan Mehrotra wrote:
...Failed tests:
testDeferredConfigInstall(org.apache.sling.installer.it.ConfigInstallTest):
Config must be removed once ConfigurationAdmin restarts: Configuration
is still present (ConfigInstallTest.deferred.1384357592923)...
I have
-1 (non binding) as no http://incubator.apache.org/ip-clearance/ is
filed. this has to be done before voting for contribution. also, we
(Adobe) should also provide a software grant prior to this.
Regards, Toby
On Tue, Nov 12, 2013 at 5:07 AM, Justin Edelson
jus...@justinedelson.com wrote:
+1
Hi
That worries me.
We have long refused to update the JCR API reference in the parent POM on the
grounds to not have a global requirement for JCR 2 API enforced upon all
bundles.
So, if we can configure the parent POM such, that it also presets the org.slf4j
package imports appropriately, I
[
https://issues.apache.org/jira/browse/SLING-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822015#comment-13822015
]
Felix Meschberger commented on SLING-3148:
--
... archived here:
Hi all
This is a message long overdue. Sorry for the delay !
Based on his ongoing and valuable contributions to the project, the Sling PMC
has elected Amit Gupta (amitgupt) as a Sling committer, and he has accepted the
invitation. Please join me in welcoming him!
Amit, if you want to honor
Congratulations and Welcome Amit !
Chetan Mehrotra
On Thu, Nov 14, 2013 at 8:56 AM, Felix Meschberger fmesc...@adobe.com wrote:
Hi all
This is a message long overdue. Sorry for the delay !
Based on his ongoing and valuable contributions to the project, the Sling PMC
has elected Amit
See
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/2038/
--
[INFO] Deleting
https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target
[INFO]
as far as I know there's usually a vote on the dev@ list for first
acceptance (and then it's referenced in the IP Clearance file), then the IP
Clearance is done (including SGA, lazy consensus vote on general@incubator,
etc.), and then finally code is committed if everything is fine.
That's why I
46 matches
Mail list logo
