On Thu, Nov 14, 2013 at 4:26 AM, Felix Meschberger fmesc...@adobe.com wrote:
...Based on his ongoing and valuable contributions to the project, the Sling
PMC has elected Amit Gupta (amitgupt) as
a Sling committer, and he has accepted the invitation...
Welcome Amit!
-Bertrand
On Thu, Nov 14, 2013 at 8:37 AM, Tommaso Teofili
tommaso.teof...@gmail.com wrote:
as far as I know there's usually a vote on the dev@ list for first
acceptance (and then it's referenced in the IP Clearance file), then the IP
Clearance is done...
That's how I see it as well, hence my +1
Hi,
Thanks Felix, Chetan Bertrand for a warm welcome. Thanks to the team for this
opportunity.
Introduction:
I work for Adobe Systems and have been using Sling for past couple of years. It
is absolutely fantastic, and I look forward to make it even better.
Thanks,
Amit
Rather I could imagine backing this into the ResourceResolver itself ...
I think we should avoid going down this route. The ResourceResolver is
a core feature of Sling, while feature-flags is (should be) an
optional feature.
Baking feature-flags into the RR would violate modularity IMO.
One
+1 on extension hook in RR and adding this
I had no closer look at Accessgate yet and thought it to behave that way
from initial talks about this before implementation started. I just thought
that Access Control is not just about permissions, it is about granting or
denying access based on what
On Thu, Nov 14, 2013 at 12:12 PM, Julian Sedding jsedd...@gmail.com wrote:
...One way to achieve the same integration without baking that
functionality into the RR would be to create an extension hook that
allows decorating the RR...
I agree that we shouldn't bake feature flags deep into
On Wed, Nov 13, 2013 at 1:06 PM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
Hi Robert,
On Tue, Nov 12, 2013 at 5:38 PM, Robert Munteanu rob...@lmn.ro wrote:
...1. I am typically wary of using Strings and am thinking that Enums
would be a nice fit for feature flags...
I see your
To confirm what Dominik mentioned:
The existing ResourceAccessGate would allow to grant or deny access
to resources. IMHO there's no need to implement another interface or
hook to achieve what is requested in the perspective of granting or denying
access to resources based on feature flag. Just
On Thu, Nov 14, 2013 at 1:56 PM, Mike Müller mike...@mysign.ch wrote:
...Just implement a
FeatureFlagResourceGate (or whatever name would make sense)..
My earlier question was, can one do this without any changes to Sling
besides providing a way to find if a given feature is enabled, like in
my
Hi Bertrand,
I disagree on that one - maybe we should put it in contrib or so, but is is
essential to disable most features to disable some parts of the
resourcetree. This is just applying your api in a conventient api to
resource resolving. There is no additional magic since developers would
Hi
Sure you can do it, but it (a) doesn’t match the idea of an access gate (at
least not in my little brain cells) and (b) it is not comprehensive since the
JCR Resource Provider does not leverage that. (b) is IMHO the one reason
breaking the idea.
I like the idea of a decoration hook. Yet:
Hi
Agreed: Sling should come with a support for Feature-based resource filtering
(or however we call that mechanism) and it should be on the same level (contrib
or bundles) as the Features feature itself.
Regards
Felix
—
Felix Meschberger | Principal Scientist | Adobe
Am 15.11.2013 um
On Thu, Nov 14, 2013 at 2:37 PM, Felix Meschberger fmesc...@adobe.com wrote:
...Agreed: Sling should come with a support for Feature-based resource
filtering (or however we
call that mechanism) and it should be on the same level (contrib or bundles)
as the Features
feature itself...
ok,
Hi Felix,
see my comments inline.
Best regards
Dominik
On Thu, Nov 14, 2013 at 2:35 PM, Felix Meschberger fmesc...@adobe.comwrote:
Hi
Sure you can do it, but it (a) doesn’t match the idea of an access gate
(at least not in my little brain cells) and (b) it is not comprehensive
since the
On Thu, Nov 14, 2013 at 2:35 PM, Felix Meschberger
fmesc...@adobe.comwrote:
Hi
Sure you can do it, but it (a) doesn’t match the idea of an access gate
(at least not in my little brain cells) and (b) it is not comprehensive
since the JCR Resource Provider does not leverage that. (b)
[
https://issues.apache.org/jira/browse/SLING-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822600#comment-13822600
]
Bertrand Delacretaz commented on SLING-3147:
I have added some tests to the
The Buildbot has detected a restored build on builder sling-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/sling-trunk/builds/7
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: osiris_ubuntu
Build Reason: forced: by IRC user
On 14.11.2013, at 05:11, Dominik Süß dominik.su...@gmail.com wrote:
As mentioned earlier the majority of features I have implemented yet do
have a frontendpart that would get rendered and it would add additional
complexity if I have to use custom resourceTypes (inherited ones through
Hi Alex,
this is one way but just solves this partially since you completely rely on
inclusions to happen, but sometimes you just walk the tree and collect the
information of resources e.g. to draw the navigation - and for such
situations it would then be required to add such logic to the
Roy Fielding's presentation on the subject may also be interesting
http://www.slideshare.net/royfielding/evolve13-keynote-scrambled-eggs
page 36 to 45
Ruben
On 11/14/2013 1:55 PM, Dominik Süß wrote:
Hi Alex,
this is one way but just solves this partially since you completely rely on
On 14.11.2013, at 13:55, Dominik Süß dominik.su...@gmail.com wrote:
this is one way but just solves this partially since you completely rely on
inclusions to happen, but sometimes you just walk the tree and collect the
information of resources e.g. to draw the navigation - and for such
[
https://issues.apache.org/jira/browse/SLING-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823027#comment-13823027
]
Alexander Klimetschek commented on SLING-3147:
--
I guess it's a missing
Hi Tommaso,
thanks for the explanation - I didn't realize that you are in that
early stage :-) I thought that the PMC already gave their OK to go
forward with the donation.
here's my non binding +1 then :-)
Regards, Toby
On Thu, Nov 14, 2013 at 1:48 AM, Bertrand Delacretaz
[
https://issues.apache.org/jira/browse/SLING-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823337#comment-13823337
]
Tobias Bocanegra commented on SLING-3147:
-
...or create the session with
Am 14.11.2013 23:11 schrieb Alexander Klimetschek aklim...@adobe.com:
On 14.11.2013, at 13:55, Dominik Süß dominik.su...@gmail.com wrote:
this is one way but just solves this partially since you completely
rely on
inclusions to happen, but sometimes you just walk the tree and collect
the
Hi
TL;DR: Long discussion on why I think Feature flag support should currently be
baked into the ResourceResolver implementation.
I am forking of this discussion now to step back a bit and really look into
what we expect from Feature flag support in the ResourceResolver. I go by the
main
26 matches
Mail list logo
