Re: [VOTE] Release Apache Sling Models Impl 1.4.8

2018-03-01 Thread Carsten Ziegeler
+1 Stefan Seifert wrote > Hi, > > We solved 6 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12342303 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1878/ > > You can use this UNIX script to download the release

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382665#comment-16382665 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

RE: [VOTE] Release Apache Sling Models Impl 1.4.8

2018-03-01 Thread Stefan Seifert
+1

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382542#comment-16382542 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

Re: [VOTE] Release Apache Sling Models Impl 1.4.8

2018-03-01 Thread Jason E Bailey
+1 - Jason On Thu, Mar 1, 2018, at 12:54 PM, Daniel Klco wrote: > +1 > > On Thu, Mar 1, 2018 at 9:51 AM, Stefan Seifert > wrote: > > > Hi, > > > > We solved 6 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12342303 > > > > Staging

Re: [VOTE] Release Apache Sling Models Impl 1.4.8

2018-03-01 Thread Daniel Klco
+1 On Thu, Mar 1, 2018 at 9:51 AM, Stefan Seifert wrote: > Hi, > > We solved 6 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12342303 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1878/ >

[VOTE] Release Apache Sling Models Impl 1.4.8

2018-03-01 Thread Stefan Seifert
Hi, We solved 6 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12342303 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1878/ You can use this UNIX script to download the release and verify the signatures:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382365#comment-16382365 ] ASF GitHub Bot commented on SLING-7509: --- dulvac commented on a change in pull request #5: SLING-7509

[jira] [Created] (SLING-7524) Sling Query - unique function does not not remove all duplicates

2018-03-01 Thread Jason E Bailey (JIRA)
Jason E Bailey created SLING-7524: - Summary: Sling Query - unique function does not not remove all duplicates Key: SLING-7524 URL: https://issues.apache.org/jira/browse/SLING-7524 Project: Sling

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382118#comment-16382118 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382110#comment-16382110 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382112#comment-16382112 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382102#comment-16382102 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Closed] (SLING-7500) sling-mock: Make compatible with org.apache.sling.commons.mime 2.1.10

2018-03-01 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-7500. - > sling-mock: Make compatible with org.apache.sling.commons.mime 2.1.10 >

[jira] [Closed] (SLING-7482) MockSlingHttpServletResponse.getHeaders is case sensitive

2018-03-01 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-7482. - > MockSlingHttpServletResponse.getHeaders is case sensitive >

[RESULT] [VOTE] Release Apache Sling Testing Sling Mock 2.2.18, Servlet Helpers 1.1.4

2018-03-01 Thread Stefan Seifert
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Daniel Klco, Radu Cotescu, Carsten Ziegeler I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan

Re: sling models impl release?

2018-03-01 Thread Chris Millar
On Thu, Mar 1, 2018 at 3:34 AM Stefan Seifert wrote: > we have a number of important fixes for sling models impl > https://issues.apache.org/jira/browse/SLING/fixforversion/12342303 > > if no one objects i will cut a release this evening or tomorrow. > > stefan > > +1

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381984#comment-16381984 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381980#comment-16381980 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381979#comment-16381979 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381977#comment-16381977 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381903#comment-16381903 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381898#comment-16381898 ] ASF GitHub Bot commented on SLING-7509: --- volteanu commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381820#comment-16381820 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381821#comment-16381821 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381818#comment-16381818 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381822#comment-16381822 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381823#comment-16381823 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

[jira] [Commented] (SLING-7509) Add QueryClient

2018-03-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381819#comment-16381819 ] ASF GitHub Bot commented on SLING-7509: --- rombert commented on a change in pull request #5:

RE: Mute ASF GitHub Bot

2018-03-01 Thread Stefan Seifert
>Well, we can always talk to infra about this since they manage this >service. I think a good level of comments would be: > >- comment with link when PR is open >- comment with link when PR is merged >- comment with link when PR is closed > >I think we should have as little duplication as

sling models impl release?

2018-03-01 Thread Stefan Seifert
we have a number of important fixes for sling models impl https://issues.apache.org/jira/browse/SLING/fixforversion/12342303 if no one objects i will cut a release this evening or tomorrow. stefan

Re: Mute ASF GitHub Bot

2018-03-01 Thread Robert Munteanu
On Thu, 2018-03-01 at 10:10 +, Valentin Olteanu wrote: > Hi, > > The ASF GitHub Bot posts jira comments with the activity in github > linked > to an issue. While the comment about opening a new pull request is > somehow > useful, the others for every single comment are very verbose and >

Mute ASF GitHub Bot

2018-03-01 Thread Valentin Olteanu
Hi, The ASF GitHub Bot posts jira comments with the activity in github linked to an issue. While the comment about opening a new pull request is somehow useful, the others for every single comment are very verbose and pollute the comment section in jira, especially after a code review. Example:

[jira] [Created] (SLING-7523) Java Use object with trailing whitespace in the package declaration freezes the SightlyJavaCompilerService

2018-03-01 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-7523: --- Summary: Java Use object with trailing whitespace in the package declaration freezes the SightlyJavaCompilerService Key: SLING-7523 URL:

[jira] [Comment Edited] (SLING-7522) Scheduler bundle/package version mismatch

2018-03-01 Thread Amichai Rothman (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381646#comment-16381646 ] Amichai Rothman edited comment on SLING-7522 at 3/1/18 8:31 AM: Ok, I