Re: Sling FM Starter Module

2019-11-19 Thread Andreas Schaefer
Hi Robert Both, we need FM descriptors for single bundles and for groups (ala PMs). The reason for single bundles is to provide the ability to assemble an application by cherry picking bundles so that I do not have to wait for a group to be released. - Andy > On Nov 19, 2019, at 6:41 AM,

Re: Sling FM Starter Module

2019-11-19 Thread Andreas Schaefer
I am still struggling to find a balanced solution for this. What I want to do is to have a way for modules, projects and assemblers to deal with FMs through Maven like the PM does with dependencies. The issue is that all FMs need to be available for an assembler to build its Sling project and

[jira] [Resolved] (SLING-8850) CMS - Reference Add Image Transformation Support

2019-11-19 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8850. - Resolution: Fixed > CMS - Reference Add Image Transformation Support >

[jira] [Updated] (SLING-8850) CMS - Reference Add Image Transformation Support

2019-11-19 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-8850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-8850: Fix Version/s: CMS 0.14.0 > CMS - Reference Add Image Transformation Support >

Re: Sling FM Starter Module

2019-11-19 Thread Ruben Reusser
Robert, I think the first focus is on 1, fast followed by 2 and 3 Ruben On 11/19/2019 6:53 AM, Robert Munteanu wrote: On Tue, 2019-11-19 at 06:47 -0800, Ruben Reusser wrote: Robert, would we not want each module to produce it's own feature file and then have an aggregation somewhere?

Re: [org.apache.sling.xss] namespace mangling

2019-11-19 Thread Radu Cotescu
Hi Dan, > On 19 Nov 2019, at 16:18, Daniel Klco wrote: > > I've seen issues with this in the wild. A client was attempting to link to > external URLs containing colons (bad practice I know, but you get health > care web services to get out of the 1990's) in a HTL script which was > getting

RE: [org.apache.sling.xss] namespace mangling

2019-11-19 Thread Stefan Seifert
in my understanding the namespace mangling was only introduced in the olden days of sling to work around problems in some old browsers that did not support URLs with colons in it. i think those old browsers are no longer in use for many, many years. so i assume it is no problem to not mangle

Re: [org.apache.sling.xss] namespace mangling

2019-11-19 Thread Daniel Klco
I've seen issues with this in the wild. A client was attempting to link to external URLs containing colons (bad practice I know, but you get health care web services to get out of the 1990's) in a HTL script which was getting mangled even though the URL was not a JCR path. My concern is that if

[org.apache.sling.xss] namespace mangling

2019-11-19 Thread Radu Cotescu
Hi, From the very beginning the org.apache.sling.xss code was donated to Sling it provided an implementation of the XSSAPI.getValidHref that mangles JCR namespaces from the passed URLs (let’s not comment on the naming). However, the code that does this has no information about the registered

Re: Sling FM Starter Module

2019-11-19 Thread Robert Munteanu
On Tue, 2019-11-19 at 06:47 -0800, Ruben Reusser wrote: > Robert, > > would we not want each module to produce it's own feature file and > then > have an aggregation somewhere? Depends on what you define as a module. I see multiple options here: 1. A bundle produces its own feature file. For

Re: Sling FM Starter Module

2019-11-19 Thread Ruben Reusser
Robert, would we not want each module to produce it's own feature file and then have an aggregation somewhere? Ruben On 11/19/2019 6:41 AM, Robert Munteanu wrote: On Fri, 2019-11-15 at 11:47 -0800, Andreas Schaefer wrote: Hi I started to get the pieces into place for a build up of

Re: Sling FM Starter Module

2019-11-19 Thread Robert Munteanu
On Fri, 2019-11-15 at 11:47 -0800, Andreas Schaefer wrote: > Hi > > I started to get the pieces into place for a build up of Peregrine > CMS based on Sling 11 using FMs. > > First I updated the Sling Feature Converter Maven Plugin to install > the generated slingosgifeature into my local Maven

Re: [VOTE] Release Apache Sling CMS 0.14.0

2019-11-19 Thread Robert Munteanu
On Tue, 2019-11-19 at 12:58 +, Dan Klco wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.16

2019-11-19 Thread Daniel Klco
+1 On Tue, Nov 19, 2019 at 7:08 AM Robert Munteanu wrote: > On Mon, 2019-11-18 at 14:16 +, Radu Cotescu wrote: > > Please vote to approve this release: > > +1 > > Robert > >

[VOTE] Release Apache Sling CMS 0.14.0

2019-11-19 Thread Dan Klco
Hi, We solved 14 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12345614 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2159/ You can use this UNIX script to download the release and verify the signatures:

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #402 is FIXED

2019-11-19 Thread Apache Jenkins Server
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/402/ for details. No further emails will be sent until the status of the build is changed.

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #401 is BROKEN

2019-11-19 Thread Apache Jenkins Server
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/401/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 5476 lines...]

Re: [VOTE] Release Apache Sling API 2.21.0

2019-11-19 Thread Robert Munteanu
On Mon, 2019-11-18 at 16:44 +, Radu Cotescu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.16

2019-11-19 Thread Robert Munteanu
On Mon, 2019-11-18 at 14:16 +, Radu Cotescu wrote: > Please vote to approve this release: +1 Robert

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.12

2019-11-19 Thread Robert Munteanu
On Tue, 2019-11-19 at 11:13 +0100, Radu Cotescu wrote: > some of the dependencies’ classes used > APIs not available in the JRE, but provided by Sling and this made > the build fail on Java 8 Ah, that was the missing piece for me. All clear now, thank you. Robert

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.12

2019-11-19 Thread Radu Cotescu
Hi Konrad, > On 19 Nov 2019, at 11:30, Konrad Windszus wrote: > > This is not exactly true. Maybe you can use the > https://bnd.bndtools.org/instructions/conditionalpackage.html > >

RE: [VOTE] Release Apache Sling API 2.21.0

2019-11-19 Thread Stefan Seifert
+1

RE: [VOTE] Release Apache Sling XSS Protection API 2.1.16

2019-11-19 Thread Stefan Seifert
+1

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.12

2019-11-19 Thread Konrad Windszus
Hi Radu, regarding > > the bnd-maven-plugin doesn’t provide an embed / inline feature. This is not exactly true. Maybe you can use the https://bnd.bndtools.org/instructions/conditionalpackage.html instruction? That can be used

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.12

2019-11-19 Thread Radu Cotescu
Hi Robert, > On 19 Nov 2019, at 10:22, Robert Munteanu wrote: > > Sorry for the late reply. I'm not sure I follow. If you inline classes > that require Java 11, doesn't the bundle effectively require Java 11? We haven’t inlined classes that require Java 11 APIs. Let me try to describe again

[jira] [Closed] (SLING-8798) AclLine.getRestrictions should not return null

2019-11-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-8798. -- > AclLine.getRestrictions should not return null > --

[jira] [Closed] (SLING-8740) The repoinit IT is flaky

2019-11-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-8740. -- > The repoinit IT is flaky > > > Key: SLING-8740 >

[jira] [Closed] (SLING-8766) AclVisitor.setPrincipalAcl: be more lenient with unsupported principals

2019-11-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-8766. -- > AclVisitor.setPrincipalAcl: be more lenient with unsupported principals >

[jira] [Closed] (SLING-8778) Missing tests for user/group creation with absolute path

2019-11-19 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-8778. -- > Missing tests for user/group creation with absolute path >

[RESULT] [VOTE] Release Apache Sling Repoinit Parser 1.3.2, Apache Sling Repoinit JCR 1.1.16

2019-11-19 Thread Robert Munteanu
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Radu Cotescu, Dan Klco, Bertrand Delacretaz, Timothée Maret +1 (non-binding): Andreas Schaefer I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.12

2019-11-19 Thread Robert Munteanu
On Fri, 2019-11-15 at 16:50 +0100, Radu Cotescu wrote: > Hi Robert > > > On 15 Nov 2019, at 16:40, Robert Munteanu > > wrote: > > > > Hi Radu, > > > > On Fri, 2019-11-15 at 16:36 +0100, Radu Cotescu wrote: > > > Hi, > > > > > > Builds on Java 8 fail [0] due to how I handled dependency > > >

Re: [VOTE] Release Apache Sling XSS Protection API 2.1.16

2019-11-19 Thread Karl Pauls
+1 regards, Karl On Mon, Nov 18, 2019 at 3:16 PM Radu Cotescu wrote: > > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12346517 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2157/ > > You

Re: [VOTE] Release Apache Sling API 2.21.0

2019-11-19 Thread Karl Pauls
+1 regards, Karl On Tue, Nov 19, 2019 at 5:26 AM Daniel Klco wrote: > > +1 > > On Mon, Nov 18, 2019 at 11:44 AM Radu Cotescu wrote: > > > Hi, > > > > We solved 5 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346487 > > > > Staging repository: > >

[RESULT][VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4

2019-11-19 Thread Simone Tripodi
Hi all, more than 72h have passed and this vote can be considered closed and resolved with the following resolution: Three +1 binding votes from following PMC members: * David Bosschaert * Carsten Ziegeler * Karl Pauls We also got one non-binding vote * Simone Tripodi I will go ahead on