[jira] [Updated] (SLING-9725) Better support for text extensions

2020-09-30 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-9725: Fix Version/s: OSGi Feature Maven Plugin 1.4.2 > Better support for text extensions >

[jira] [Assigned] (SLING-9725) Better support for text extensions

2020-09-30 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-9725: --- Assignee: Carsten Ziegeler > Better support for text extensions >

[jira] [Resolved] (SLING-9778) Handle deprecation info when creating api jars

2020-09-30 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9778. - Resolution: Fixed Added in

[jira] [Created] (SLING-9778) Handle deprecation info when creating api jars

2020-09-30 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9778: --- Summary: Handle deprecation info when creating api jars Key: SLING-9778 URL: https://issues.apache.org/jira/browse/SLING-9778 Project: Sling Issue

[jira] [Resolved] (SLING-9769) Minor memory leak in MapEntries class

2020-09-30 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-9769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-9769. --- Fix Version/s: Resource Resolver 1.7.2 Resolution: Fixed Fixed with [commit

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread GitBox
sonarcloud[bot] removed a comment on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-api/pull/24#issuecomment-701575186 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=24=false=BUG)

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread GitBox
sonarcloud[bot] commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-api/pull/24#issuecomment-701591838 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=24=false=BUG)

[GitHub] [sling-org-apache-sling-api] ghenzler commented on pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread GitBox
ghenzler commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-api/pull/24#issuecomment-701587558 In theory this PR should slightly improve test coverage, however it shows `71.4% Coverage on New Code (is less than 80%)` in

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-30 Thread Georg Henzler
Hi all, so I created the PRs: https://github.com/apache/sling-org-apache-sling-api/pull/25 https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/22 https://github.com/apache/sling-org-apache-sling-engine/pull/10 https://github.com/apache/sling-org-apache-sling-auth-core/pull/6

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #25: SLING-9745 Sling Uri Mapping SPI

2020-09-30 Thread GitBox
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-api/pull/25#issuecomment-701581756 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=25=false=BUG)

[GitHub] [sling-org-apache-sling-engine] ghenzler opened a new pull request #10: SLING-9662 Use SlingUri as provided in request from auth.core

2020-09-30 Thread GitBox
ghenzler opened a new pull request #10: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [sling-org-apache-sling-resourceresolver] ghenzler opened a new pull request #22: SLING-9662 Introduce Resource Mapping SPI

2020-09-30 Thread GitBox
ghenzler opened a new pull request #22: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-auth-core] ghenzler opened a new pull request #6: Feature/sling 9662 introduce sling uri mapping spi v3

2020-09-30 Thread GitBox
ghenzler opened a new pull request #6: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [sling-org-apache-sling-api] ghenzler opened a new pull request #25: SLING-9745 Sling Uri Mapping SPI

2020-09-30 Thread GitBox
ghenzler opened a new pull request #25: URL: https://github.com/apache/sling-org-apache-sling-api/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread GitBox
sonarcloud[bot] commented on pull request #24: URL: https://github.com/apache/sling-org-apache-sling-api/pull/24#issuecomment-701575186 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-api=24=false=BUG)

[GitHub] [sling-org-apache-sling-api] ghenzler opened a new pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread GitBox
ghenzler opened a new pull request #24: URL: https://github.com/apache/sling-org-apache-sling-api/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SLING-9777) Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread Georg Henzler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204952#comment-17204952 ] Georg Henzler commented on SLING-9777: -- The PR for SLING-7000

[jira] [Created] (SLING-9777) Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-09-30 Thread Georg Henzler (Jira)
Georg Henzler created SLING-9777: Summary: Better handling for invalid URIs when using SlingUri (special characters, spaces) Key: SLING-9777 URL: https://issues.apache.org/jira/browse/SLING-9777

[jira] [Resolved] (SLING-9775) Improve JaCoCo code coverage setup

2020-09-30 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9775. - Resolution: Fixed Applied changes in [commit

[GitHub] [sling-parent] raducotescu merged pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
raducotescu merged pull request #11: URL: https://github.com/apache/sling-parent/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [sling-parent] ghenzler commented on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
ghenzler commented on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701429412 > That's already handled by

[GitHub] [sling-parent] kwin edited a comment on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
kwin edited a comment on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701357708 @ghenzler What is the default location? I think you always need to specify that parameter, at least there are no defaults documented in

[GitHub] [sling-parent] kwin commented on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
kwin commented on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701357708 @ghenzler What is the default location? I think you always need to specify that parameter, at least there are no defaults documented in

[GitHub] [sling-parent] raducotescu commented on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
raducotescu commented on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701354169 > I think for > > https://github.com/apache/sling-parent/blob/439bb3f192f51e1cbd69d5b3ae5bdb2c7423c92b/pom.xml#L720 > > we use a non-standard location for the

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #132 is BROKEN

2020-09-30 Thread Apache Jenkins Server
master@tmp/withMaven59efe8bc/maven-spy-20200930-111731-3085210679713915253146.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on project org.apache.sling.launchpad.testing: There are test failures. [ERROR] [ERROR] Please refer to /ho

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-30 Thread Georg Henzler
Hi Carsten, @Georg - I think it would be good if you create PRs, so we can better review and comment on the changes Thanks a lot - I'll quickly cross-test and create a PR this evening (I have an improvement for SlingUri as well, but that's independent) -Georg Regards Carsten Am

[GitHub] [sling-parent] bdelacretaz commented on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
bdelacretaz commented on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701290884 FWIW the existing stuff in the this parent pom is very old and IIRC when I wrote it we didn't use SonarQube yet, it was just meant for developer use. So don't be

[GitHub] [sling-parent] ghenzler commented on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
ghenzler commented on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701289535 I think for https://github.com/apache/sling-parent/blob/439bb3f192f51e1cbd69d5b3ae5bdb2c7423c92b/pom.xml#L720 we use a non-standard location for the full report xml - if we

[jira] [Created] (SLING-9776) Convert sling-scriptingbundle-maven-plugin into Bnd plugin

2020-09-30 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-9776: -- Summary: Convert sling-scriptingbundle-maven-plugin into Bnd plugin Key: SLING-9776 URL: https://issues.apache.org/jira/browse/SLING-9776 Project: Sling

[GitHub] [sling-parent] raducotescu commented on a change in pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
raducotescu commented on a change in pull request #11: URL: https://github.com/apache/sling-parent/pull/11#discussion_r497334990 ## File path: sling-parent/pom.xml ## @@ -555,6 +558,27 @@ +

[jira] [Updated] (SLING-9775) Improve JaCoCo code coverage setup

2020-09-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9775: --- Fix Version/s: (was: Bundle Parent 40) > Improve JaCoCo code coverage setup >

[jira] [Updated] (SLING-9775) Improve JaCoCo code coverage setup

2020-09-30 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-9775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9775: --- Component/s: General > Improve JaCoCo code coverage setup >

[GitHub] [sling-parent] raducotescu commented on pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
raducotescu commented on pull request #11: URL: https://github.com/apache/sling-parent/pull/11#issuecomment-701244572 I've played with the snapshot version of the pom in the GraphQL Core project and I do see the JaCoCo XML report produced i the correct location. This simplifies the setup

[GitHub] [sling-parent] kwin commented on a change in pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

2020-09-30 Thread GitBox
kwin commented on a change in pull request #11: URL: https://github.com/apache/sling-parent/pull/11#discussion_r497332107 ## File path: sling-parent/pom.xml ## @@ -555,6 +558,27 @@ +

[RESULT][VOTE] Release Apache Sling Pipes 4.0.0

2020-09-30 Thread Nicolas Peltier
Hi, the vote passes with 4 binding votes from Carsten, David, Robert, and myself, and a non binding vote from Andreas i'll promote the release and copy the artifacts. Cheers Le lun. 28 sept. 2020 à 21:08, Andreas Schaefer a écrit : > +1 (non-binding) > > - Andy > > > On Sep 25, 2020, at 2:49

Re: [DISCUSS] Sling URI Mapping SPI (was Resource Mapping SPI)

2020-09-30 Thread Carsten Ziegeler
I updated the branch in auth.core to what I believe it should look like. @Georg - I think it would be good if you create PRs, so we can better review and comment on the changes Regards Carsten Am 29.09.2020 um 11:44 schrieb Carsten Ziegeler: Thanks Georg, I had a quick look at the