[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #69: Sling 9397/update removed saml config service

2021-03-02 Thread GitBox
sonarcloud[bot] removed a comment on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-782549342 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https:/

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #69: Sling 9397/update removed saml config service

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #69: URL: https://github.com/apache/sling-whiteboard/pull/69#issuecomment-789267105 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=69&resolved=false&types=BUG) [](https://sonarcl

[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #70: Sling 9397/improve test coverage

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #70: URL: https://github.com/apache/sling-whiteboard/pull/70#issuecomment-789266394 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard&pullRequest=70&resolved=false&types=BUG) [](https://

[GitHub] [sling-whiteboard] cmrockwell merged pull request #70: Sling 9397/improve test coverage

2021-03-02 Thread GitBox
cmrockwell merged pull request #70: URL: https://github.com/apache/sling-whiteboard/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [sling-whiteboard] cmrockwell opened a new pull request #70: Sling 9397/improve test coverage

2021-03-02 Thread GitBox
cmrockwell opened a new pull request #70: URL: https://github.com/apache/sling-whiteboard/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: PAX Help

2021-03-02 Thread Eric Norman
Hi Oliver, Sure I gave it a shot and I stashed the code changes for what I came up with at [1] if you wish to review. Most of the effort was to create a simple tool to scan all the possible features and find out what bundles are included in each of those and then scan each of those bundles to fin

[jira] [Commented] (SLING-10105) Onboard the Apache Sling Scripting SPI bundle to SonarCloud

2021-03-02 Thread Fabrice Bellingard (Jira)
[ https://issues.apache.org/jira/browse/SLING-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293965#comment-17293965 ] Fabrice Bellingard commented on SLING-10105: No worries [~radu], here you go

[GitHub] [sling-org-apache-sling-engine] npeltier merged pull request #13: SLING-10179 better handling of doFilter misusage

2021-03-02 Thread GitBox
npeltier merged pull request #13: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293877#comment-17293877 ] Nicolas Peltier commented on SLING-10179: - and the documentation is https://gith

[GitHub] [sling-site] npeltier opened a new pull request #56: SLING-10179 update Filter doc

2021-03-02 Thread GitBox
npeltier opened a new pull request #56: URL: https://github.com/apache/sling-site/pull/56 - states the necessity of calling doFilter one and only once, - adds exception that would happen otherwise This is an automated mess

[jira] [Assigned] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10179: --- Assignee: Nicolas Peltier > it should be made clearer that calling FilterChain.doFi

[jira] [Updated] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10179: Summary: it should be made clearer that calling FilterChain.doFilter twice must not be don

[jira] [Comment Edited] (SLING-10105) Onboard the Apache Sling Scripting SPI bundle to SonarCloud

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293020#comment-17293020 ] Radu Cotescu edited comment on SLING-10105 at 3/2/21, 4:58 PM: ---

[jira] [Updated] (SLING-9983) Add support for predefined date format styles

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9983: Fix Version/s: Scripting HTL Engine 1.4.8-1.4.0 > Add support for predefined date format styles > -

[jira] [Resolved] (SLING-9983) Add support for predefined date format styles

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9983. - Resolution: Fixed > Add support for predefined date format styles > -

[jira] [Commented] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293830#comment-17293830 ] Radu Cotescu commented on SLING-: - This has now been addressed via the following

[jira] [Resolved] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-. - Resolution: Fixed > Remove cyclic dependency between scripting and servlets features > --

[jira] [Updated] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-: Description: Before {{org.apache.sling.scripting.core.impl.bundled}} and {{org.apache.sling.servle

[jira] [Updated] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-: Description: Before {{org.apache.sling.scripting.core.impl.bundled}} and {{org.apache.sling.servle

[jira] [Updated] (SLING-10105) Onboard the Apache Sling Scripting SPI bundle to SonarCloud

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-10105: - Fix Version/s: (was: Servlets Resolver API 1.0.0) Scripting SPI 1.0.0 > O

[jira] [Updated] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-: Fix Version/s: Scripting SPI 1.0.0 > Remove cyclic dependency between scripting and servlets featur

[jira] [Updated] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-: Fix Version/s: (was: Servlets Resolver API 1.0.0) > Remove cyclic dependency between scripting

[jira] [Resolved] (SLING-10180) Remove dependency to google commons

2021-03-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10180. -- Resolution: Fixed > Remove dependency to google commons >

[jira] [Commented] (SLING-10157) Converter fails with duplicate configuration PIDs

2021-03-02 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293813#comment-17293813 ] Andreas Schaefer commented on SLING-10157: -- [~cziegeler] Yes, that fixed my pro

[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #13: SLING-10179 better handling of doFilter misusage

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/13#issuecomment-789031531 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine&pullRequest=13&resolved=fa

[jira] [Commented] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293805#comment-17293805 ] Nicolas Peltier commented on SLING-10179: - [~cziegeler] code part is there http

[GitHub] [sling-org-apache-sling-engine] npeltier opened a new pull request #13: SLING-10179 better handling of doFilter misusage

2021-03-02 Thread GitBox
npeltier opened a new pull request #13: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/13 - in case doFilter is called more than once by a custom filter, an explicit IllegalStateException will be thrown, instead of an ArrayIndexOutOfBoundsException, - added unit test

[GitHub] [sling-org-apache-sling-resourceresolver] stefanseifert merged pull request #42: SLING-10167 Ensure only valid absolute paths (not ending with "/") are used in JCR queries for loading existin

2021-03-02 Thread GitBox
stefanseifert merged pull request #42: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-02 Thread GitBox
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-788799329 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=7&resolved

[GitHub] [sling-org-apache-sling-auth-core] anchela commented on pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-02 Thread GitBox
anchela commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-788798595 @cziegeler , compared to the original draft attached in jira, i slightly modified the metric names (dropping org.apache) and also added some very limited tes

[GitHub] [sling-org-apache-sling-auth-core] anchela opened a new pull request #7: SLING-10164 : Add basic metrics to SlingAuthenticator

2021-03-02 Thread GitBox
anchela opened a new pull request #7: URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/7 (initial proposal with minimal testing) This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (SLING-10167) MapEntries.loadAliases generets JCR queries with illegal absolute paths

2021-03-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-10167. Resolution: Fixed https://github.com/apache/sling-org-apache-sling-resourceresolver/commit

[jira] [Updated] (SLING-10167) MapEntries.loadAliases generates JCR queries with illegal absolute paths

2021-03-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-10167: --- Summary: MapEntries.loadAliases generates JCR queries with illegal absolute paths (was: Map

[jira] [Commented] (SLING-10157) Converter fails with duplicate configuration PIDs

2021-03-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293628#comment-17293628 ] Carsten Ziegeler commented on SLING-10157: -- [~andysch] I created SLING-10180 -

[jira] [Created] (SLING-10180) Remove dependency to google commons

2021-03-02 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-10180: Summary: Remove dependency to google commons Key: SLING-10180 URL: https://issues.apache.org/jira/browse/SLING-10180 Project: Sling Issue Type: Impro

[jira] [Commented] (SLING-10155) add configuration to include or exclude specific ScriptEngineFactory

2021-03-02 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-10155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293623#comment-17293623 ] Oliver Lietz commented on SLING-10155: -- [~enorman], I'm only aware of scripting eng

Re: PAX Help

2021-03-02 Thread Oliver Lietz
On Tuesday, 2 March 2021 01:04:06 CET Eric Norman wrote: > Hi Oliver, Hi Eric, > I'm not sure about how a "feature model" feature would express dependencies > on other features or whether that is even necessary. > > But as an experiment, I just tried to create a simple aggregate feature > that c

[jira] [Commented] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293597#comment-17293597 ] Carsten Ziegeler commented on SLING-10179: -- [~npeltier] Yes, makes sense to bet

[jira] [Commented] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Nicolas Peltier (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293584#comment-17293584 ] Nicolas Peltier commented on SLING-10179: - it is, [~cziegeler], however the issu

[jira] [Commented] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293569#comment-17293569 ] Carsten Ziegeler commented on SLING-10179: -- [~npeltier] looks like a duplicate

[jira] [Created] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done

2021-03-02 Thread Nicolas Peltier (Jira)
Nicolas Peltier created SLING-10179: --- Summary: it should be clearer that calling FilterChain.doFilter twice must not be done Key: SLING-10179 URL: https://issues.apache.org/jira/browse/SLING-10179 P