[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304635#comment-17304635
]
Ashish Chopra edited comment on SLING-9871 at 3/19/21, 4:29 AM:
hi
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304635#comment-17304635
]
Ashish Chopra edited comment on SLING-9871 at 3/19/21, 4:28 AM:
hi
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304635#comment-17304635
]
Ashish Chopra edited comment on SLING-9871 at 3/19/21, 4:27 AM:
hi
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304635#comment-17304635
]
Ashish Chopra commented on SLING-9871:
--
hi [~enorman],
bq. Do your requirements need more
sonarcloud[bot] removed a comment on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-801067477
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #5:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-802226083
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-802225653
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/7#issuecomment-801068984
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #2:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/2#issuecomment-802154057
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on pull request #2:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/2#issuecomment-802224049
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin=2=false=BUG)
sonarcloud[bot] removed a comment on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-801065985
SonarCloud Quality Gate failed.
sonarcloud[bot] commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-802223307
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver=7=false=BUG)
enapps-enorman edited a comment on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/13#issuecomment-802198643
It's been nearly 2 weeks since this was proposed and over a week since a
review was requested and there has been no feedback from the
enapps-enorman commented on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/13#issuecomment-802198643
It's been nearly 2 weeks since this was proposed and over a week since a
review was requested and there has been no feedback from the community.
[
https://issues.apache.org/jira/browse/SLING-10219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304318#comment-17304318
]
Angela Schreiber commented on SLING-10219:
--
[~karlpauls], initial draft at
sonarcloud[bot] commented on pull request #67:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/67#issuecomment-802158645
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] removed a comment on pull request #67:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/67#issuecomment-802152276
SonarCloud Quality Gate failed.
sonarcloud[bot] commented on pull request #2:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/2#issuecomment-802154057
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-scriptingbundle-maven-plugin=2=false=BUG)
anchela commented on pull request #67:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/67#issuecomment-802153317
@bdelacretaz , in case you are curious to see how i came to report
SLING-10236, you can get a glimpse in the PR. i tried to cover all options
sonarcloud[bot] commented on pull request #67:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/67#issuecomment-802152276
SonarCloud Quality Gate failed.
raducotescu commented on pull request #2:
URL:
https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/2#issuecomment-802151256
@kwin, sorry, didn't realise that the PR will look like this. I expected
that `git` would figure out that most of the files were moved around... The
anchela opened a new pull request #67:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/67
@karlpauls , inital draft for SLING-10219. your review will be very much
appreciated as always
--
This is an automated message from the Apache Git Service.
To
raducotescu opened a new pull request #2:
URL: https://github.com/apache/sling-scriptingbundle-maven-plugin/pull/2
* refactored code to make it more reusable, since there are two drivers now
for generating the Provide and Require Capabilities, namely the `MetadataMojo`
and the
[
https://issues.apache.org/jira/browse/SLING-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-9776:
Summary: Add a BND plugin to the scriptingbundle-maven-plugin (was:
Convert
[
https://issues.apache.org/jira/browse/SLING-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-9776:
Fix Version/s: Scripting Bundle Maven Plugin 0.3.0
> Convert sling-scriptingbundle-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10240:
Description:
Currently we have two different pages on the Sling Site:
#
Konrad Windszus created SLING-10240:
---
Summary: Clean up Sling Content Distribution Documentation
Key: SLING-10240
URL: https://issues.apache.org/jira/browse/SLING-10240
Project: Sling
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-10224.
-
Resolution: Fixed
Ok, thank you very much for your contribution, I have merged
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10224:
Fix Version/s: Feature Model Launcher 1.1.18
> Feature-Launcher: only embed a
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-10224:
---
Assignee: Bertrand Delacretaz
> Feature-Launcher: only embed a minimal
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10224:
Affects Version/s: Feature Model Launcher 1.1.16
> Feature-Launcher: only embed
bdelacretaz merged pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
bdelacretaz merged pull request #20:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
bdelacretaz opened a new pull request #22:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304177#comment-17304177
]
Stefan Bischof edited comment on SLING-10224 at 3/18/21, 2:18 PM:
--
I am
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304177#comment-17304177
]
Stefan Bischof commented on SLING-10224:
I am ready here! No more goals on this.
Really optional
[
https://issues.apache.org/jira/browse/SLING-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304160#comment-17304160
]
Lars Krapf commented on SLING-10225:
Hello [~rombert]
I agree that the fix for SLING-9741, i.e
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10224:
Description:
StringSubstitutor from commons-text is a great Util to replace
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304151#comment-17304151
]
Bertrand Delacretaz commented on SLING-10224:
-
Thanks, yes basically we are just reusing the
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10224:
Summary: Feature-Launcher: only embed a minimal set of apache-commons
classes
[
https://issues.apache.org/jira/browse/SLING-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304125#comment-17304125
]
Angela Schreiber commented on SLING-10238:
--
btw: as far as i could see the same applies for
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304123#comment-17304123
]
Stefan Bischof commented on SLING-10224:
Thank you for the addiitional IT's. espacially that ony
[
https://issues.apache.org/jira/browse/SLING-10224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304123#comment-17304123
]
Stefan Bischof edited comment on SLING-10224 at 3/18/21, 1:00 PM:
--
Angela Schreiber created SLING-10239:
Summary: SetProperty doesn't cover all JCR property types
Key: SLING-10239
URL: https://issues.apache.org/jira/browse/SLING-10239
Project: Sling
Angela Schreiber created SLING-10238:
Summary: PropertyLine.getPropertyType returns String even if no
type was specified
Key: SLING-10238
URL: https://issues.apache.org/jira/browse/SLING-10238
Angela Schreiber created SLING-10237:
Summary: NodePropertiesVisitor.convertToValue does not use
ValueFactory
Key: SLING-10237
URL: https://issues.apache.org/jira/browse/SLING-10237
Project:
cziegeler commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-801880735
Looks ok to me, except I would prefer using constructor injection as
mentioned
This is
cziegeler commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596813783
##
File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
##
@@ -363,6 +369,8 @@ private void
anchela commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-801874327
@bdelacretaz , @rombert thanks a lot for reviewing.
@cziegeler , would you have time to also take a look in particular wrt the
comment added by @rombert ,
karlpauls edited a comment on pull request #66:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/66#issuecomment-801827008
@kwin, I don't know why the test fails, but the reason was for sure that it
was confusing is that it was getting a hidden nullpointer. I
karlpauls commented on pull request #66:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/66#issuecomment-801827008
@kwin, I don't know why the test fails, but the reason was for sure that it
was confusing is that it was getting a hidden nullpointer. I pushed
[
https://issues.apache.org/jira/browse/SLING-9871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304039#comment-17304039
]
Bertrand Delacretaz commented on SLING-9871:
bq. I'm not sure how we would be able to
[
https://issues.apache.org/jira/browse/SLING-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10233:
---
Assignee: (was: Konrad Windszus)
> Optionally split mixed content packages
[
https://issues.apache.org/jira/browse/SLING-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10233:
---
Assignee: Konrad Windszus
> Optionally split mixed content packages into mutable
kwin commented on pull request #66:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/66#issuecomment-801800737
The test
`ContentPackage2FeatureModelConverterTest.filteredOutContentPackagesAreExcludedDependencies()`
now fails with an NPE and I don't really
kwin opened a new pull request #66:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SLING-10236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304011#comment-17304011
]
Bertrand Delacretaz commented on SLING-10236:
-
I see the idea but that might not be trivial
[
https://issues.apache.org/jira/browse/SLING-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304006#comment-17304006
]
Robert Munteanu commented on SLING-10225:
-
I agree that allowing to upload a file and then
[
https://issues.apache.org/jira/browse/SLING-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-10235.
-
Resolution: Fixed
Makes sense, I have added the missing
[
https://issues.apache.org/jira/browse/SLING-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10235:
Summary: DisableServiceUser does not allow to retrieve original
disable-reason
[
https://issues.apache.org/jira/browse/SLING-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10235:
Fix Version/s: Repoinit Parser 1.6.8
> DisableServiceUser does not allow to
[
https://issues.apache.org/jira/browse/SLING-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-10235:
---
Assignee: Bertrand Delacretaz
> DisableServiceUser does not allow to
[
https://issues.apache.org/jira/browse/SLING-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-10235:
Affects Version/s: Repoinit Parser 1.6.6
> DisableServiceUser does not allow to
Hi Stefan,
On Fri, 2021-03-12 at 17:28 +0100, Stefan Bischof wrote:
> Hi Robert,
>
> i think there would be 2 main use cases.
>
> 1. Develop with bnd (EclipseBndTools or just bnd-maven-plugin) and
> having an bnd repository or bndrun file for launching or testing.
> Then
> this should help
Angela Schreiber created SLING-10236:
Summary: Introduce Operation.asRepoInitString
Key: SLING-10236
URL: https://issues.apache.org/jira/browse/SLING-10236
Project: Sling
Issue Type:
Angela Schreiber created SLING-10235:
Summary: DisableServiceUser does not allow to retriev original
disable-reason
Key: SLING-10235
URL: https://issues.apache.org/jira/browse/SLING-10235
[
https://issues.apache.org/jira/browse/SLING-10053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303963#comment-17303963
]
Robert Munteanu commented on SLING-10053:
-
This is becoming more important as the plug-in does
bdelacretaz commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-801760739
@anchela thank your for your changes, looks good to me!
This is an automated message
bdelacretaz commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596674778
##
File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
##
@@ -457,6 +465,11 @@ private void
Konrad Windszus created SLING-10234:
---
Summary: Recalculate package type for converted packages
Key: SLING-10234
URL: https://issues.apache.org/jira/browse/SLING-10234
Project: Sling
Issue
anchela commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-801706283
@bdelacretaz , let me know if the changes made address your findings.
This is an automated
sonarcloud[bot] commented on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-801706303
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=7=false=BUG)
sonarcloud[bot] removed a comment on pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#issuecomment-788799329
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=7=false=BUG)
anchela commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596616752
##
File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
##
@@ -492,15 +507,17 @@ public boolean
anchela commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596616412
##
File path:
src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticationMetrics.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to
anchela commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/7#discussion_r596608245
##
File path: src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
##
@@ -457,6 +465,13 @@ private void
Konrad Windszus created SLING-10233:
---
Summary: Optionally split mixed content packages into mutable and
immutable ones
Key: SLING-10233
URL: https://issues.apache.org/jira/browse/SLING-10233
kwin merged pull request #57:
URL: https://github.com/apache/sling-site/pull/57
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
78 matches
Mail list logo
