+1
Carsten
Am 11.05.2022 um 16:58 schrieb Carsten Ziegeler:
Hi,
we solved 4 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351355
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2635/
You can use this UNIX script to
reschke commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r870968391
##
pom.xml:
##
@@ -40,46 +39,28 @@
scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-jcr-webdav.git
ashokmca07 commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#issuecomment-1124541239
Hi @rombert thanks for reviewing, Could you please review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#issuecomment-1124539297
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
I clarified the documentation in
https://github.com/apache/sling-site/commit/cb12f47c7b55bd03ccf0951c112df68a40d67fd2
and added a link to
https://docs.osgi.org/specification/osgi.core/8.0.0/framework.service.html#framework.service.servicerankingorder
The according code is IMHO in
? not sure what you mean. I agreed to use service ranking, and service
ranking is the whole mechanism including what happens if that property
is not specified. ServiceReference has a compareTo method that does all
of that.
Carsten
Am 11.05.2022 um 17:37 schrieb Konrad Windszus:
Why doing it
The behaviour is predictable, *if* service ranking is used. Thats the
reason for this property :) Agreed, if not, then you are back to
installation order which is not predictable.
Now, if there are overlapping servlet registrations where some of them
are ignored, yes, we should log warnings.
Why doing it differently than for any other OSGi service?
Although the service ID is not predictable in general older services beat newer
services, which is IMHO good enough.
I am fine with issuing a warn (if easy to implement) but I am against rejecting
for consistency reasons.
Konrad
> On
Le mer. 11 mai 2022 à 17:32, Konrad Windszus a écrit :
> ...Service IDs are always unique, so this mechanism will always establish one
> winner!..
Yes, but that winner is not predictable from the programmer's point of
view, that's why I'd like us to reject cases where it's the Service ID
that
Just look at
http://docs.osgi.org/javadoc/r4v43/core/org/osgi/framework/BundleContext.html#getServiceReference(java.lang.Class)
"If multiple such services exist, the service with the highest ranking (as
specified in its Constants.SERVICE_RANKING property) is returned.
If there is a tie in
[
https://issues.apache.org/jira/browse/SLING-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534968#comment-17534968
]
Konrad Windszus commented on SLING-11315:
-
For the case listed in this issue only the last
Hi,
Le mer. 11 mai 2022 à 17:23, Carsten Ziegeler a écrit :
> ...Service ranking is more predictable than just using the "first"...
I agree, but what if two servlets have the exact same service
parameters including service ranking?
That's what I think we should reject.
-Bertrand
[
https://issues.apache.org/jira/browse/SLING-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534965#comment-17534965
]
Bertrand Delacretaz commented on SLING-11315:
-
The docs that you mention are about multiple
[
https://issues.apache.org/jira/browse/SLING-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534961#comment-17534961
]
Konrad Windszus commented on SLING-11315:
-
IMHO this should not trigger an error but the servlet
+1 to what Konrad said.
Service ranking is more predictable than just using the "first"
Regards
Carsten
Am 11.05.2022 um 17:18 schrieb Konrad Windszus:
IMHO the regular OSGi semantics should apply here as well, i.e. higher service
ranking wins (if tie lower bundle id wins). That is also
IMHO the regular OSGi semantics should apply here as well, i.e. higher service
ranking wins (if tie lower bundle id wins). That is also documented at
https://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-resolution-order
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-datasource/pull/2#issuecomment-1123916317
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
[
https://issues.apache.org/jira/browse/SLING-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534950#comment-17534950
]
Bertrand Delacretaz edited comment on SLING-11315 at 5/11/22 3:14 PM:
Hi,
I forgot if we discussed this already, if that's the case pointers are welcome.
Adrian Kozma created SLING-11315 about this, and I tentatively added a
new test [1] to explore the current behavior.
It looks like the first registered servlet wins, but that might be
just by chance.
Do people
[
https://issues.apache.org/jira/browse/SLING-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534950#comment-17534950
]
Bertrand Delacretaz commented on SLING-11315:
-
I have tentatively added [a new
sonarcloud[bot] commented on PR #17:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/17#issuecomment-1123904225
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
dependabot[bot] opened a new pull request, #17:
URL:
https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/17
Bumps commons-io from 2.6 to 2.7.
[![Dependabot compatibility
Hi,
we solved 4 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12351355
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2635/
You can use this UNIX script to download the release and verify the
signatures:
[
https://issues.apache.org/jira/browse/SLING-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-11314.
--
Resolution: Fixed
Added new api in
Adrian Kozma created SLING-11315:
Summary: Reject duplicate servlet mount configurations
Key: SLING-11315
URL: https://issues.apache.org/jira/browse/SLING-11315
Project: Sling
Issue Type:
anchela commented on PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/24#issuecomment-1123806452
btw: sonar complaining about missing test coverage is caused by overall low
coverage. whenever existing code is modified sonar will spot that it doesn't
match
sonarcloud[bot] commented on PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/24#issuecomment-1123805060
SonarCloud Quality Gate failed. [![Quality Gate
Carsten Ziegeler created SLING-11314:
Summary: Enhance API with methods to simply check if a
configuration is private
Key: SLING-11314
URL: https://issues.apache.org/jira/browse/SLING-11314
On Mon, 2022-05-09 at 10:48 -0700, Eric Norman wrote:
> Hi Oliver,
>
> I was not the one who opened the SLING-8309 ticket but I personally
> don't
> need it to remain open as the changes from SLING-9719 do everything I
> need.
>
> It's been a while since there was any activity on SLING-8309 so
rombert commented on PR #59:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/59#issuecomment-1123739379
@jsedding - I think this can closed, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sonarcloud[bot] commented on PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/24#issuecomment-1123730461
SonarCloud Quality Gate failed. [![Quality Gate
Hi,
With the recent changes for SLING-7935 [1] all the launchpad
integration tests are executed with a `mvn clean verify` call inside
the main Sling Starter.
This makes the launchpad-testing [2] module redundant. I intend to
deprecate the module on Friday.
Please let me know if you have any
[
https://issues.apache.org/jira/browse/SLING-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534875#comment-17534875
]
Robert Munteanu commented on SLING-7935:
The main changes are in, all that is left IMO is to
anchela commented on PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/24#issuecomment-1123718239
@cziegeler , @joerghoh initial set of changes without addressing complexity
findings.
please note the additional check for data being null added in
sonarcloud[bot] commented on PR #24:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/24#issuecomment-1123716883
SonarCloud Quality Gate failed. [![Quality Gate
rombert merged PR #66:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Robert Munteanu created SLING-11313:
---
Summary: Trigger Jenkins builds for the master branch and PRs only
Key: SLING-11313
URL: https://issues.apache.org/jira/browse/SLING-11313
Project: Sling
sonarcloud[bot] commented on PR #66:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/66#issuecomment-1123635798
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/1065/
for details.
No further emails will be sent until the status of the build is changed.
--
[INFO] [jenkins-event-spy] Generated
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven1f516239/maven-spy-20220511-111723-9922685543862525837966.log
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on
project org.
[
https://issues.apache.org/jira/browse/SLING-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11311:
-
Description:
while working on SLING-10011 i noticed a considerable amount of issues
[
https://issues.apache.org/jira/browse/SLING-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-11311:
-
Summary: Improve org-apache-sling-jcr-resource (was: Address sonar
findings)
>
ashokmca07 commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1123579627
Hi @rombert yes, I am still working on them. will release them once complete
testing is done ✅
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SLING-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11303.
-
Assignee: Robert Munteanu
Resolution: Fixed
PR merged, thanks
rombert merged PR #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-logservice/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-commons-testing/pull/2#issuecomment-1123458994
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
rombert commented on code in PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-extensions-slf4j-mdc/pull/1#discussion_r870094139
##
bnd.bnd:
##
@@ -0,0 +1,6 @@
+-includeresource:\
Review Comment:
We no longer use this dependency, this should be removed.
[
https://issues.apache.org/jira/browse/SLING-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11302.
-
Resolution: Fixed
PR merged, thanks [~ashokmc...@gmail.com]!
> Update webconsole
[
https://issues.apache.org/jira/browse/SLING-11302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11302:
---
Assignee: Robert Munteanu
> Update webconsole branding bundle to parent 47
>
dependabot[bot] opened a new pull request, #2:
URL: https://github.com/apache/sling-org-apache-sling-commons-testing/pull/2
Bumps commons-io from 1.4 to 2.7.
[![Dependabot compatibility
rombert merged PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-serviceuser-webconsole/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rombert commented on code in PR #2:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-webdav/pull/2#discussion_r870089157
##
pom.xml:
##
@@ -178,9 +155,35 @@
2.0.8
provided
+
+
junit
junit
rombert commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-base/pull/7#issuecomment-1123430789
@ashokmca07 - you have a number of draft PRs against the discovery bundles.
I won't review merge those, this is a heads-up to make sure that this is
intended
[
https://issues.apache.org/jira/browse/SLING-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-11309.
-
Resolution: Fixed
PR merged, thanks [~ashokmc...@gmail.com]!
> Update
[
https://issues.apache.org/jira/browse/SLING-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-11309:
---
Assignee: Robert Munteanu
> Update sling.commons.testing to parent 47
>
rombert merged PR #1:
URL: https://github.com/apache/sling-org-apache-sling-commons-testing/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rombert commented on PR #1:
URL:
https://github.com/apache/sling-org-apache-sling-commons-testing/pull/1#issuecomment-1123428013
Thanks for the PR @ashokmca07 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber resolved SLING-10011.
--
Resolution: Fixed
> Use JackrabbitSession.getParentOrNull when resolving parent JCR
[
https://issues.apache.org/jira/browse/SLING-10011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber reassigned SLING-10011:
Assignee: Angela Schreiber (was: Joerg Hoh)
> Use
anchela merged PR #23:
URL: https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Angela Schreiber created SLING-11312:
Summary: Improve test coverage
Key: SLING-11312
URL: https://issues.apache.org/jira/browse/SLING-11312
Project: Sling
Issue Type: Improvement
Angela Schreiber created SLING-11311:
Summary: Address sonar findings
Key: SLING-11311
URL: https://issues.apache.org/jira/browse/SLING-11311
Project: Sling
Issue Type: Improvement
+1
> On 10 May 2022, at 17:24, Carsten Ziegeler wrote:
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
sonarcloud[bot] commented on PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1123373844
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
anchela commented on PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1123320364
@cziegeler , thanks. then i am only waiting for your approval in the
mean time i added a test for JcrResourceProvider.getParent. there was
none.
sonarcloud[bot] commented on PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/23#issuecomment-1123320056
SonarCloud Quality Gate failed. [