[GitHub] [sling-org-apache-sling-jcr-base] cziegeler closed pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms

2023-02-27 Thread via GitHub
cziegeler closed pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #7: [SLING-11741] Provide alternative terminology for inequitable terms

2023-02-27 Thread via GitHub
cziegeler commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/7#issuecomment-1447713439 Closing due to updated PR #9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [sling-org-apache-sling-jcr-base] cziegeler commented on pull request #9: [SLING-11741] Provide alternative terminology for inequitable terms

2023-02-27 Thread via GitHub
cziegeler commented on PR #9: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/9#issuecomment-1447712973 @cristic83 Thanks for the updated patch; it looks good to me. Minor note: you can remove the "perm" file as we are not using OSGi permissions within Sling.

[jira] [Reopened] (SLING-11690) Onboard Commons Permissions to SonarCloud

2023-02-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz reopened SLING-11690: -- Assignee: Fabrice Bellingard (was: Oliver Lietz) [~bellingard], Could you please check the

[jira] [Commented] (SLING-10900) Update graphl-java to version 17

2023-02-27 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694235#comment-17694235 ] Andreas Schaefer commented on SLING-10900: -- After testing with AEM this is the current state:

[GitHub] [sling-org-apache-sling-graphql-core] schaefa opened a new pull request, #34: SLING-10900 - Upgrade graphql-java to 19.3

2023-02-27 Thread via GitHub
schaefa opened a new pull request, #34: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/34 Adjusted the Selection Set and Selected Field Wrapers as well as its tests. Added antlr runtime to the maven dependencies and fix a test due to changes in graphql-java.

[jira] [Resolved] (SLING-11254) Make additional authorization on HTTP scan endpoint mandatory

2023-02-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11254. -- Resolution: Done > Make additional authorization on HTTP scan endpoint mandatory >

[jira] [Resolved] (SLING-11788) Provide Commons Permissions Sling feature

2023-02-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11788. -- Resolution: Done > Provide Commons Permissions Sling feature >

[jira] [Resolved] (SLING-11787) Provide Commons Permissions feature

2023-02-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11787. -- Resolution: Done > Provide Commons Permissions feature > ---

[jira] [Resolved] (SLING-11791) Provide Commons Permissions Sling Option

2023-02-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11791. -- Resolution: Done > Provide Commons Permissions Sling Option >

[jira] [Resolved] (SLING-11790) Provide Commons Permissions Option

2023-02-27 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-11790. -- Resolution: Done > Provide Commons Permissions Option > -- >

[jira] [Created] (SLING-11790) Provide Commons Permissions Option

2023-02-27 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-11790: Summary: Provide Commons Permissions Option Key: SLING-11790 URL: https://issues.apache.org/jira/browse/SLING-11790 Project: Sling Issue Type: New Feature

[jira] [Created] (SLING-11791) Provide Commons Permissions Sling Option

2023-02-27 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-11791: Summary: Provide Commons Permissions Sling Option Key: SLING-11791 URL: https://issues.apache.org/jira/browse/SLING-11791 Project: Sling Issue Type: New

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #161: SLING-11421 Use FileVault serialization classes for generating enhanced

2023-02-27 Thread via GitHub
sonarcloud[bot] commented on PR #161: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/161#issuecomment-1446349381 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

2023-02-27 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694033#comment-17694033 ] Stefan Seifert commented on SLING-11785: great, this works and solves the issue! > cpconverter:

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

2023-02-27 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694007#comment-17694007 ] Konrad Windszus commented on SLING-11785: - Thanks, the reason is that

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

2023-02-27 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693991#comment-17693991 ] Stefan Seifert commented on SLING-11785: i've added a corresponding test case to your PR branch:

[GitHub] [sling-org-apache-sling-testing-jcr-mock] stefanseifert commented on pull request #12: SLING-11789 MockNode#orderBefore incorrectly removes nodes

2023-02-27 Thread via GitHub
stefanseifert commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/12#issuecomment-1446159710 good catch, thanks for fixing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

2023-02-27 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693968#comment-17693968 ] Konrad Windszus commented on SLING-11785: - [~sseifert] So basically this boils down to the

[jira] [Comment Edited] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

2023-02-27 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693967#comment-17693967 ] Stefan Seifert edited comment on SLING-11785 at 2/27/23 11:14 AM: --

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

2023-02-27 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693967#comment-17693967 ] Stefan Seifert commented on SLING-11785: [~kwin] thanks! - but does not work for me yet. steps