[GitHub] [sling-org-apache-sling-event] andrewmkhoury commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-04-29 Thread via GitHub
andrewmkhoury commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181150864 ## src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java: ## @@ -84,6 +84,22 @@ public void updateProgress(final

[GitHub] [sling-org-apache-sling-event] andrewmkhoury commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-04-29 Thread via GitHub
andrewmkhoury commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181003628 ## src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java: ## @@ -84,6 +84,22 @@ public void updateProgress(final

[GitHub] [sling-org-apache-sling-event] andrewmkhoury commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-04-29 Thread via GitHub
andrewmkhoury commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181148682 ## src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java: ## @@ -84,6 +84,22 @@ public void updateProgress(final

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #11: Bump org.apache.sling.jcr.base from 3.0.2 to 3.1.12

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/11#issuecomment-1528857348 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-1528857279 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #7: Bump org.apache.sling.servlets.post from 2.3.0 to 2.3.8

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/7#issuecomment-1528857304 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #6: Bump plexus-utils from 3.0.9 to 3.0.16

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #6: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/6#issuecomment-1528857267 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #8: Bump org.apache.sling.api from 2.3.0 to 2.25.4

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #8: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/8#issuecomment-1528857166 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #12: Bump logback-classic from 1.1.2 to 1.2.0

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/12#issuecomment-1528857155 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #14: Bump commons-io from 2.5 to 2.7

2023-04-29 Thread via GitHub
sonarcloud[bot] commented on PR #14: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/14#issuecomment-1528857131 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-event] kwin commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-04-29 Thread via GitHub
kwin commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181019895 ## src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java: ## @@ -84,6 +84,22 @@ public void updateProgress(final long eta)

[GitHub] [sling-org-apache-sling-event] andrewmkhoury commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-04-29 Thread via GitHub
andrewmkhoury commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181003628 ## src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java: ## @@ -84,6 +84,22 @@ public void updateProgress(final

[GitHub] [sling-org-apache-sling-event] andrewmkhoury commented on a diff in pull request #26: SLING-11831 - Allow setting job properties for custom job state

2023-04-29 Thread via GitHub
andrewmkhoury commented on code in PR #26: URL: https://github.com/apache/sling-org-apache-sling-event/pull/26#discussion_r1181003628 ## src/main/java/org/apache/sling/event/impl/jobs/queues/JobExecutionContextImpl.java: ## @@ -84,6 +84,22 @@ public void updateProgress(final