Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.2.13 [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
sonarcloud[bot] commented on PR #49: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/49#issuecomment-2128478041 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12264 only call save() if there's something to save [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
sonarcloud[bot] commented on PR #52: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/52#issuecomment-2128474929 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
sonarcloud[bot] commented on PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#issuecomment-2128474359 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]

2024-05-23 Thread via GitHub
jsedding commented on code in PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611777912 ## src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrInstaller.java: ## @@ -707,6 +716,7 @@ private UpdateResult

[jira] [Created] (SLING-12324) Referrer Filter Reference Policy Should be Dynamic

2024-05-23 Thread Dan Klco (Jira)
Dan Klco created SLING-12324: Summary: Referrer Filter Reference Policy Should be Dynamic Key: SLING-12324 URL: https://issues.apache.org/jira/browse/SLING-12324 Project: Sling Issue Type:

[jira] [Closed] (SLING-9061) Evaluate ORIGIN header in addition to Referer header in ReferrerFilter

2024-05-23 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-9061. --- > Evaluate ORIGIN header in addition to Referer header in ReferrerFilter >

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
jsedding merged PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: parent pom 60 & requirement to use java17 for builds

2024-05-23 Thread Robert Munteanu
On Thu, 2024-05-23 at 09:10 +, Stefan Seifert wrote: > konrad provided this wiki page with hints for update to parent 60+: > https://cwiki.apache.org/confluence/x/SI75E > > you have to remove java 11 from .sling-module.json during the update, > or add one like this if it does not exist: >

Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]

2024-05-23 Thread via GitHub
jsedding commented on code in PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#discussion_r1611600431 ## src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java: ## @@ -92,6 +92,9 @@

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
jsedding commented on code in PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611598811 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java: ## @@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
jsedding commented on code in PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611596184 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java: ## @@ -118,42 +116,25 @@ public NodePropertiesVisitor(Session

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
joerghoh commented on code in PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611590909 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java: ## @@ -118,42 +116,25 @@ public NodePropertiesVisitor(Session

June 2023 board report draft

2024-05-23 Thread Robert Munteanu
Hi, I plan to submit the following report on Monday. Feedback welcome, Thanks, Robert --- ## Description: Apache Sling™ is a framework for RESTful web-applications based on an extensible content tree. ## Project Status: Current project status: Ongoing, with moderate activity. Issues for the

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1385 is BROKEN

2024-05-23 Thread Apache Jenkins Server
/withMavene96920ff/maven-spy-20240523-111954-9561484458592001243620.log [ERROR] Failed to execute goal org.apache.sling:feature-launcher-maven-plugin:0.1.6:start (default) on project org.apache.sling.starter: Launch sling-starter-oak-tar failed to start in 120 seconds. -> [Hel

Re: [PR] SLING-12262 use a metric to indicate repoinit failures [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
joerghoh commented on code in PR #51: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/51#discussion_r1599049824 ## pom.xml: ## @@ -158,6 +158,12 @@ 4.3.1 test + +org.apache.sling +

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
sonarcloud[bot] commented on PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126808416 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
jsedding commented on code in PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611427296 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java: ## @@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session

Re: [PR] SLING-12283 : write config in correct format incase of factoryPid is … [sling-org-apache-sling-installer-provider-jcr]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #9: URL: https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/9#discussion_r1611358227 ## src/main/java/org/apache/sling/installer/provider/jcr/impl/JcrUtil.java: ## @@ -73,4 +75,21 @@ public static Node

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
reschke commented on code in PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#discussion_r1611357821 ## src/main/java/org/apache/sling/jcr/repoinit/impl/NodePropertiesVisitor.java: ## @@ -118,23 +116,25 @@ public NodePropertiesVisitor(Session

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
sonarcloud[bot] commented on PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126642430 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

RE: parent pom 60 & requirement to use java17 for builds

2024-05-23 Thread Stefan Seifert
konrad provided this wiki page with hints for update to parent 60+: https://cwiki.apache.org/confluence/x/SI75E you have to remove java 11 from .sling-module.json during the update, or add one like this if it does not exist:

Re: [PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
sonarcloud[bot] commented on PR #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53#issuecomment-2126609772 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] SLING-12323 - [RepoInit] Avoid java.nio.file.Path for parsing repository paths [sling-org-apache-sling-jcr-repoinit]

2024-05-23 Thread via GitHub
jsedding opened a new pull request, #53: URL: https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/53 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [VOTE] Release Apache Sling JCR Resource 3.3.2

2024-05-23 Thread Jörg Hoh
+1 Am Mo., 20. Mai 2024 um 18:03 Uhr schrieb Radu Cotescu : > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354675=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2861/ >

[jira] [Created] (SLING-12323) [RepoInit] Avoid java.nio.file.Path for parsing repository paths

2024-05-23 Thread Julian Sedding (Jira)
Julian Sedding created SLING-12323: -- Summary: [RepoInit] Avoid java.nio.file.Path for parsing repository paths Key: SLING-12323 URL: https://issues.apache.org/jira/browse/SLING-12323 Project: Sling

[PR] SLING-12321 update parent to 60 [sling-org-apache-sling-engine]

2024-05-23 Thread via GitHub
joerghoh opened a new pull request, #46: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/46 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.