[jira] [Commented] (SLING-5731) Export the org.mozilla.javascript.tools package in org.apache.sling.scripting.javascript bundle

[ https://issues.apache.org/jira/browse/SLING-5731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933431#comment-15933431 ] Rob Ryan commented on SLING-5731: - I'm sorry I didn't keep a record, of what happens with a second export

[jira] [Created] (SLING-6561) Proposed test case for SLING-6271

Rob Ryan created SLING-6561: --- Summary: Proposed test case for SLING-6271 Key: SLING-6561 URL: https://issues.apache.org/jira/browse/SLING-6561 Project: Sling Issue Type: Bug Components

[jira] [Created] (SLING-6296) DefaultThreadPool causes warning when minPoolSize == 0

Rob Ryan created SLING-6296: --- Summary: DefaultThreadPool causes warning when minPoolSize == 0 Key: SLING-6296 URL: https://issues.apache.org/jira/browse/SLING-6296 Project: Sling Issue Type: Bug

[jira] [Commented] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

[ https://issues.apache.org/jira/browse/SLING-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655391#comment-15655391 ] Rob Ryan commented on SLING-6271: - [~asanso] Can you review these and let me know which approach you favor

[jira] [Updated] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

[ https://issues.apache.org/jira/browse/SLING-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-6271: Attachment: simple.patch.txt > ContentDispositionFilter can suppress content type upon request forward

[jira] [Updated] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

[ https://issues.apache.org/jira/browse/SLING-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-6271: Attachment: conservative.patch.txt > ContentDispositionFilter can suppress content type upon requ

[jira] [Issue Comment Deleted] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

[ https://issues.apache.org/jira/browse/SLING-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-6271: Comment: was deleted (was: conservative case.) > ContentDispositionFilter can suppress content type u

[jira] [Updated] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

[ https://issues.apache.org/jira/browse/SLING-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-6271: Attachment: (was: p1.txt) > ContentDispositionFilter can suppress content type upon request forward

[jira] [Updated] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

[ https://issues.apache.org/jira/browse/SLING-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-6271: Attachment: p1.txt conservative case. > ContentDispositionFilter can suppress content type upon requ

[jira] [Created] (SLING-6271) ContentDispositionFilter can suppress content type upon request forwarding

Rob Ryan created SLING-6271: --- Summary: ContentDispositionFilter can suppress content type upon request forwarding Key: SLING-6271 URL: https://issues.apache.org/jira/browse/SLING-6271 Project: Sling

[jira] [Commented] (SLING-6257) Sling IDE: Debugging: Thread interrupted for every uncaught exception

[ https://issues.apache.org/jira/browse/SLING-6257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650077#comment-15650077 ] Rob Ryan commented on SLING-6257: - It is unfortunate though that the thread pooling (in at least some part

[jira] [Commented] (SLING-4604) Multiple Content-Disposition headers added

[ https://issues.apache.org/jira/browse/SLING-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648309#comment-15648309 ] Rob Ryan commented on SLING-4604: - Without more detail I can't really recommend adding

[jira] [Commented] (SLING-4604) Multiple Content-Disposition headers added

[ https://issues.apache.org/jira/browse/SLING-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648079#comment-15648079 ] Rob Ryan commented on SLING-4604: - *If* content-type is being reset to the same value it has already been

[jira] [Commented] (SLING-6219) Allow to create users with repoinit

[ https://issues.apache.org/jira/browse/SLING-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623495#comment-15623495 ] Rob Ryan commented on SLING-6219: - The value in the password field is not *just* SHA-256 BTW

[jira] [Commented] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606111#comment-15606111 ] Rob Ryan commented on SLING-6187: - Thanks, sorry my confusion. > Provide a way for a POST requ

[jira] [Commented] (SLING-6187) Provide a way for a POST request to assert a set of required SlingPostProcessors

[ https://issues.apache.org/jira/browse/SLING-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606079#comment-15606079 ] Rob Ryan commented on SLING-6187: - A single monolithic list is probably not the best thing here, maybe

Re: [context-aware config] performance impact of inhertiance

My experience is that looking up the ancestors of a node for property inheritance does indeed have a significant performance impact. My experience was in the realm of: https://docs.adobe.com/docs/en/cq/5-6-1/developing/cloud-service-configurations.html

[RHINO] SLING-5731: org.mozilla.javascript.tools (Rhino) package export

to provide another export of Rhino. In particular some Sightly components break if they don't get the Rhino engine that is properly configured for them. Is it feasible to update the export list to include the tools package? A patch is attached to the bug. Thanks for your attention in any case, -Rob

Re: Resource.getParent() on NonExistingResource

Regardless of what other problem may exist; involving resolve() in getParent() isn't a solution. Resolve() operates on _URI_ paths. Not on resource paths. So proposing to involve resolve() in an implementation of getParent() doesn't make sense. Resolve() makes special considerations of some

[jira] [Commented] (SLING-5355) Create service users and ACLs from the provisioning model

[ https://issues.apache.org/jira/browse/SLING-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083209#comment-15083209 ] Rob Ryan commented on SLING-5355: - Anyone who can change a config can make any or all users 'admin' anyway

[jira] [Commented] (SLING-4883) Extend content disposition filter protection to jcr:data

[ https://issues.apache.org/jira/browse/SLING-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633760#comment-14633760 ] Rob Ryan commented on SLING-4883: - Looks good to me, thanks! Extend content disposition

[jira] [Commented] (SLING-3829) Add support for Content-Disposition attachment

[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490309#comment-14490309 ] Rob Ryan commented on SLING-3829: - [~asanso] in thinking about this filter I don't think

[jira] [Comment Edited] (SLING-3829) Add support for Content-Disposition attachment

[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490309#comment-14490309 ] Rob Ryan edited comment on SLING-3829 at 4/10/15 8:32 PM

[jira] [Comment Edited] (SLING-3829) Add support for Content-Disposition attachment

[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490309#comment-14490309 ] Rob Ryan edited comment on SLING-3829 at 4/10/15 8:33 PM

[jira] [Comment Edited] (SLING-3829) Add support for Content-Disposition attachment

[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490309#comment-14490309 ] Rob Ryan edited comment on SLING-3829 at 4/10/15 8:32 PM

[jira] [Comment Edited] (SLING-3829) Add support for Content-Disposition attachment

[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490309#comment-14490309 ] Rob Ryan edited comment on SLING-3829 at 4/10/15 8:32 PM

[jira] [Comment Edited] (SLING-3829) Add support for Content-Disposition attachment

[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490309#comment-14490309 ] Rob Ryan edited comment on SLING-3829 at 4/10/15 8:32 PM

[jira] [Updated] (SLING-4604) Multiple Content-Disposition headers added

[ https://issues.apache.org/jira/browse/SLING-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-4604: Attachment: 4604patch.txt the attached patch fixes the extra disposition headers and avoids running

[jira] [Created] (SLING-4604) Multiple Content-Disposition headers added

Rob Ryan created SLING-4604: --- Summary: Multiple Content-Disposition headers added Key: SLING-4604 URL: https://issues.apache.org/jira/browse/SLING-4604 Project: Sling Issue Type: Bug

RE: XSS protection path mangling issue: Bug or not?

Yes this is a bug IMO, please file an issue. The query string contents have no business influencing the spelling of the url path elements. -Rob Ryan Working for, but not speaking for Adobe. -Original Message- From: Georg Köster [mailto:m...@georgkoester.de] Sent: Thursday, March 19

RE: [Sightly] provide access to the Script Resource Resolver in RenderContext

I share Felix's concern. If the ServletResolver's resolver is passed around, please ensure it is a service user with minimal permissions required for ServletResolver's needs. We do *not* want to allow a resolver passed around from the ServletResolver to be abused for accessing general

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215114#comment-14215114 ] Rob Ryan commented on SLING-3844: - Desired effect is achieved, no appreciable time

[jira] [Updated] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-3844: Attachment: post3844.csv performance test after r1640141 applied Resolver.map() spends too much time

[jira] [Updated] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-3844: Attachment: pre3844.csv performance test before r1640141 was applied. Resolver.map() spends too much

[jira] [Created] (SLING-4101) SlingAnnotationsTestRunner doesn't work with SlingRemoteExecutionRule

Rob Ryan created SLING-4101: --- Summary: SlingAnnotationsTestRunner doesn't work with SlingRemoteExecutionRule Key: SLING-4101 URL: https://issues.apache.org/jira/browse/SLING-4101 Project: Sling

[jira] [Updated] (SLING-2219) SlingAnnotationsTestRunner must use dynamic reference to AnnotationsProcessor

[ https://issues.apache.org/jira/browse/SLING-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-2219: Attachment: (was: SlingAnnotationsTestRunner.patch.txt) SlingAnnotationsTestRunner must use dynamic

[jira] [Issue Comment Deleted] (SLING-2219) SlingAnnotationsTestRunner must use dynamic reference to AnnotationsProcessor

[ https://issues.apache.org/jira/browse/SLING-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-2219: Comment: was deleted (was: Proposed patch which allows SlingAnnotationsTestRunner to continue test

[jira] [Updated] (SLING-2219) SlingAnnotationsTestRunner must use dynamic reference to AnnotationsProcessor

[ https://issues.apache.org/jira/browse/SLING-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-2219: Attachment: SlingAnnotationsTestRunner.patch.txt Proposed patch which allows SlingAnnotationsTestRunner

[jira] [Updated] (SLING-4101) SlingAnnotationsTestRunner doesn't work with SlingRemoteExecutionRule

[ https://issues.apache.org/jira/browse/SLING-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-4101: Attachment: SlingAnnotationsTestRunner.patch.txt Proposed patch which allows SlingAnnotationsTestRunner

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14177271#comment-14177271 ] Rob Ryan commented on SLING-3844: - [~asanso] I agree that in the typical case

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14109365#comment-14109365 ] Rob Ryan commented on SLING-3848: - Thanks for all the work Carsten Julian! Yes

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102237#comment-14102237 ] Rob Ryan commented on SLING-3844: - [~asanso] I don't follow the reverse mapping

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102255#comment-14102255 ] Rob Ryan commented on SLING-3844: - Please take the patch with the reverse mapping in place

[jira] [Commented] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102254#comment-14102254 ] Rob Ryan commented on SLING-3844: - See my updated comment above. There is no way without

[jira] [Comment Edited] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102237#comment-14102237 ] Rob Ryan edited comment on SLING-3844 at 8/19/14 2:43 PM

[jira] [Commented] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14101298#comment-14101298 ] Rob Ryan commented on SLING-3848: - [~cziegeler] Thanks for the quick action. WRT your

[jira] [Created] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

Rob Ryan created SLING-3844: --- Summary: Resolver.map() spends too much time looking up sling:alias Key: SLING-3844 URL: https://issues.apache.org/jira/browse/SLING-3844 Project: Sling Issue Type

[jira] [Updated] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-3844: Attachment: sling.resourceresolver.diff This patch implements optimization of Resolver.map by looking up

[jira] [Updated] (SLING-3844) Resolver.map() spends too much time looking up sling:alias

[ https://issues.apache.org/jira/browse/SLING-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-3844: Labels: Performance (was: ) Resolver.map() spends too much time looking up sling:alias

[jira] [Created] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

Rob Ryan created SLING-3848: --- Summary: JcrNodeResource takes too long and initializes too much too soon Key: SLING-3848 URL: https://issues.apache.org/jira/browse/SLING-3848 Project: Sling Issue

[jira] [Updated] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-3848: Attachment: sling.api.diff This patch introduces a new protected method in the ResourceMetaData class so

[jira] [Updated] (SLING-3848) JcrNodeResource takes too long and initializes too much too soon

[ https://issues.apache.org/jira/browse/SLING-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Ryan updated SLING-3848: Attachment: sling.jcr.resource.diff This patch builds upon the sling.api.diff patch to offer delayed

RE: Support REST-ful APIs

the existing resolution process. Consider that some URLs end up containing period characters which have nothing to do with a desire for a selector or extension, a prominent example is user ids. -Rob Ryan -Original Message- From: Felix Meschberger [mailto:fmesc...@adobe.com] Sent

[jira] [Commented] (SLING-3203) Post servlet's delete operation deletes parent of nonexisting node

[ https://issues.apache.org/jira/browse/SLING-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949279#comment-13949279 ] Rob Ryan commented on SLING-3203: - In the case an :applyTo is provided isn't this check

[jira] [Created] (SLING-2881) [I18N][Performance] JcrResourceBundleProvider clears the cache on mix:language changes

Rob Ryan created SLING-2881: --- Summary: [I18N][Performance] JcrResourceBundleProvider clears the cache on mix:language changes Key: SLING-2881 URL: https://issues.apache.org/jira/browse/SLING-2881 Project