[jira] [Commented] (SLING-11799) use keyset pagination for sling:alias query

2024-01-04 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803173#comment-17803173 ] Thomas Mueller commented on SLING-11799: [~reschke] Yes, this is what is implemented

[jira] [Commented] (SLING-11799) use keyset pagination for sling:alias query

2024-01-04 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802891#comment-17802891 ] Thomas Mueller commented on SLING-11799: > What would be needed is the (first) alias that has

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-08-16 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17580357#comment-17580357 ] Thomas Mueller commented on SLING-11439: [~reschke] hm... now that I think about it again... if

[jira] [Comment Edited] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564308#comment-17564308 ] Thomas Mueller edited comment on SLING-11439 at 7/8/22 2:58 PM: > the

[jira] [Comment Edited] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564308#comment-17564308 ] Thomas Mueller edited comment on SLING-11439 at 7/8/22 2:51 PM: > option

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564308#comment-17564308 ] Thomas Mueller commented on SLING-11439: > option (limit 1000) This is not actually needed.

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564259#comment-17564259 ] Thomas Mueller commented on SLING-11439: A good page size for this use case would be 1000.

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564247#comment-17564247 ] Thomas Mueller commented on SLING-11439: > will it indeed throw an exception? Well, Oak will

[jira] [Comment Edited] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564190#comment-17564190 ] Thomas Mueller edited comment on SLING-11439 at 7/8/22 9:28 AM: > Paging

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564190#comment-17564190 ] Thomas Mueller commented on SLING-11439: > Paging by default will make things more complicated

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-08 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564181#comment-17564181 ] Thomas Mueller commented on SLING-11439: > (To make things worse, we don't have a way to detect

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-07 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563833#comment-17563833 ] Thomas Mueller commented on SLING-11439: I'm fine with either approach (I don't have a strong

[jira] [Comment Edited] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-07 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563833#comment-17563833 ] Thomas Mueller edited comment on SLING-11439 at 7/7/22 3:30 PM: I'm fine

[jira] [Comment Edited] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-06 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563302#comment-17563302 ] Thomas Mueller edited comment on SLING-11439 at 7/6/22 3:35 PM: >

[jira] [Commented] (SLING-11439) resource resolver: fails to detect aborted vanity path query

2022-07-06 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17563302#comment-17563302 ] Thomas Mueller commented on SLING-11439: > exposing the exception in some way. For example, by

[jira] [Comment Edited] (SLING-11229) Add Option to Limit JCR Resource Provider Queries

2022-03-28 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513385#comment-17513385 ] Thomas Mueller edited comment on SLING-11229 at 3/28/22, 1:33 PM: -- I

[jira] [Commented] (SLING-11229) Add Option to Limit JCR Resource Provider Queries

2022-03-28 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513385#comment-17513385 ] Thomas Mueller commented on SLING-11229: I agree about the limit. The offset, in my experience,

[jira] [Commented] (SLING-11113) resource resolver: bloom filter might be out of sync on startup

2022-02-07 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488044#comment-17488044 ] Thomas Mueller commented on SLING-3: I think what [~reschke] is saying is: we don't actually

[jira] [Commented] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468080#comment-17468080 ] Thomas Mueller commented on SLING-9896: --- I opened SLING-11038 to track my problem. > change

[jira] [Updated] (SLING-11038) Change statuscode in SlingPostServlet for PersistenceException, take 2

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-11038: --- Description: When the SlingPostServlet receives a PersistenceExceptions (e.g. when trying

[jira] [Updated] (SLING-11038) Change statuscode in SlingPostServlet for PersistenceException, take 2

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-11038: --- Description: When the SlingPostServlet receives a PersistenceExceptions (e.g. when trying

[jira] [Updated] (SLING-11038) Change statuscode in SlingPostServlet for PersistenceException, take 2

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-11038: --- Description: When the SlingPostServlet receives a PersistenceExceptions (e.g. when trying

[jira] [Created] (SLING-11038) Change statuscode in SlingPostServlet for PersistenceException, take 2

2022-01-03 Thread Thomas Mueller (Jira)
Thomas Mueller created SLING-11038: -- Summary: Change statuscode in SlingPostServlet for PersistenceException, take 2 Key: SLING-11038 URL: https://issues.apache.org/jira/browse/SLING-11038 Project:

[jira] [Comment Edited] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468075#comment-17468075 ] Thomas Mueller edited comment on SLING-9896 at 1/3/22, 4:03 PM: Ah the

[jira] [Commented] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468075#comment-17468075 ] Thomas Mueller commented on SLING-9896: --- Ah the problem is in

[jira] [Commented] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468063#comment-17468063 ] Thomas Mueller commented on SLING-9896: --- Hm, I can't find the WARN in the log file. {noformat}

[jira] [Commented] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468058#comment-17468058 ] Thomas Mueller commented on SLING-9896: --- So Fix Version/s: Servlets POST 2.4.2 - but the stack

[jira] [Commented] (SLING-9896) change statuscode in SlingPostServlet for PersistenceException

2022-01-03 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17468057#comment-17468057 ] Thomas Mueller commented on SLING-9896: --- Hm, I wonder, if SLING-9441 duplicates this issue, then

[jira] [Commented] (SLING-10754) Missing entries in filter.xml

2021-08-26 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17405163#comment-17405163 ] Thomas Mueller commented on SLING-10754: I wonder, which commit broke it? Could you link the

[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2020-09-07 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191474#comment-17191474 ] Thomas Mueller commented on SLING-8309: --- >  At the moment, that custom code is not managed by the

[jira] [Comment Edited] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2020-09-04 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190800#comment-17190800 ] Thomas Mueller edited comment on SLING-8309 at 9/4/20, 3:59 PM: > My use

[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2020-09-04 Thread Thomas Mueller (Jira)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190800#comment-17190800 ] Thomas Mueller commented on SLING-8309: --- > My use case is a custom variation of the 

[jira] [Commented] (SLING-8413) JobManagerImpl.findJobs does not escape some values when running queries

2019-06-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856583#comment-16856583 ] Thomas Mueller commented on SLING-8413: --- I think somebody from the Sling team ([~egli]?) should

[jira] [Resolved] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-06-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved SLING-8407. --- Resolution: Won't Fix The current Sling code is problematic, as it swallows exceptions.

[jira] [Resolved] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-06-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved SLING-8408. --- Resolution: Won't Fix It looks like this wouldn't resolve the issue, as other Sling code

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-14 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839451#comment-16839451 ] Thomas Mueller commented on SLING-8407: --- I think the proposal of [~marett] would work fine for many

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-14 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839144#comment-16839144 ] Thomas Mueller commented on SLING-8407: --- > Oak could expose an marker API (e.g. IndexReady) One

[jira] [Commented] (SLING-8413) JobManagerImpl.findJobs does not escape some values when running queries

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837296#comment-16837296 ] Thomas Mueller commented on SLING-8413: --- A possible patch (without test case): {noformat} diff

[jira] [Commented] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837284#comment-16837284 ] Thomas Mueller commented on SLING-8408: --- Pull request:

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837262#comment-16837262 ] Thomas Mueller commented on SLING-8407: --- Pull request:

[jira] [Commented] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837265#comment-16837265 ] Thomas Mueller commented on SLING-8408: --- The exception can also be thrown if the query syntax is

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837230#comment-16837230 ] Thomas Mueller commented on SLING-8407: --- About adding a new API: I tried changing

[jira] [Created] (SLING-8413) JobManagerImpl.findJobs does not escape some values when running queries

2019-05-10 Thread Thomas Mueller (JIRA)
Thomas Mueller created SLING-8413: - Summary: JobManagerImpl.findJobs does not escape some values when running queries Key: SLING-8413 URL: https://issues.apache.org/jira/browse/SLING-8413 Project:

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837160#comment-16837160 ] Thomas Mueller commented on SLING-8407: --- > I prefer catching bugs at test time instead of at

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836974#comment-16836974 ] Thomas Mueller commented on SLING-8407: --- There is at least one other place where the parameter is

[jira] [Comment Edited] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836935#comment-16836935 ] Thomas Mueller edited comment on SLING-8407 at 5/10/19 6:46 AM: >

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836946#comment-16836946 ] Thomas Mueller commented on SLING-8407: --- [~jebailey] I'm afraid I'm not familiar with the specific

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-10 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836935#comment-16836935 ] Thomas Mueller commented on SLING-8407: --- > therefore there is no point in throwing an exception if

[jira] [Comment Edited] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836442#comment-16836442 ] Thomas Mueller edited comment on SLING-8407 at 5/9/19 2:43 PM: --- {noformat}

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836442#comment-16836442 ] Thomas Mueller commented on SLING-8407: --- } catch (final QuerySyntaxException qse) {

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836441#comment-16836441 ] Thomas Mueller commented on SLING-8407: --- [~egli] yes, or we could use a different configuration

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836410#comment-16836410 ] Thomas Mueller commented on SLING-8407: --- Regarding the configuration option would this patch work?

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836389#comment-16836389 ] Thomas Mueller commented on SLING-8407: --- [~egli] how should the feature flag be implemented,

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836383#comment-16836383 ] Thomas Mueller commented on SLING-8407: --- > why not delay the health checks until the repo is

[jira] [Comment Edited] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836296#comment-16836296 ] Thomas Mueller edited comment on SLING-8407 at 5/9/19 1:17 PM: --- Patch for

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836367#comment-16836367 ] Thomas Mueller commented on SLING-8407: --- > How do you know that no one else is calling that api?

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836363#comment-16836363 ] Thomas Mueller commented on SLING-8407: --- [~egli] looks like you found a bug in the JobManagerImpl,

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836358#comment-16836358 ] Thomas Mueller commented on SLING-8407: --- > It seems Oak is not ready without the index as queries

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836354#comment-16836354 ] Thomas Mueller commented on SLING-8407: --- > adding option(traversal fail) by default but only if a

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836333#comment-16836333 ] Thomas Mueller commented on SLING-8407: --- [~cziegeler] longer term, we want to enable "traversal

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836322#comment-16836322 ] Thomas Mueller commented on SLING-8407: --- [~cziegeler] > I'm not sure if we really should go this

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836304#comment-16836304 ] Thomas Mueller commented on SLING-8407: --- [~egli] could you review please, or let me know who

[jira] [Commented] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836305#comment-16836305 ] Thomas Mueller commented on SLING-8408: --- [~teofili] could you review please, or let me know who

[jira] [Commented] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836298#comment-16836298 ] Thomas Mueller commented on SLING-8408: --- Patch for sling-org-apache-sling-distribution-cor:

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836296#comment-16836296 ] Thomas Mueller commented on SLING-8407: --- Patch for sling-org-apache-sling-event: {noformat} diff

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836160#comment-16836160 ] Thomas Mueller commented on SLING-8407: --- The Oak version change (and subsequent Jackrabbit version

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-09 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836157#comment-16836157 ] Thomas Mueller commented on SLING-8407: --- Here a first patch that passes the tests. I will try to

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835649#comment-16835649 ] Thomas Mueller commented on SLING-8407: --- Looks like an ancient Oak version is used. Full exception

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835650#comment-16835650 ] Thomas Mueller commented on SLING-8407: --- Looks like this is {noformat} [INFO] Running

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835633#comment-16835633 ] Thomas Mueller commented on SLING-8407: --- The following change in Sling didn't work as expected.

[jira] [Commented] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835620#comment-16835620 ] Thomas Mueller commented on SLING-8407: --- "option(traversal fail)" requires Oak 1.5.13 (see

[jira] [Updated] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-8408: -- Description: The following health check indirectly runs a queries which might fail: *

[jira] [Updated] (SLING-8408) ReplicationQueueHealthCheck and DistributionQueueHealthCheck should deal with failing queries

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-8408: -- Description: The following health check indirectly runs a queries which might fail: *

[jira] [Updated] (SLING-8408) DistributionQueueHealthCheck should deal with failing queries

2019-05-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-8408: -- Summary: DistributionQueueHealthCheck should deal with failing queries (was:

[jira] [Created] (SLING-8408) ReplicationQueueHealthCheck and DistributionQueueHealthCheck should deal with failing queries

2019-05-08 Thread Thomas Mueller (JIRA)
Thomas Mueller created SLING-8408: - Summary: ReplicationQueueHealthCheck and DistributionQueueHealthCheck should deal with failing queries Key: SLING-8408 URL: https://issues.apache.org/jira/browse/SLING-8408

[jira] [Created] (SLING-8407) JobManagerImpl.findJobs should prevent traversal

2019-05-08 Thread Thomas Mueller (JIRA)
Thomas Mueller created SLING-8407: - Summary: JobManagerImpl.findJobs should prevent traversal Key: SLING-8407 URL: https://issues.apache.org/jira/browse/SLING-8407 Project: Sling Issue Type:

[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2019-03-19 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796131#comment-16796131 ] Thomas Mueller commented on SLING-8309: --- What I'm missing is the motivation... I mean I understand

[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

2019-03-15 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793500#comment-16793500 ] Thomas Mueller commented on SLING-8309: --- > being able to validate more than what is possible with

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

2018-03-22 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409369#comment-16409369 ] Thomas Mueller commented on SLING-7169: --- [~volteanu] sorry for the delay. Could you remove this line

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

2018-02-28 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380082#comment-16380082 ] Thomas Mueller commented on SLING-7169: --- Thanks [~rombert]. I personally would prefer Oak 1.8, as

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

2018-02-27 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378800#comment-16378800 ] Thomas Mueller commented on SLING-7169: --- For older versions of Oak, if "option(index tag

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

2018-02-23 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374342#comment-16374342 ] Thomas Mueller commented on SLING-7169: --- As for index definitions to be installed and queries to

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

2018-02-06 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353624#comment-16353624 ] Thomas Mueller commented on SLING-7169: --- "option(traversal fail)" works with Oak 1.5.13 and newer

[jira] [Commented] (SLING-7169) FullTextIndexingTest sometimes fails with a timeout

2018-01-04 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311340#comment-16311340 ] Thomas Mueller commented on SLING-7169: --- I wouldn't use the JMX bean, as that might change in the

[jira] [Commented] (SLING-6090) Avoid using nt:resource while creating file nodes via SlingPostServlet

2016-10-04 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544814#comment-15544814 ] Thomas Mueller commented on SLING-6090: --- I understand Carstens reason to avoid a direct dependency

[jira] [Commented] (SLING-5416) Thread Pool should stop "gracefully"

2016-01-12 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093915#comment-15093915 ] Thomas Mueller commented on SLING-5416: --- > backwards compatibility issues What we could do is test

[jira] [Commented] (SLING-5416) Thread Pool should stop "gracefully"

2016-01-12 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093891#comment-15093891 ] Thomas Mueller commented on SLING-5416: --- In my view, calling Thread.interrupt is a bug, because it

[jira] [Commented] (SLING-5416) Thread Pool should stop "gracefully"

2016-01-12 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093738#comment-15093738 ] Thomas Mueller commented on SLING-5416: --- > I guess the danger here is that the shutdown blocks

[jira] [Created] (SLING-5416) Thread Pool should stop "gracefully"

2016-01-08 Thread Thomas Mueller (JIRA)
Thomas Mueller created SLING-5416: - Summary: Thread Pool should stop "gracefully" Key: SLING-5416 URL: https://issues.apache.org/jira/browse/SLING-5416 Project: Sling Issue Type: Improvement

[jira] [Updated] (SLING-5416) Thread Pool should stop "gracefully"

2016-01-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-5416: -- Component/s: Commons > Thread Pool should stop "gracefully" >

[jira] [Created] (SLING-4477) JcrInstaller should not call Thread.interrupt()

2015-03-05 Thread Thomas Mueller (JIRA)
Thomas Mueller created SLING-4477: - Summary: JcrInstaller should not call Thread.interrupt() Key: SLING-4477 URL: https://issues.apache.org/jira/browse/SLING-4477 Project: Sling Issue Type:

[jira] [Updated] (SLING-4477) JcrInstaller should not call Thread.interrupt()

2015-03-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-4477: -- Description: There JcrInstaller calls Thread.interrupt() where it's dangerous and not

[jira] [Commented] (SLING-3290) Long startup time with many vanityPath

2014-06-05 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018699#comment-14018699 ] Thomas Mueller commented on SLING-3290: --- I assume vanity path information needs to

[jira] [Commented] (SLING-2940) JCR queries for jcr:language: avoid using fn:lower-case

2013-07-08 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13702007#comment-13702007 ] Thomas Mueller commented on SLING-2940: --- Any news about when the patch might be

[jira] [Updated] (SLING-2940) JCR queries for jcr:language: avoid using fn:lower-case

2013-07-01 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated SLING-2940: -- Attachment: SLING-2940.patch Proposed patch JCR queries for jcr:language:

[jira] Commented: (SLING-1283) Remove Session Pool Support

2010-02-01 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12828033#action_12828033 ] Thomas Mueller commented on SLING-1283: --- I forgot to say, the memory leak also occurs