[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

2023-02-24 Thread via GitHub
kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116837763 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

2023-02-24 Thread via GitHub
kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

2023-02-24 Thread via GitHub
kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

2023-02-24 Thread via GitHub
kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

2023-02-24 Thread via GitHub
kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116806497 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

2023-02-23 Thread via GitHub
kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116146482 ## Jenkinsfile: ## @@ -16,5 +16,5 @@ * specific language governing permissions and limitations * under the License. */ -