[GitHub] chetanmeh commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder

2018-03-12 Thread GitBox
chetanmeh commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/3#issuecomment-37722 @CptBartender Can you add license headers on the newly added files in test. Without that build fails

[GitHub] chetanmeh commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder

2018-03-09 Thread GitBox
chetanmeh commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/3#issuecomment-371764459 @CptBartender Sorry for the delay here. Would look into this early next week

[GitHub] chetanmeh commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder

2018-03-03 Thread GitBox
chetanmeh commented on issue #3: SLING-7529 - implemented layout inheritance in log encoder URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/3#issuecomment-370158930 Looks fine. Can you add a test case for the same