Re: [VOTE] Move commons compiler from contrib to bundles

2014-05-15 Thread Chetan Mehrotra
On Wed, May 7, 2014 at 11:29 AM, Carsten Ziegeler cziege...@apache.org wrote: Therefore I think we should move this bundle from its current place in the contrib section to the bundles section. Whats the general convention here. Do we have to move the bundle code to bundles folder if a release

Re: [VOTE] Move commons compiler from contrib to bundles

2014-05-13 Thread Oliver Lietz
On Wednesday 07 May 2014 07:59:26 Carsten Ziegeler wrote: Hi, with the recent changes, the jsp scripting now uses the commons compiler (the java scripting we have already does so). This avoids embedding the eclipse compiler twice and now we have a single bundle dealing with java compilation

Re: [VOTE] Move commons compiler from contrib to bundles

2014-05-13 Thread Julian Sedding
+1 Sounds sensible and is certainly a good separation of concerns. Regards Julian On Wed, May 7, 2014 at 7:59 AM, Carsten Ziegeler cziege...@apache.org wrote: Hi, with the recent changes, the jsp scripting now uses the commons compiler (the java scripting we have already does so). This

Re: [VOTE] Move commons compiler from contrib to bundles

2014-05-13 Thread Carsten Ziegeler
Thanks everyone - I've moved the bundle Carsten 2014-05-13 17:56 GMT+02:00 Oliver Lietz apa...@oliverlietz.de: On Wednesday 07 May 2014 07:59:26 Carsten Ziegeler wrote: Hi, with the recent changes, the jsp scripting now uses the commons compiler (the java scripting we have already

Re: [VOTE] Move commons compiler from contrib to bundles

2014-05-12 Thread Justin Edelson
Hi Chetan, On Thu, May 8, 2014 at 1:24 AM, Chetan Mehrotra chetan.mehro...@gmail.com wrote: On Wed, May 7, 2014 at 11:29 AM, Carsten Ziegeler cziege...@apache.org wrote: Therefore I think we should move this bundle from its current place in the contrib section to the bundles section. Whats

[VOTE] Move commons compiler from contrib to bundles

2014-05-07 Thread Carsten Ziegeler
Hi, with the recent changes, the jsp scripting now uses the commons compiler (the java scripting we have already does so). This avoids embedding the eclipse compiler twice and now we have a single bundle dealing with java compilation which makes updating it way easier. Therefore I think we