[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649537#comment-13649537
]
Felix Meschberger commented on SLING-2853:
--
Thanks for the discussions and
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649538#comment-13649538
]
Felix Meschberger commented on SLING-2853:
--
I have an additional comment on the
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649545#comment-13649545
]
Bertrand Delacretaz commented on SLING-2853:
I like the sling:members idea. At
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649546#comment-13649546
]
Amit Gupta commented on SLING-2853:
---
As far as structure is concerned
+ collection #
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649558#comment-13649558
]
Alexander Klimetschek commented on SLING-2853:
--
Namespacing sling:members
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649712#comment-13649712
]
Carsten Ziegeler commented on SLING-2853:
-
For testing, this:
dependency
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649963#comment-13649963
]
Carsten Ziegeler commented on SLING-2853:
-
I've removed the two mock classes and
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649346#comment-13649346
]
Alexander Klimetschek commented on SLING-2853:
--
Here's my review of the patch
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649352#comment-13649352
]
Carsten Ziegeler commented on SLING-2853:
-
I agree that allowing for custom node
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649358#comment-13649358
]
Alexander Klimetschek commented on SLING-2853:
--
As we want to allow
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649385#comment-13649385
]
Amit Gupta commented on SLING-2853:
---
If you look at the code, it's actually simpler.
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649389#comment-13649389
]
Alexander Klimetschek commented on SLING-2853:
--
See in my review above,
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649399#comment-13649399
]
Amit Gupta commented on SLING-2853:
---
new patch (addressing following comments)
1. BTW,
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648269#comment-13648269
]
Felix Meschberger commented on SLING-2853:
--
Sounds like a good idea. Looks nice.
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648382#comment-13648382
]
Amit Gupta commented on SLING-2853:
---
The ResourceCollection interface exposes the
[
https://issues.apache.org/jira/browse/SLING-2853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648941#comment-13648941
]
Amit Gupta commented on SLING-2853:
---
Your bundle provides API in the o.a.s.api
16 matches
Mail list logo