[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068659#comment-15068659 ] ASF GitHub Bot commented on SLING-4544: --- Github user joelrich closed the pull request at:

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946793#comment-14946793 ] Tomek Rękawek commented on SLING-4544: -- Pull request looks good. It improves the performance and

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945089#comment-14945089 ] Tomek Rękawek commented on SLING-4544: -- [~joelrich], pull request looks good for me. I've just found

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945119#comment-14945119 ] Joel Richard commented on SLING-4544: - [~tomek.rekawek], I have updated the pull request. >

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945060#comment-14945060 ] ASF GitHub Bot commented on SLING-4544: --- GitHub user joelrich opened a pull request:

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493824#comment-14493824 ] Felix Meschberger commented on SLING-4544: -- bq. Well, this is internal API as the

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494037#comment-14494037 ] Felix Meschberger commented on SLING-4544: -- Thanks for providing the patch. Yet

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383781#comment-14383781 ] Robert Munteanu commented on SLING-4544: Well, the problem with that is we have a

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383784#comment-14383784 ] Joel Richard commented on SLING-4544: - [~rombert], although the log-API mentions

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383793#comment-14383793 ] Robert Munteanu commented on SLING-4544: [~joelrich] - I missed the fact that this

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383818#comment-14383818 ] Bertrand Delacretaz commented on SLING-4544: A limited MessageFormat

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384065#comment-14384065 ] Felix Meschberger commented on SLING-4544: -- The API defines MessageFormat pattern

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384093#comment-14384093 ] Felix Meschberger commented on SLING-4544: -- I think this can be cheap: scan the

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384076#comment-14384076 ] Bertrand Delacretaz commented on SLING-4544: Good point about keeping

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384496#comment-14384496 ] Robert Munteanu commented on SLING-4544: {quote}The API defines MessageFormat

[jira] [Commented] (SLING-4544) Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker

[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14384694#comment-14384694 ] Alexander Klimetschek commented on SLING-4544: -- BTW, the request progress