[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-17 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929890#comment-15929890 ] Dirk Rudolph commented on SLING-6652: - Its indeed explained in

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-17 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929788#comment-15929788 ] Justin Edelson commented on SLING-6652: --- I'm not sure it matters which {{adapterType}} is used in

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-17 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929562#comment-15929562 ] Dirk Rudolph commented on SLING-6652: - I applied my proposal on top of [~justinedelson]'s patch in the

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-17 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929541#comment-15929541 ] Dirk Rudolph commented on SLING-6652: - Thanks for the patch, that definitively make sense, but there

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929253#comment-15929253 ] Justin Edelson commented on SLING-6652: --- This appears to be an XY problem. The actual thing you want

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928680#comment-15928680 ] Dirk Rudolph commented on SLING-6652: - The API change was considered like that because having n

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928670#comment-15928670 ] Justin Edelson commented on SLING-6652: --- Looking at the Pull Request and reading the original

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928410#comment-15928410 ] Justin Edelson commented on SLING-6652: --- Understood. I was just expressing how this was designed to

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928392#comment-15928392 ] Dirk Rudolph commented on SLING-6652: - This is not what this is about. See I have a resource {code}

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928376#comment-15928376 ] Justin Edelson commented on SLING-6652: --- Sorry, I'm not making myself clear. What I mean is

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928334#comment-15928334 ] Dirk Rudolph commented on SLING-6652: - That indeed was my initial idea. Having 2 models AImpl and

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928330#comment-15928330 ] Justin Edelson commented on SLING-6652: --- Not necessarily a different implementation of the

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928276#comment-15928276 ] Dirk Rudolph commented on SLING-6652: - You mean registering jackson exporter again with a different

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Justin Edelson (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928263#comment-15928263 ] Justin Edelson commented on SLING-6652: --- The way I had anticipated this being handled was by two

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927784#comment-15927784 ] Konrad Windszus commented on SLING-6652: Registering multiple models on the same adapter is

[jira] [Commented] (SLING-6652) Allow multiple adapters for Models with resourceType binding

2017-03-16 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927751#comment-15927751 ] Dirk Rudolph commented on SLING-6652: - Currently only a warning is logged: "Skipped registering {} for