[ 
https://issues.apache.org/jira/browse/SLING-11506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-11506:
--------------------------------------

It seems this change is actually breaking client code. There is client code out 
there expecting the sling:resourceType property to *not* reflect the resource 
type of the resource. The code rather expects it to be the value from the 
merged resources.
While such behaviour is questionable, breaking existing code is not an option

> Streamline and document resource (super) type merging
> -----------------------------------------------------
>
>                 Key: SLING-11506
>                 URL: https://issues.apache.org/jira/browse/SLING-11506
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Resource Merger 1.4.0
>            Reporter: Konrad Windszus
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: Resource Merger 1.4.2
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-4340 the merging of resource types has been changed so that it gives 
> the resourceType property precedence over {{Resource.getResourceType()}} 
> (https://github.com/apache/sling-org-apache-sling-resourcemerger/blob/f821f844ba675e3850189debf8e45239026c5709/src/main/java/org/apache/sling/resourcemerger/impl/MergedResource.java#L74-L92).
> This change is questionable and kind of unexpected from the user's side and 
> also leads to undesired side effects like outlined in SLING-11504.
> So in the best case the merging of resource types doesn't rely on properties 
> (which are implementation details of the underlying resolvers) but clearly 
> derives from either the lowest or highest resource without breaking the use 
> cases outlined in SLING-4340.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to