[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joel Richard reopened SLING-4544: --------------------------------- I encountered a page where 6.7% of the rendering time is spent in MessageFormat.format and decided to implement a faster MessageFormat implementation anyway. It's kept very simple and falls back to the original implementation for more complex formats. This change reduces the overhead to 3.5% (which is mainly due to toString methods). The pull request can be found here: https://github.com/apache/sling/pull/104 [~tomek.rekawek], would you mind reviewing it? > Performance: MessageFormat shouldn't be used for logging in > SlingRequestProgressTracker > --------------------------------------------------------------------------------------- > > Key: SLING-4544 > URL: https://issues.apache.org/jira/browse/SLING-4544 > Project: Sling > Issue Type: Improvement > Components: Engine > Affects Versions: Engine 2.4.0 > Reporter: Joel Richard > Labels: performance > Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png > > > I am profiling an application where 1-5% of the rendering time is spent in > MessageFormat.format for SlingRequestProgressTracker.log (see attached > screenshot). Since the advanced capabilities of MessageFormat are not > required here, it should be rather easy to implement a utility which supports > \{x} as well but is much faster. -- This message was sent by Atlassian JIRA (v6.3.4#6332)