[ 
https://issues.apache.org/jira/browse/SLING-4346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vlad Bailescu updated SLING-4346:
---------------------------------
    Attachment: 
SLING-4346_Sightly__HtmlParser_does_not_parse_documents_correctly_when_comments_span_acros.patch

- Added helper method to handle comments
- Fixed data handling for comments inside the parser state machine
- Made internal char buffer size configurable
- Added unit tests

> Sightly: HtmlParser does not parse documents correctly when comments span 
> across internal char buffer size
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-4346
>                 URL: https://issues.apache.org/jira/browse/SLING-4346
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Vlad Bailescu
>             Fix For: Scripting Sightly Engine 1.0.2
>
>         Attachments: 
> SLING-4346_Sightly__HtmlParser_does_not_parse_documents_correctly_when_comments_span_acros.patch
>
>
> The HTML parser used by Sightly to process templates is parsing incorrectly 
> comments that span across it's internal char buffer size. Right now the 
> buffer is set to 2048 characters, making the problem hard to see.
> The problem can be exposed by lowering the buffer size to 10 and feeding a 
> string such as {code:java}"test test <!--/*comment*/-->"{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to