Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Bertrand Delacretaz
On Thu, Apr 21, 2016 at 4:06 PM, Konrad Windszus wrote: >> On 21 Apr 2016, at 16:00, Bertrand Delacretaz wrote: >> I'd like to stay flexible about the mechanisms used to start the >> instance under test. > I agree, but IMHO this should not be part of the

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Bertrand Delacretaz
On Thu, Apr 21, 2016 at 3:55 PM, Julian Sedding wrote: >>... 1) Still uses the SlingTestBase (through its own Customizer) > > Agreed, that's a pity. Maybe you can improve the example to use the > slingstart plugin instead?... As I just said elsethread it's not really an

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Bertrand Delacretaz
On Thu, Apr 21, 2016 at 3:49 PM, Konrad Windszus wrote: > ...Why is the customize() method part of the TeleporterRule instead of > the ClientSideTeleporter?... I suppose you're right and this can be changed. Writing that code has been quite a challenge in terms of figuring out

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Konrad Windszus
Thanks for you fast input. > On 21 Apr 2016, at 16:00, Bertrand Delacretaz wrote: > > Hi Konrad, > > On Thu, Apr 21, 2016 at 3:23 PM, Konrad Windszus wrote: >> I would like to revive this old thread, because I now want to leverage the >>

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Bertrand Delacretaz
Hi Konrad, On Thu, Apr 21, 2016 at 3:23 PM, Konrad Windszus wrote: > I would like to revive this old thread, because I now want to leverage the > TeleporterRule... Very cool! > ...There are two customizers available.. The idea is that one creates their own customizer (which

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Julian Sedding
On Thu, Apr 21, 2016 at 3:23 PM, Konrad Windszus wrote: > Unfortunately not even the example at > https://github.com/apache/sling/tree/c9e59667d8f9cd698bc33a51f3e6a22e85d4a952/testing/samples/bundle-with-it > shows such a setup. That for example > 1) Still uses the

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Konrad Windszus
I created https://issues.apache.org/jira/browse/SLING-5677 on the proposal from below. One open question after looking at the code is: Why is the customize() method part of the TeleporterRule instead of the ClientSideTeleporter? I don't see that the customize() is useful for the server-side

Re: FYI, TeleporterRule + reorganized server-side tests docs

2016-04-21 Thread Konrad Windszus
I would like to revive this old thread, because I now want to leverage the TeleporterRule. It would be great if someone could verify the following observations: There are two customizers available: a) The LaunchpadCustomizer, which only verifies that a Sling instance is ready at a given port,

Re: FYI, TeleporterRule + reorganized server-side tests docs

2015-09-30 Thread Konrad Windszus
Hi Bertrand, to me it is not clear what should be the obligation of the customizer and what should be built into the ClientSideTeleporter. For me the provisioning of the new instance or configuration of the existing instance (on which the IT is executed) is core part of each integration test

Re: FYI, TeleporterRule + reorganized server-side tests docs

2015-09-30 Thread Konrad Windszus
> So I would suggest the following: Make the ClientSideTeleporter usable > without any customizer and without any glue code but just with additional > system properties. > The system properties are then used to either connect to an existing instance > or to spin up a completely new instance

Re: FYI, TeleporterRule + reorganized server-side tests docs

2015-09-29 Thread Konrad Windszus
Hi, the TeleporterRule-based tests look indeed much cleaner and leaner than with the old approach. But I was wondering whether it would be good to extend the teleporter module with some customizer rules which would allow to run the test on an already provisioned instance. Currently we only have

Re: FYI, TeleporterRule + reorganized server-side tests docs

2015-09-29 Thread Bertrand Delacretaz
Hi Konrad, On Tue, Sep 29, 2015 at 1:10 PM, Konrad Windszus wrote: > What about a customizer which can be parameterised equally to the > former SlingTestBase... That's totally possible, the only requirement is that the junit.core bundle running on the server side must not

FYI, TeleporterRule + reorganized server-side tests docs

2015-09-23 Thread Bertrand Delacretaz
Hi, FYI I have created a new docs page at http://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html which replaces this one, which is now mostly obsolete: https://sling.apache.org/documentation/development/sling-testing-tools.html I have created a TeleporterRule,