That's quite an improvement. Nice work, guys.
> -----Original Message----- > From: Antonio Sanso (Commented) (JIRA) [mailto:j...@apache.org] > Sent: 26 March 2012 14:36 > To: dev@sling.apache.org > Subject: [jira] [Commented] (SLING-2255) Improve > JcrResourceResolver#resolve performance when big number of vanityPath > are present > > > [ https://issues.apache.org/jira/browse/SLING- > 2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=13238379#comment-13238379 ] > > Antonio Sanso commented on SLING-2255: > -------------------------------------- > > Great work Carsten. > > I have ran the tests in SLING-2311 and this confirm the magnitude of > the improvement. > This is the outcome before the patch (in ms) > > # ResolveWithManyVanityPathTest min 10% 50% 90% > max > jcr.resource-2.0.11 56 57 > 60 120 406 > > and after the patch > > # ResolveWithManyVanityPathTest min 10% 50% 90% > max > jcr.resource-2.0.11 12 13 > 15 19 401 > > > > > Improve JcrResourceResolver#resolve performance when big number of > vanityPath are present > > --------------------------------------------------------------------- > -------------------- > > > > Key: SLING-2255 > > URL: https://issues.apache.org/jira/browse/SLING-2255 > > Project: Sling > > Issue Type: Improvement > > Components: JCR > > Affects Versions: JCR Resource 2.0.10 > > Reporter: Antonio Sanso > > Assignee: Carsten Ziegeler > > Priority: Minor > > Fix For: JCR Resource 2.1.0 > > > > Attachments: SLING-2255.txt, performance.pdf > > > > > > At the moment the performance of JcrResourceResolver#resolve is tight > with the number of sling:vanityPath present in the repository. > > Large number of vanityPath means large response time specially in > the worse case scenario (namely huge number of vanityPath and request > that doesn't match any vanityPath) but also in the average cases. > > Sling currently employs generic regexps also for vanityPath, but > since the regex behind a vanityPath is well know there is room for > optimization. > > I'll attach a graphs that shows the situation and a potential patch. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp > a > For more information on JIRA, see: > http://www.atlassian.com/software/jira > >
