Re: Automated tests, at least under /bundles

2013-04-05 Thread Carsten Ziegeler
While I totally agree that we should try this, there is no way to enforce it - and it always depends on personal opinion about whether something is worth testing or is too simple to be tested - yes, I know better being safe than sorry. So, basically +1 - but I don't consider this a blocker We

Re: Automated tests, at least under /bundles

2013-04-05 Thread Felix Meschberger
Who could say no to this question ? ;-) Regards Felix Am 05.04.2013 um 10:53 schrieb Bertrand Delacretaz: Hi, We just had a little ironic exchange with Carsten in SLING-2813...am I the only one who thinks that all our core code should be covered by automated tests? I don't mean

Re: Automated tests, at least under /bundles

2013-04-05 Thread Bertrand Delacretaz
On Fri, Apr 5, 2013 at 10:56 AM, Carsten Ziegeler cziege...@apache.org wrote: ...basically +1 - but I don't consider this a blocker We have the same situation with documentation... The impact of incomplete documentation is way less than having untested code to our core. Either we care about

Re: Automated tests, at least under /bundles

2013-04-05 Thread Carsten Ziegeler
+1 2013/4/5 Bertrand Delacretaz bdelacre...@apache.org On Fri, Apr 5, 2013 at 10:56 AM, Carsten Ziegeler cziege...@apache.org wrote: ...basically +1 - but I don't consider this a blocker We have the same situation with documentation... The impact of incomplete documentation is way

Re: Automated tests, at least under /bundles

2013-04-05 Thread Oliver Lietz
Am Freitag, 5. April 2013 schrieb Bertrand Delacretaz: On Fri, Apr 5, 2013 at 10:56 AM, Carsten Ziegeler cziege...@apache.org wrote: hello, ...basically +1 - but I don't consider this a blocker We have the same situation with documentation... The impact of incomplete documentation is

RE: Automated tests, at least under /bundles

2013-04-05 Thread Dan Klco
+1 to documentation and unit tests. Especially documentation in the form of examples. -Original Message- From: Oliver Lietz [mailto:apa...@oliverlietz.de] Sent: Friday, April 05, 2013 6:37 AM To: dev@sling.apache.org Subject: Re: Automated tests, at least under /bundles Am Freitag, 5

Re: Automated tests, at least under /bundles

2013-04-05 Thread Justin Edelson
Hi Bertrand, To be clear, are you proposing that no commit can be made to Sling without automated tests? While I'm certainly in favor of automated tests (and better documentation), this is a significantly higher bar than we have today and I just want us to be crystal clear about what is being

Re: Automated tests, at least under /bundles

2013-04-05 Thread Bertrand Delacretaz
On Fri, Apr 5, 2013 at 2:22 PM, Justin Edelson jus...@justinedelson.com wrote: ...To be clear, are you proposing that no commit can be made to Sling without automated tests?... For core stuff I think we should clearly aim for that. Another metric that might be more flexible is to look at test

Re: Automated tests, at least under /bundles

2013-04-05 Thread Ian Boston
On Saturday, April 6, 2013, Bertrand Delacretaz wrote: On Fri, Apr 5, 2013 at 2:22 PM, Justin Edelson jus...@justinedelson.comjavascript:; wrote: ...To be clear, are you proposing that no commit can be made to Sling without automated tests?... For core stuff I think we should clearly