Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-19 Thread Carsten Ziegeler
Justin Edelson wrote > I think I identified the JCRInstall problem. See > https://issues.apache.org/jira/browse/JCR-2720 > Ah, yes, this could be the problem. > Working around this in the test shouldn't be hard, but it's a nasty bug. We could also revert back to the older sling testing module wi

Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-19 Thread Carsten Ziegeler
Justin Edelson wrote > On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson > wrote: >> I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if >> this is the one which has been "failing for a long time". Great! Thanks Justin. >> >> The problem is in the waitForConfiguration method

Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-18 Thread Justin Edelson
I think I identified the JCRInstall problem. See https://issues.apache.org/jira/browse/JCR-2720 Working around this in the test shouldn't be hard, but it's a nasty bug. Justin On Wed, Aug 18, 2010 at 2:35 PM, Justin Edelson wrote: > On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson > wrote: >>

Re: Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-18 Thread Justin Edelson
On Wed, Aug 18, 2010 at 1:38 PM, Justin Edelson wrote: > I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if > this is the one which has been "failing for a long time". > > The problem is in the waitForConfiguration method of OsgiInstallerTestBase. > > The logic was: > if (res

Failing Installer test (was Re: ConfigAdmin support in Launchpad...)

2010-08-18 Thread Justin Edelson
I fixed the ConfigInstallTest failure in the osgi.it module. Not sure if this is the one which has been "failing for a long time". The problem is in the waitForConfiguration method of OsgiInstallerTestBase. The logic was: if (result != null ||!shouldBePresent) { break; } but this fails to take

Re: ConfigAdmin support in Launchpad...

2010-08-18 Thread Carsten Ziegeler
Felix Meschberger wrote > > I am not particularly keen on putting too much effort into something > which will be thrown almost immediately. > > Rather I would suggest for Carsten to indicate whether he will succeed > in-time for Sling 6 or whether we can be of any help to him getting this > read

Re: ConfigAdmin support in Launchpad...

2010-08-18 Thread Felix Meschberger
Hi, On 17.08.2010 21:51, Justin Edelson wrote: > On 8/17/10 4:20 PM, Felix Meschberger wrote: >> Hi, >> >> Sounds like an interesting approach, too. >> >> I would really like to include the OSGi Install stuff together with >> this "ResourceProvider" and the new File Installer to be included with >

Re: ConfigAdmin support in Launchpad...

2010-08-17 Thread Justin Edelson
On 8/17/10 4:20 PM, Felix Meschberger wrote: > Hi, > > Sounds like an interesting approach, too. > > I would really like to include the OSGi Install stuff together with > this "ResourceProvider" and the new File Installer to be included with > Sling 6. If we go the route as Justin proposed, we wo

Re: ConfigAdmin support in Launchpad...

2010-08-17 Thread Felix Meschberger
Hi, Sounds like an interesting approach, too. I would really like to include the OSGi Install stuff together with this "ResourceProvider" and the new File Installer to be included with Sling 6. If we go the route as Justin proposed, we would probably have to include File Installer configured to t

Re: ConfigAdmin support in Launchpad...

2010-08-17 Thread Carsten Ziegeler
Hi, Justin Edelson wrote > As I mentioned last week, I had some concerns about using FileInstall > for ConfigAdmin support and, more than concerns about FileInstall in > particular, I didn't like the whole approach within Launchpad of > "copying some files out of the JAR/WAR" and didn't want to s

Re: ConfigAdmin support in Launchpad...

2010-08-17 Thread Justin Edelson
updated patchset to remove modifications to osgi.installer: http://codereview.appspot.com/1997042 On Mon, Aug 16, 2010 at 8:44 PM, Justin Edelson wrote: > As I mentioned last week, I had some concerns about using FileInstall > for ConfigAdmin support and, more than concerns about FileInstall in >