[GitHub] [sling-site] jsedding commented on pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-21 Thread GitBox
jsedding commented on pull request #50: URL: https://github.com/apache/sling-site/pull/50#issuecomment-713459393 Thanks @kwin for reviewing again. I have merged this now. This is an automated message from the Apache Git

[GitHub] [sling-site] jsedding merged pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-21 Thread GitBox
jsedding merged pull request #50: URL: https://github.com/apache/sling-site/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (SLING-9795) JUnit 5 support for server-side tests

2020-10-21 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed SLING-9795. - > JUnit 5 support for server-side te

[GitHub] [sling-site] jsedding commented on pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-21 Thread GitBox
jsedding commented on pull request #50: URL: https://github.com/apache/sling-site/pull/50#issuecomment-713404938 @kwin, @bdelacretaz I've changed several paragraphs, hoping it addresses the issues/questions you raised. Could you please have another look? Thanks!

[GitHub] [sling-site] jsedding commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
jsedding commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506328700 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for

[GitHub] [sling-site] jsedding commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
jsedding commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506325944 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -11,7 +11,7 @@ provide different examples including

[GitHub] [sling-site] bdelacretaz commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
bdelacretaz commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506310273 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -11,7 +11,7 @@ provide different examples

[GitHub] [sling-site] bdelacretaz commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
bdelacretaz commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506309019 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for

[GitHub] [sling-site] jsedding commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
jsedding commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506307479 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for

[GitHub] [sling-site] jsedding commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
jsedding commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506306029 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for

[GitHub] [sling-site] jsedding commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
jsedding commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506305711 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for

[GitHub] [sling-site] kwin commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
kwin commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506224614 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for example:

[GitHub] [sling-site] kwin commented on a change in pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
kwin commented on a change in pull request #50: URL: https://github.com/apache/sling-site/pull/50#discussion_r506220485 ## File path: src/main/jbake/content/documentation/bundles/org-apache-sling-junit-bundles.md ## @@ -27,6 +27,42 @@ the test class names, like for example:

[jira] [Updated] (SLING-9795) JUnit 5 support for server-side tests

2020-10-16 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-9795: -- Fix Version/s: JUnit Core 1.1.0 > JUnit 5 support for server-side te

[jira] [Resolved] (SLING-9795) JUnit 5 support for server-side tests

2020-10-16 Thread Julian Sedding (Jira)
[ https://issues.apache.org/jira/browse/SLING-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding resolved SLING-9795. --- Resolution: Fixed > JUnit 5 support for server-side te

[GitHub] [sling-org-apache-sling-junit-core] jsedding closed pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-16 Thread GitBox
jsedding closed pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-15 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-709624321 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-15 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705825250 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-09 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705186049 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705543843 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-08 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705543843 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-08 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705825250 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-08 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705186049 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-08 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705543843 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705186049 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-704261005 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread Julian Sedding
Hi all I prepared some changes to add JUnit 5 support for server-side tests via Apache Sling JUnit Core. I would appreciate a review of the changes by anyone who's interested and who can spare the time. Issue: https://issues.apache.org/jira/browse/SLING-9795 Code changes:

[jira] [Comment Edited] (SLING-9795) JUnit 5 support for server-side tests

2020-10-07 Thread Julian Sedding (Jira)
he changes! was (Author: jsedding): [PR #4|https://github.com/apache/sling-org-apache-sling-junit-core/pull/4] > JUnit 5 support for server-side tests > - > > Key: SLING-9795 > URL: https://issues.apache.o

[GitHub] [sling-site] jsedding opened a new pull request #50: SLING-9795 - JUnit 5 support for server-side tests

2020-10-07 Thread GitBox
jsedding opened a new pull request #50: URL: https://github.com/apache/sling-site/pull/50 - documentation update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SLING-9795) JUnit 5 support for server-side tests

2020-10-07 Thread Julian Sedding (Jira)
-junit-core/pull/4] > JUnit 5 support for server-side tests > - > > Key: SLING-9795 > URL: https://issues.apache.org/jira/browse/SLING-9795 > Project: Sling > Issue Type: Improvement >

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-06 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-704261005 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-junit-core=4=false=BUG)

[GitHub] [sling-org-apache-sling-junit-core] jsedding opened a new pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-06 Thread GitBox
jsedding opened a new pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (SLING-9795) JUnit 5 support for server-side tests

2020-10-06 Thread Julian Sedding (Jira)
Julian Sedding created SLING-9795: - Summary: JUnit 5 support for server-side tests Key: SLING-9795 URL: https://issues.apache.org/jira/browse/SLING-9795 Project: Sling Issue Type