[jira] [Created] (SLING-2882) too much logging of discovery.impl connector with connection errors
Stefan Egli created SLING-2882: -- Summary: too much logging of discovery.impl connector with connection errors Key: SLING-2882 URL: https://issues.apache.org/jira/browse/SLING-2882 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.0 Reporter: Stefan Egli Assignee: Stefan Egli Priority: Minor A topology connector (in the discovery.impl) will be pinged every heartbeat interval. If the connector cannot successfully connect - for example because the URL points to nowhere - there are log.warns issued. These loggings occur too often and should be reduced after a while. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Possible to extend ServerSideTestsBase
Hi Sean, On Fri, May 24, 2013 at 6:46 AM, Sean Steimer sean.stei...@gmail.com wrote: Is there anyway to extend the ServerSideTestsCase class in org.apache.sling.testing.samples.integrationtests? From what I can tell, the module doesn't build or deploy a tests jar, which means if you want to extend this class from another module or project, you're forced to copy and paste the class, which seems like an unnecessary burden to me... That's correct - I wrote that class as an example, thinking that people would want to add their own custom stuff anyway. Basically, the only additional functionality w.r.t SlingTestBase is checking that the junit servlet is ready...maybe that functionality (check a series of URLs for expected results) could be added to the SlingTestBase class instead. Since I wrote that stuff I've been trying to avoid base classes for providing that kind of functionality, and use utility classes instead, to avoid polluting the inheritance tree. It might be worth looking in that direction instead, i.e. transform SlingTestBase (keeping backwards compatibility) and the ServerSideTestsCase into composable utilities. -Bertrand
[jira] [Resolved] (SLING-2833) org.apache.sling.auth.form update dependency version of org.apache.sling.auth.core
[ https://issues.apache.org/jira/browse/SLING-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-2833. Resolution: Fixed Assignee: Bertrand Delacretaz Has been fixed in http://svn.apache.org/r1470410 by setting the dependency to 1.1.0 which is good enough considering we want to depend on the oldest possible version of APIs. Thanks Fabian for reporting this! org.apache.sling.auth.form update dependency version of org.apache.sling.auth.core -- Key: SLING-2833 URL: https://issues.apache.org/jira/browse/SLING-2833 Project: Sling Issue Type: Bug Components: Authentication Reporter: Fabian Christ Assignee: Bertrand Delacretaz Fix For: Form Based Authentication 1.0.4 The dependency from org.apache.sling.auth.form 1.0.3-SNAPSHOT (trunk) to org.apache.sling.auth.core uses the old 1.0.7-SNAPSHOT version instead of a newer released one. Should be updated to 1.1.2. dependency groupIdorg.apache.sling/groupId artifactIdorg.apache.sling.auth.core/artifactId version1.1.2/version scopeprovided/scope /dependency This works in my local setup without problems. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2881) [I18N][Performance] JcrResourceBundleProvider clears the cache on mix:language changes
[ https://issues.apache.org/jira/browse/SLING-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666162#comment-13666162 ] Alexander Klimetschek commented on SLING-2881: -- I think listening for sling:Message should be enough. But.. mix:language modifications are probably necessary to catch changing the language of a dictionary (which I can imagine happens when you create/copy a dictionary, and then change the language to the new one). Maybe we have to event listeners: * sling:Message modification = full reload * mix:language modification = quick check if path is already covered in a cached dictionary and only reload (everything) in this case; if it's a new dictionary and has no strings yet (= no sling:message), we don't have to care, and as soon as a string is added, you get the sling:Message event above [I18N][Performance] JcrResourceBundleProvider clears the cache on mix:language changes -- Key: SLING-2881 URL: https://issues.apache.org/jira/browse/SLING-2881 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: i18n 2.2.4 Environment: CQ5.6 Reporter: Rob Ryan Labels: performance Performance of an appplication using Sling i18n JcrResourceBundleProvider suffers drastically if nodes with mixin type mix:language are modified frequently. The reason for the performance degradation is that JcrResourceBundleProvider registers a JCR event listener for node types: mix:language and sling:Message. It then clears the i18n resource bundle cache whenever a node with these types appears in an event. The JCR 2.0 spec indicates applications should use a mix:language type as the standard way to provide a property specifying the natural language which the content of a node is expressed. Therefore clearing the resource bundle cache on a change to *any* node with a mix:language type is inappropriately broad. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[VOTE] release org.apache.sling.auth.form version 1.0.4
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12315993 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-039/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 039 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for at least 72 hours. -Bertrand
[jira] [Created] (SLING-2883) proper encode properties - and filter anything like jcr:created...
Stefan Egli created SLING-2883: -- Summary: proper encode properties - and filter anything like jcr:created... Key: SLING-2883 URL: https://issues.apache.org/jira/browse/SLING-2883 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.0 Reporter: Stefan Egli Assignee: Stefan Egli properties provided by PropertyProviders in discovery.impl are currently handed 1:1 as name (key) to jcr/repository. This will not work for special characters. A proper encoding must be implemented. Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be treated as a property and not be made visible to the users of the discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2883) proper encode properties - and filter anything like jcr:created...
[ https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666251#comment-13666251 ] Carsten Ziegeler commented on SLING-2883: - The resource implementation should already encode all illegal characters - the only exception I know is a slash. And if key should contain a : or maybe start with jcr:... - you never know what users are using proper encode properties - and filter anything like jcr:created... -- Key: SLING-2883 URL: https://issues.apache.org/jira/browse/SLING-2883 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.0 Reporter: Stefan Egli Assignee: Stefan Egli properties provided by PropertyProviders in discovery.impl are currently handed 1:1 as name (key) to jcr/repository. This will not work for special characters. A proper encoding must be implemented. Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be treated as a property and not be made visible to the users of the discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2883) proper encode properties - and filter anything like jcr:created...
[ https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666270#comment-13666270 ] Stefan Egli commented on SLING-2883: Good to know! I confirmed this: using a : gets properly encoded - a / though causes troubles. So we should deal with / in some way. Filtering jcr:created and jcr:createdBy (which are now newly showing up since it's now a sling:Folder since SLING-2879 - vs an nt:unstructured before) is not critical IMO. proper encode properties - and filter anything like jcr:created... -- Key: SLING-2883 URL: https://issues.apache.org/jira/browse/SLING-2883 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.0 Reporter: Stefan Egli Assignee: Stefan Egli properties provided by PropertyProviders in discovery.impl are currently handed 1:1 as name (key) to jcr/repository. This will not work for special characters. A proper encoding must be implemented. Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be treated as a property and not be made visible to the users of the discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2883) deal with - eg encode - / in property names (was: proper encode properties - and filter anything like jcr:created...)
[ https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-2883: --- Summary: deal with - eg encode - / in property names (was: proper encode properties - and filter anything like jcr:created...) (was: proper encode properties - and filter anything like jcr:created...) deal with - eg encode - / in property names (was: proper encode properties - and filter anything like jcr:created...) --- Key: SLING-2883 URL: https://issues.apache.org/jira/browse/SLING-2883 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.0 Reporter: Stefan Egli Assignee: Stefan Egli properties provided by PropertyProviders in discovery.impl are currently handed 1:1 as name (key) to jcr/repository. This will not work for special characters. A proper encoding must be implemented. Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be treated as a property and not be made visible to the users of the discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] release org.apache.sling.auth.form version 1.0.4
+1 On May 24, 2013, at 5:06 AM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12315993 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-039/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 039 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for at least 72 hours. -Bertrand
[jira] [Updated] (SLING-2883) deal with - eg encode - / in property names (was: proper encode properties - and filter anything like jcr:created...)
[ https://issues.apache.org/jira/browse/SLING-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-2883: --- Priority: Minor (was: Major) deal with - eg encode - / in property names (was: proper encode properties - and filter anything like jcr:created...) --- Key: SLING-2883 URL: https://issues.apache.org/jira/browse/SLING-2883 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.0 Reporter: Stefan Egli Assignee: Stefan Egli Priority: Minor properties provided by PropertyProviders in discovery.impl are currently handed 1:1 as name (key) to jcr/repository. This will not work for special characters. A proper encoding must be implemented. Similarly, any jcr name including ':' (eg 'jcr:created' etc) must not be treated as a property and not be made visible to the users of the discovery.api - the filter done as a hotfix in SLING-2880 is not sufficient. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2884) [Log] Improvements to Web Console plugins
Felix Meschberger created SLING-2884: Summary: [Log] Improvements to Web Console plugins Key: SLING-2884 URL: https://issues.apache.org/jira/browse/SLING-2884 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Log 3.0.0 Reporter: Felix Meschberger The current Web Console plugins of the Commons Log bundles show some defficiencies IMHO: (1) The Configuration Printer writes back all active log files in the printConfiguration method. Probably it should not return the file contents but just a list of active and rotated log files along with their sizes and probably last modification time. (The getAttachments method is correct in adding all active and rotated log files to the ZIP) (2) The Web Console Plugin should not list the absolute path names of the log files but the path names from the original configuration. This might require a new SlingLoggerWriter.getName() method which returns the configured file name. (3) The Web Console Plugin should be extended to: (3a) allow looking at a log file (maybe trailing it ?) (3b) remove single log files (3c) remove rotated log files: single, all, by age -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2884) [Log] Improvements to Web Console plugins
[ https://issues.apache.org/jira/browse/SLING-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger updated SLING-2884: - Issue Type: Improvement (was: Bug) [Log] Improvements to Web Console plugins - Key: SLING-2884 URL: https://issues.apache.org/jira/browse/SLING-2884 Project: Sling Issue Type: Improvement Components: Commons Affects Versions: Commons Log 3.0.0 Reporter: Felix Meschberger The current Web Console plugins of the Commons Log bundles show some defficiencies IMHO: (1) The Configuration Printer writes back all active log files in the printConfiguration method. Probably it should not return the file contents but just a list of active and rotated log files along with their sizes and probably last modification time. (The getAttachments method is correct in adding all active and rotated log files to the ZIP) (2) The Web Console Plugin should not list the absolute path names of the log files but the path names from the original configuration. This might require a new SlingLoggerWriter.getName() method which returns the configured file name. (3) The Web Console Plugin should be extended to: (3a) allow looking at a log file (maybe trailing it ?) (3b) remove single log files (3c) remove rotated log files: single, all, by age -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build is back to normal : sling-trunk-1.7 » Apache Sling Launchpad Application Builder #44
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad/44/
Jenkins build is unstable: sling-trunk-1.7 #44
See https://builds.apache.org/job/sling-trunk-1.7/44/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1671
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1671/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #1671
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1671/
