Re: [VOTE] Release Apache Sling Jackrabbit User Manager version 2.2.6

2017-03-31 Thread Daniel Klco 
+1 checked signature and build

On Fri, Mar 31, 2017 at 6:29 PM, Stefan Seifert 
wrote:

> +1
>
>

RE: [VOTE] Release Apache Sling Jackrabbit User Manager version 2.2.6

2017-03-31 Thread Stefan Seifert 
+1

[GitHub] sling pull request #130: Pull Request for Eclipse Independent Resource Chang...

2017-03-31 Thread schaefa 
Github user schaefa closed the pull request at:

https://github.com/apache/sling/pull/130


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (SLING-2696) Comply with project branding guidelines

2017-03-31 Thread Chris Millar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Millar updated SLING-2696:

Attachment: Apache Sling Logo 2017.zip

*Vector*
Sling Logo - All Styles.ai - Adobe Illustrator
Sling Logo - All Styles.pdf - Adobe PDF
Sling Logo - Close Crop.svg - SVG
Sling Logo - With URL.svg - SVG
Sling Logo.svg - SVG

*PNG*
Sling Logo - Close c...@1x.png
Sling Logo - Close c...@2x.png
Sling Logo - Close c...@3x.png
Sling Logo - With u...@1x.png
Sling Logo - With u...@2x.png
Sling Logo - With u...@3x.png
Sling l...@1x.png
Sling l...@2x.png
Sling l...@3x.png


> Comply with project branding guidelines
> ---
>
> Key: SLING-2696
> URL: https://issues.apache.org/jira/browse/SLING-2696
> Project: Sling
>  Issue Type: Task
>  Components: General
>Reporter: Bertrand Delacretaz
>Assignee: Oliver Lietz
>Priority: Minor
> Attachments: Apache Sling Logo 2017.zip
>
>
> We need to comply with http://www.apache.org/foundation/marks/pmcs.html - the 
> current status is
> Logos and Graphics: TM missing from all Logos
> Project Website Basics: done
> Project Naming And Descriptions: done
> Website Navigation Links: done
> Trademark Attributions: done
> Project Metadata: done



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6764) Guard against reflection failures when registering Sling Model classes

2017-03-31 Thread Justin Edelson (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-6764.
---
Resolution: Fixed

fixed in r1789734

> Guard against reflection failures when registering Sling Model classes
> --
>
> Key: SLING-6764
> URL: https://issues.apache.org/jira/browse/SLING-6764
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Justin Edelson
>Assignee: Justin Edelson
> Fix For: Sling Models Impl 1.3.10
>
>
> While troubleshooting a Sling Models application today, I ran across an 
> interesting case which I think we should better guard against.
> The model class had a dependency upon a class which was in an optionally 
> imported package (which was not present). When the bundle started, Sling 
> Models' BundleListener tried to instantiate the class and (due to the missing 
> package) failed to do so. Obviously, the problem here is that the import 
> wasn't *actually* optional. 
> The problem was two fold:
> 1) If the problematic bundle was already active when the Sling Models bundle 
> was activated (or updated), there was a NoClassDefError throw inside the 
> ModelAdapterFactory's activate method causing the component to not be fully 
> active. I also suspect that the deactivate method would never have been 
> called, although I didn't get that far.
> 2) If the problematic bundle was active after the Sling Models bundle was 
> activated, then the one problematic model class halted further processing of 
> model classes in that bundle.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6764) Guard against reflection failures when registering Sling Model classes

2017-03-31 Thread Justin Edelson (JIRA) 
Justin Edelson created SLING-6764:
-

 Summary: Guard against reflection failures when registering Sling 
Model classes
 Key: SLING-6764
 URL: https://issues.apache.org/jira/browse/SLING-6764
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: Sling Models Impl 1.3.10


While troubleshooting a Sling Models application today, I ran across an 
interesting case which I think we should better guard against.

The model class had a dependency upon a class which was in an optionally 
imported package (which was not present). When the bundle started, Sling 
Models' BundleListener tried to instantiate the class and (due to the missing 
package) failed to do so. Obviously, the problem here is that the import wasn't 
*actually* optional. 

The problem was two fold:

1) If the problematic bundle was already active when the Sling Models bundle 
was activated (or updated), there was a NoClassDefError throw inside the 
ModelAdapterFactory's activate method causing the component to not be fully 
active. I also suspect that the deactivate method would never have been called, 
although I didn't get that far.

2) If the problematic bundle was active after the Sling Models bundle was 
activated, then the one problematic model class halted further processing of 
model classes in that bundle.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6639) Avoid split packages in the HTL Engine and HTL Java Compiler bundles

2017-03-31 Thread Radu Cotescu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-6639.
-
Resolution: Fixed

Fixed in [r1789701|https://svn.apache.org/r1789701].

> Avoid split packages in the HTL Engine and HTL Java Compiler bundles
> 
>
> Key: SLING-6639
> URL: https://issues.apache.org/jira/browse/SLING-6639
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Tomek Rękawek
>Assignee: Radu Cotescu
> Fix For: Scripting HTL Engine 1.0.34, Scripting HTL Java Compiler 
> 1.0.10
>
> Attachments: SLING-6639.patch
>
>
> {{ResourceResolution}} and {{SightlyException}} classes should be moved to 
> the java-compiler bundle, as this is the one exporting 
> {{org.apache.sling.scripting.sightly}} package. Right now they are the part 
> of the engine bundle, which doesn't export anything and it may lead to issues 
> if some bundle tries to use these two classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6761) HTL: uri manipulator breaks query parameter encoding

2017-03-31 Thread Radu Cotescu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-6761.
-
   Resolution: Fixed
Fix Version/s: Scripting HTL Engine 1.0.34

Fixed in [r1789700|https://svn.apache.org/r1789700].

> HTL: uri manipulator breaks query parameter encoding
> 
>
> Key: SLING-6761
> URL: https://issues.apache.org/jira/browse/SLING-6761
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.2, Scripting Sightly Engine 
> 1.0.18
> Environment: AEM 6.1 SP2 - CFP6
> AEM 6.2
>Reporter: Robin Brouns
>Assignee: Radu Cotescu
> Fix For: Scripting HTL Engine 1.0.34
>
>
> When I try to manipulate a href tag with HTL, and the href contains a query 
> param with encoded percentage sign (%25), the HTL manipulator breaks the URI 
> encoding, resulting in a invalid URI.
> For example when we have a *path* property in the repository, containing the 
> following value:
> {code}
> /example/search?q=6%25-10%25
> {code}
> and use the following HTL code:
> {code}
> Test with @ HTL URI 
> manipulator
> Test without @ HTL URI manipulator
> {code}
> The result will be:
> {code}
> Test with @ HTL URI manipulator
> Test without @ HTL URI manipulator
> {code}
> So the HTL URI manipulation removes the %25 encoding and replaces it with a 
> single percentage sign. Without manipulation the encoding is preserved. Same 
> holds for other HTL uri manipulators like  *@ prependPath*
> Other signs like *%3A* aren't affected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6723) Make dependency to javax.jcr, jcr.contentloader and jcr.api optional

2017-03-31 Thread Carsten Ziegeler (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951013#comment-15951013
 ] 

Carsten Ziegeler commented on SLING-6723:
-

Changed the chunk upload in rev 1789693

> Make dependency to javax.jcr, jcr.contentloader and jcr.api optional
> 
>
> Key: SLING-6723
> URL: https://issues.apache.org/jira/browse/SLING-6723
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.3.16
>
>
> In order to be able to run Sling in a very minimal version, the dependencies 
> to javax.jcr, jcr.api and jcr.contentloader should be optional. Otherwise a 
> whole set of modules needs to be dragged in just to make the servlets post 
> module provide the basic functionality (which is usually sufficient for most 
> applications)
> It seems with minimizing the dependency to JCR we can also clean up the code 
> as it is quiet of often adapting to JCR objects for no real reason and in 
> some cases mixing resource and node handling, where just sticking with one or 
> the other would do less operations



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (SLING-6761) HTL: uri manipulator breaks query parameter encoding

2017-03-31 Thread Radu Cotescu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-6761:
---

Assignee: Radu Cotescu

> HTL: uri manipulator breaks query parameter encoding
> 
>
> Key: SLING-6761
> URL: https://issues.apache.org/jira/browse/SLING-6761
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.2, Scripting Sightly Engine 
> 1.0.18
> Environment: AEM 6.1 SP2 - CFP6
> AEM 6.2
>Reporter: Robin Brouns
>Assignee: Radu Cotescu
>
> When I try to manipulate a href tag with HTL, and the href contains a query 
> param with encoded percentage sign (%25), the HTL manipulator breaks the URI 
> encoding, resulting in a invalid URI.
> For example when we have a *path* property in the repository, containing the 
> following value:
> {code}
> /example/search?q=6%25-10%25
> {code}
> and use the following HTL code:
> {code}
> Test with @ HTL URI 
> manipulator
> Test without @ HTL URI manipulator
> {code}
> The result will be:
> {code}
> Test with @ HTL URI manipulator
> Test without @ HTL URI manipulator
> {code}
> So the HTL URI manipulation removes the %25 encoding and replaces it with a 
> single percentage sign. Without manipulation the encoding is preserved. Same 
> holds for other HTL uri manipulators like  *@ prependPath*
> Other signs like *%3A* aren't affected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6763) Remove org.apache.sling.commons.json depdency from esx engine

2017-03-31 Thread Senol Tas (JIRA) 
Senol Tas created SLING-6763:


 Summary: Remove org.apache.sling.commons.json depdency from esx 
engine
 Key: SLING-6763
 URL: https://issues.apache.org/jira/browse/SLING-6763
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Apache Sling Scripting ESX 0.2.0
Reporter: Senol Tas


remove org.apache.sling.commons.json dependency from esx engine and replace 
with native build in nashorn JSON parser
+ minor updates in the demo package to showcase the usage of dynamically 
changing handlebars templates based on selector.

i created a pull request on github:
https://github.com/apache/sling/pull/209



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json

2017-03-31 Thread Carsten Ziegeler (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950887#comment-15950887
 ] 

Carsten Ziegeler commented on SLING-6679:
-

Ok, let's agree that we regard this differently. So all is fine I guess and 
I'll shut up

> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
>  Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] sling pull request #209: [contrib esx] removed org.apache.sling.commons.json...

2017-03-31 Thread labertasch 
GitHub user labertasch opened a pull request:

https://github.com/apache/sling/pull/209

[contrib esx] removed org.apache.sling.commons.json dependencies and 
lceaned up the demo" esx/

[contrib esx] removed org.apache.sling.commons.json dependencies and 
updated the demo

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/labertasch/sling trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #209


commit d22137f649be960cde65bc40fe5de77a10842aeb
Author: Senol 
Date:   2017-03-31T13:35:05Z

[contrib esx] removed org.apache.sling.commons.json dependencies and 
lceaned up the demo

commit 62e89ddd4b67ca6e17ea69e14cf896b9d39584be
Author: Senol 
Date:   2017-03-31T13:36:11Z

[contrib esx] removed org.apache.sling.commons.json dependencies and 
lceaned up the demo" esx/




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json

2017-03-31 Thread Karl Pauls (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950809#comment-15950809
 ] 

Karl Pauls commented on SLING-6679:
---

I'm not sure I agree - but regardless:

I'm wondering why you think that your goal of running Sling with less bundles 
is somehow more achievable with the JSONWriter v.s. javax.json. 
Granted, the JSONWriter weighs in with about 10k v.s. about 100k for the 
johnzon bundle but otherwise, the current johnzon bundle has no dependencies 
whatsoever so you could just as well inline that one into the bundles in 
question no?

> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
>  Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json

2017-03-31 Thread Carsten Ziegeler (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950730#comment-15950730
 ] 

Carsten Ziegeler commented on SLING-6679:
-

Sure, but with that argument we could also say if one bundle is using bundle Y, 
then let's use Y all over the place :)
I would like to get a running Sling with as less bundles as possible; now I 
totally agree that it doesn't make sense to replace the json library in 
servlets.get or the importer. But for modules which just produce json to be 
consumed by a web console plugin I think it makes more sense. I haven't looked 
at all of those modules, but maybe it just applies to one or two of them; 
adapter being one.

> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
>  Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json

2017-03-31 Thread Karl Pauls (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950714#comment-15950714
 ] 

Karl Pauls commented on SLING-6679:
---

[~cziegeler], hm, I'm not so sure that makes that much sense. If we need 
javax.json around anyways we might as well use it. What benefit do you see in 
embedding the JSONWriter all over the place?

> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
>  Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we 
> need to replace its usage everywhere else (at least if we want to be able to 
> release other modules that depend on it). 
> This is the umbrella issue for getting this done. The idea is to create 
> sub-issues with patches for individual components, review the patches, and 
> when all are done: close this issue. 
> General discussions and problems should go to this issue and specific ones on 
> the sub-issue in question.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6713) Remove commons.json and org.json from launchpad

2017-03-31 Thread Karl Pauls (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950710#comment-15950710
 ] 

Karl Pauls commented on SLING-6713:
---

Ah right, [~rombert] - I only checked launchpad/testing and forgot about 
launchpad/testing-war. Thanks.

> Remove commons.json and org.json from launchpad
> ---
>
> Key: SLING-6713
> URL: https://issues.apache.org/jira/browse/SLING-6713
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>  Labels: Sling-9-ReleaseNotes
> Attachments: SLING-6713.patch
>
>
> We need to remove commons.json from the launchpad provisioning, add the 
> commons.johnzon bundle, and update all bundles after we switched them to 
> johnzon. 
> Furthermore, we need to make sure it still works :-)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6713) Remove commons.json and org.json from launchpad

2017-03-31 Thread Robert Munteanu (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950682#comment-15950682
 ] 

Robert Munteanu commented on SLING-6713:


Updated launchpad/testing-war to include the {{commons.json}} bundle, otherwise 
the testing-services bundle does not resolve.

> Remove commons.json and org.json from launchpad
> ---
>
> Key: SLING-6713
> URL: https://issues.apache.org/jira/browse/SLING-6713
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>  Labels: Sling-9-ReleaseNotes
> Attachments: SLING-6713.patch
>
>
> We need to remove commons.json from the launchpad provisioning, add the 
> commons.johnzon bundle, and update all bundles after we switched them to 
> johnzon. 
> Furthermore, we need to make sure it still works :-)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (SLING-6713) Remove commons.json and org.json from launchpad

2017-03-31 Thread Robert Munteanu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6713:
---
Labels: Sling-9-ReleaseNotes  (was: )

> Remove commons.json and org.json from launchpad
> ---
>
> Key: SLING-6713
> URL: https://issues.apache.org/jira/browse/SLING-6713
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>  Labels: Sling-9-ReleaseNotes
> Attachments: SLING-6713.patch
>
>
> We need to remove commons.json from the launchpad provisioning, add the 
> commons.johnzon bundle, and update all bundles after we switched them to 
> johnzon. 
> Furthermore, we need to make sure it still works :-)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6762) Use target filter for servlet references

2017-03-31 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6762.
-
Resolution: Feedback Received

Further simplified the handling of servlets in rev 1789652
Unfortunately we still have to wait for the registration/processing of servlets 
until the servlets resolver is activated

> Use target filter for servlet references
> 
>
> Key: SLING-6762
> URL: https://issues.apache.org/jira/browse/SLING-6762
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> Currently the servlets resolver references *all* servlets and then filters 
> out those servlets not targetted at Sling. However DS can do this already for 
> us, avoiding unnecessary bindings of servlets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Adapter Annotations

2017-03-31 Thread Konrad Windszus 
Which tooling is supposed to evaluate the adapter annotations 
(https://github.com/apache/sling/tree/trunk/tooling/maven/adapter-annotations/src/main/java/org/apache/sling/adapter/annotations),
 being added with https://issues.apache.org/jira/browse/SLING-2313? Is it only 
the maven-sling-plugin? That IMHO seems to be the wrong place for it. I would 
rather do this kind of stuff in a bnd plugin, because that extends the 
generated bundle.
Also I am wondering, whether this is just used for feeding the according web 
console, or whether there is something more about it (automatically registering 
some adapter factory maybe)

Also the information about the JSON and the tooling around it should probably 
be mentioned in 
https://sling.apache.org/documentation/the-sling-engine/adapters.html.
Thanks for some input on that.
Konrad

[jira] [Reopened] (SLING-6762) Use target filter for servlet references

2017-03-31 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-6762:
-

We can even further optimize the code with this: as we now know that the 
servlet is for the servlets resolver we can let DS get the instance

> Use target filter for servlet references
> 
>
> Key: SLING-6762
> URL: https://issues.apache.org/jira/browse/SLING-6762
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> Currently the servlets resolver references *all* servlets and then filters 
> out those servlets not targetted at Sling. However DS can do this already for 
> us, avoiding unnecessary bindings of servlets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6762) Use target filter for servlet references

2017-03-31 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6762.
-
Resolution: Fixed

Added target filter in rev 1789647

> Use target filter for servlet references
> 
>
> Key: SLING-6762
> URL: https://issues.apache.org/jira/browse/SLING-6762
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> Currently the servlets resolver references *all* servlets and then filters 
> out those servlets not targetted at Sling. However DS can do this already for 
> us, avoiding unnecessary bindings of servlets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[VOTE] Release Apache Sling Jackrabbit User Manager version 2.2.6

2017-03-31 Thread Konrad Windszus 
Hi, 
We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12333854/

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1682

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh 
Usage:
sh check_staged_release.sh 1682 /tmp/sling-staging 
Please vote to approve this release: 
[ ] +1 Approve the release 
[ ] 0 Don't care
[ ] -1 Don't release, because ... 
This majority vote is open for at least 72 hours.

[jira] [Created] (SLING-6762) Use target filter for servlet references

2017-03-31 Thread Carsten Ziegeler (JIRA) 
Carsten Ziegeler created SLING-6762:
---

 Summary: Use target filter for servlet references
 Key: SLING-6762
 URL: https://issues.apache.org/jira/browse/SLING-6762
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Resolver 2.4.12


Currently the servlets resolver references *all* servlets and then filters out 
those servlets not targetted at Sling. However DS can do this already for us, 
avoiding unnecessary bindings of servlets



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6760) Improve logging if servlet can't be get from the registry

2017-03-31 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6760.
-
Resolution: Fixed

Improved logging in rev 1789646

> Improve logging if servlet can't be get from the registry
> -
>
> Key: SLING-6760
> URL: https://issues.apache.org/jira/browse/SLING-6760
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Resolver 2.4.12
>
>
> The current logging in the case of an error is a little bit misleading and 
> also does not include important information about the service which is in 
> processing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6708) Sling Dynamic Include - Usage of nocache selector allows uncached access to everything

2017-03-31 Thread Henry Kuijpers (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Kuijpers resolved SLING-6708.
---
Resolution: Not A Bug

Indeed, this is not a Sling bug, however, maybe there is something needed 
inside Sling to allow a good solution. Will create another ticket for that if 
it's needed.

> Sling Dynamic Include - Usage of nocache selector allows uncached access to 
> everything
> --
>
> Key: SLING-6708
> URL: https://issues.apache.org/jira/browse/SLING-6708
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.0.2
>Reporter: Henry Kuijpers
>Priority: Blocker
>
> The SDI module works with a nocache-selector (or a selector that we 
> arbitrarily choose).
> However, we cannot guarantee that only SDI's requests come in through the 
> nocache-selector. It can be any request.
> This document says https://github.com/Cognifide/Sling-Dynamic-Include
> that we should configure the Dispatcher to not cache when 
> {code}*.nocache.html*{code} can be applied to the request.
> This means that anyone can use the nocache-selector on any request to bypass 
> Dispatcher caching for html files.
> It even means that ".nocache.html" can appear anywhere in the full request 
> URL.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6740) HTL Blog Sample

2017-03-31 Thread Bertrand Delacretaz (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950592#comment-15950592
 ] 

Bertrand Delacretaz commented on SLING-6740:


+1 for a more modern blog sample. I think it's good to stay minimalist, so that 
someone can understand the whole code in a few minutes of study.

> HTL Blog Sample
> ---
>
> Key: SLING-6740
> URL: https://issues.apache.org/jira/browse/SLING-6740
> Project: Sling
>  Issue Type: Improvement
>Reporter: Chris Millar
>Priority: Minor
>
> The ESP blog sample is a little long in tooth. It should either be updated or 
> replaced by an HTL blog sample.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (SLING-6759) Update Karaf to 4.1.1

2017-03-31 Thread Oliver Lietz (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-6759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-6759.
-
Resolution: Done

[r1789632|https://svn.apache.org/r1789632]
[r1789633|https://svn.apache.org/r1789633]
[r1789634|https://svn.apache.org/r1789634]
[r1789635|https://svn.apache.org/r1789635]
[r1789636|https://svn.apache.org/r1789636]

> Update Karaf to 4.1.1
> -
>
> Key: SLING-6759
> URL: https://issues.apache.org/jira/browse/SLING-6759
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
> Karaf Distribution 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6761) HTL: uri manipulator breaks query parameter encoding

2017-03-31 Thread Robin Brouns (JIRA) 
Robin Brouns created SLING-6761:
---

 Summary: HTL: uri manipulator breaks query parameter encoding
 Key: SLING-6761
 URL: https://issues.apache.org/jira/browse/SLING-6761
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.18, Scripting Sightly Engine 
1.0.2
 Environment: AEM 6.1 SP2 - CFP6
AEM 6.2
Reporter: Robin Brouns


When I try to manipulate a href tag with HTL, and the href contains a query 
param with encoded percentage sign (%25), the HTL manipulator breaks the URI 
encoding, resulting in a invalid URI.

For example when we have a *path* property in the repository, containing the 
following value:

{code}
/example/search?q=6%25-10%25
{code}

and use the following HTL code:

{code}
Test with @ HTL URI 
manipulator
Test without @ HTL URI manipulator
{code}

The result will be:

{code}
Test with @ HTL URI manipulator
Test without @ HTL URI manipulator
{code}

So the HTL URI manipulation removes the %25 encoding and replaces it with a 
single percentage sign. Without manipulation the encoding is preserved. Same 
holds for other HTL uri manipulators like  *@ prependPath*

Other signs like *%3A* aren't affected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6760) Improve logging if servlet can't be get from the registry

2017-03-31 Thread Carsten Ziegeler (JIRA) 
Carsten Ziegeler created SLING-6760:
---

 Summary: Improve logging if servlet can't be get from the registry
 Key: SLING-6760
 URL: https://issues.apache.org/jira/browse/SLING-6760
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Resolver 2.4.12


The current logging in the case of an error is a little bit misleading and also 
does not include important information about the service which is in processing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (SLING-6759) Update Karaf to 4.1.1

2017-03-31 Thread Oliver Lietz (JIRA) 
Oliver Lietz created SLING-6759:
---

 Summary: Update Karaf to 4.1.1
 Key: SLING-6759
 URL: https://issues.apache.org/jira/browse/SLING-6759
 Project: Sling
  Issue Type: Task
  Components: Karaf
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Features 0.2.0, Karaf Integration Tests 0.2.0, 
Karaf Distribution 0.2.0






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6666) Make Sling shiny

2017-03-31 Thread Bertrand Delacretaz (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950516#comment-15950516
 ] 

Bertrand Delacretaz commented on SLING-:


Thanks [~auniverseaway] for the refreshed logo, I like it! I'm +1 for switching 
to it once it we have it in vector format with a TM, and we should then credit 
Chris somewhere on our website.

> Make Sling shiny
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Task
>  Components: General
>Reporter: Oliver Lietz
> Attachments: Sling-4x.png
>
>
> https://cwiki.apache.org/confluence/display/SLING/Make+Sling+shiny



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (SLING-6666) Make Sling shiny

2017-03-31 Thread Oliver Lietz (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950507#comment-15950507
 ] 

Oliver Lietz commented on SLING-:
-

[~karlpauls], you cannot hijack this issue... 8D _Making Sling shiny_ is a 
community effort and everyone is welcome.

I also started to _fix_ the logo a while ago and therefore picked SLING-2696 to 
get it done finally – [~auniverseaway], can you provide your logo update in a 
vector format?

[~klcodanr], thanks for starting a discussion on 
[dev@|https://lists.apache.org/thread.html/3e0841adfb2315ae18afb62769dafdbf1703369ed8906372d395f60a@%3Cdev.sling.apache.org%3E].
 Our findings should be collected in the wiki and tasks filed in separate 
issues.

> Make Sling shiny
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Task
>  Components: General
>Reporter: Oliver Lietz
> Attachments: Sling-4x.png
>
>
> https://cwiki.apache.org/confluence/display/SLING/Make+Sling+shiny



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)